From: Tero Kristo <t-kristo@ti.com>
To: Tony Lindgren <tony@atomide.com>
Cc: <linux-omap@vger.kernel.org>, <linux-arm-kernel@lists.infradead.org>
Subject: Re: [PATCH 1/8] ARM: dts: omap4: fix node names for the l4_cm clkctrl nodes
Date: Thu, 30 Apr 2020 11:34:11 +0300 [thread overview]
Message-ID: <cb563fb2-4909-a11a-d167-a5e982f38968@ti.com> (raw)
In-Reply-To: <fef91f43-df5f-99e4-7861-05190fcc2040@ti.com>
On 30/04/2020 07:55, Tero Kristo wrote:
> On 30/04/2020 01:07, Tony Lindgren wrote:
>> * Tero Kristo <t-kristo@ti.com> [200429 14:31]:
>>> The node name for these should be clk instead of clock. Otherwise the
>>> clock driver won't be able to map the parent/child relationships
>>> properly, and large number of clocks end up in orphaned state.
>>>
>>> Signed-off-by: Tero Kristo <t-kristo@ti.com>
>>> ---
>>> arch/arm/boot/dts/omap44xx-clocks.dtsi | 4 ++--
>>> 1 file changed, 2 insertions(+), 2 deletions(-)
>>>
>>> diff --git a/arch/arm/boot/dts/omap44xx-clocks.dtsi
>>> b/arch/arm/boot/dts/omap44xx-clocks.dtsi
>>> index 532868591107..b82b1ca0e557 100644
>>> --- a/arch/arm/boot/dts/omap44xx-clocks.dtsi
>>> +++ b/arch/arm/boot/dts/omap44xx-clocks.dtsi
>>> @@ -1279,13 +1279,13 @@
>>> #size-cells = <1>;
>>> ranges = <0 0x1400 0x200>;
>>> - l4_per_clkctrl: clock@20 {
>>> + l4_per_clkctrl: clk@20 {
>>> compatible = "ti,clkctrl-l4-per", "ti,clkctrl";
>>> reg = <0x20 0x144>;
>>> #clock-cells = <2>;
>>> };
>>> - l4_secure_clkctrl: clock@1a0 {
>>> + l4_secure_clkctrl: clk@1a0 {
>>> compatible = "ti,clkctrl-l4-secure", "ti,clkctrl";
>>> reg = <0x1a0 0x3c>;
>>> #clock-cells = <2>;
>>
>> Heh this is no longer needed since commit 6c3090520554
>> ("clk: ti: clkctrl: Fix hidden dependency to node name")
>> that added support for using the compatible name :)
>>
>> Maybe you are using some older tree? Or else there's
>> still something wrong somewhere.
>
> I was using 5.7-rc1 as baseline so can't be that.
>
> Let me try to check this one again.
Ok you can ignore this and patch #2 for omap5 for similar case. It seems
like the patch 6c3090520554 actually forgot to fix the subclock names,
and it causes issues in mixed clock node setup. Will post a fix against
the clock driver shortly.
-Tero
--
Texas Instruments Finland Oy, Porkkalankatu 22, 00180 Helsinki. Y-tunnus/Business ID: 0615521-4. Kotipaikka/Domicile: Helsinki
next prev parent reply other threads:[~2020-04-30 8:34 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-04-29 14:29 [PATCH 0/8] ARM: omap4/5: crypto support fixes Tero Kristo
2020-04-29 14:29 ` [PATCH 1/8] ARM: dts: omap4: fix node names for the l4_cm clkctrl nodes Tero Kristo
2020-04-29 22:07 ` Tony Lindgren
2020-04-30 4:55 ` Tero Kristo
2020-04-30 8:34 ` Tero Kristo [this message]
2020-04-30 20:25 ` Tony Lindgren
2020-05-05 18:21 ` Tony Lindgren
2020-04-29 14:29 ` [PATCH 2/8] ARM: dts: omap5: " Tero Kristo
2020-04-29 14:29 ` [PATCH 3/8] ARM: dts: omap5: add aes1 entry Tero Kristo
2020-04-29 14:29 ` [PATCH 4/8] ARM: dts: omap5: add aes2 entry Tero Kristo
2020-04-29 14:29 ` [PATCH 5/8] ARM: dts: omap5: add SHA crypto accelerator node Tero Kristo
2020-04-29 14:30 ` [PATCH 6/8] ARM: dts: omap5: add DES " Tero Kristo
2020-04-29 14:30 ` [PATCH 7/8] ARM: OMAP4: Make L4SEC clock domain SWSUP only Tero Kristo
2020-04-29 14:30 ` [PATCH 8/8] ARM: OMAP5: " Tero Kristo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=cb563fb2-4909-a11a-d167-a5e982f38968@ti.com \
--to=t-kristo@ti.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-omap@vger.kernel.org \
--cc=tony@atomide.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).