[PATCH] PCI: exynos: Use PTR_ERR_OR_ZERO() to simplify code

[PATCH] PCI: exynos: Use PTR_ERR_OR_ZERO() to simplify code

[zhengbin]

Fixes coccicheck warning:

drivers/pci/controller/dwc/pci-exynos.c:95:1-3: WARNING: PTR_ERR_OR_ZERO can be used

Reported-by: Hulk Robot <hulkci@huawei.com>
Signed-off-by: zhengbin <zhengbin13@huawei.com>
---
 drivers/pci/controller/dwc/pci-exynos.c | 5 +----
 1 file changed, 1 insertion(+), 4 deletions(-)

diff --git a/drivers/pci/controller/dwc/pci-exynos.c b/drivers/pci/controller/dwc/pci-exynos.c
index 14a6ba4..6c9509d 100644
--- a/drivers/pci/controller/dwc/pci-exynos.c
+++ b/drivers/pci/controller/dwc/pci-exynos.c
@@ -92,10 +92,7 @@ static int exynos5440_pcie_get_mem_resources(struct platform_device *pdev,

 	res = platform_get_resource(pdev, IORESOURCE_MEM, 0);
 	ep->mem_res->elbi_base = devm_ioremap_resource(dev, res);
-	if (IS_ERR(ep->mem_res->elbi_base))
-		return PTR_ERR(ep->mem_res->elbi_base);
-
-	return 0;
+	return PTR_ERR_OR_ZERO(ep->mem_res->elbi_base);
 }

 static int exynos5440_pcie_get_clk_resources(struct exynos_pcie *ep)
--
2.7.4

Re: [PATCH] PCI: exynos: Use PTR_ERR_OR_ZERO() to simplify code

[Jingoo Han]

On 11/18/19, 6:20 AM, zhengbin wrote:
>
> Fixes coccicheck warning:
>
> drivers/pci/controller/dwc/pci-exynos.c:95:1-3: WARNING: PTR_ERR_OR_ZERO can be used
>
> Reported-by: Hulk Robot <hulkci@huawei.com>
> Signed-off-by: zhengbin <zhengbin13@huawei.com>

Please write your full name correctly (First name + Second name). 
If 'zhengbin' is just your first name, you have to add your second name.
Or, if  'zhengbin' is already your full name, please separate it with capitalized characters and spaces,
for example, 'Zheng Bin'.

> ---
>  drivers/pci/controller/dwc/pci-exynos.c | 5 +----
>  1 file changed, 1 insertion(+), 4 deletions(-)
>

[.....]

Re: [PATCH] PCI: exynos: Use PTR_ERR_OR_ZERO() to simplify code

[zhengbin (A)]

On 2019/11/19 0:35, Jingoo Han wrote:
> On 11/18/19, 6:20 AM, zhengbin wrote:
>> Fixes coccicheck warning:
>>
>> drivers/pci/controller/dwc/pci-exynos.c:95:1-3: WARNING: PTR_ERR_OR_ZERO can be used
>>
>> Reported-by: Hulk Robot <hulkci@huawei.com>
>> Signed-off-by: zhengbin <zhengbin13@huawei.com>
> Please write your full name correctly (First name + Second name). 
> If 'zhengbin' is just your first name, you have to add your second name.
> Or, if  'zhengbin' is already your full name, please separate it with capitalized characters and spaces,
> for example, 'Zheng Bin'.

thanks for your remind. In the previous patch, this is rejected, see details on

https://lkml.org/lkml/2019/5/31/535

So please ignore it

>
>> ---
>>  drivers/pci/controller/dwc/pci-exynos.c | 5 +----
>>  1 file changed, 1 insertion(+), 4 deletions(-)
>>
> [.....]
>
> .
>