* [PATCH] pci: fix warning for struct hisi_pcie_platform_ops
@ 2019-04-15 8:53 Mao Wenan
2019-04-16 6:27 ` Zhou Wang
2019-04-16 10:05 ` Lorenzo Pieralisi
0 siblings, 2 replies; 3+ messages in thread
From: Mao Wenan @ 2019-04-15 8:53 UTC (permalink / raw)
To: wangzhou1, lorenzo.pieralisi, bhelgaas; +Cc: linux-pci, linux-kernel
There is one warning exist while compiling drivers/pci/controller/dwc/pcie-hisi.c.
make allmodconfig ARCH=arm64 CROSS_COMPILE=aarch64-linux-gnu-
make C=2 drivers/pci/controller/dwc/pcie-hisi.o ARCH=arm64 CROSS_COMPILE=aarch64-linux-gnu-
drivers/pci/controller/dwc/pcie-hisi.c:365:21: warning: symbol 'hisi_pcie_platform_ops' was not declared. Should it be static?
Fixes: a2ec1996098("PCI: hisi: Add DT almost-ECAM support for Hip06/Hip07 host controllers")
Reported-by: Hulk Robot <hulkci@huawei.com>
Signed-off-by: Mao Wenan <maowenan@huawei.com>
---
drivers/pci/controller/dwc/pcie-hisi.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/pci/controller/dwc/pcie-hisi.c b/drivers/pci/controller/dwc/pcie-hisi.c
index 6d9e1b2..11f5ff7 100644
--- a/drivers/pci/controller/dwc/pcie-hisi.c
+++ b/drivers/pci/controller/dwc/pcie-hisi.c
@@ -362,7 +362,7 @@ static int hisi_pcie_platform_init(struct pci_config_window *cfg)
return 0;
}
-struct pci_ecam_ops hisi_pcie_platform_ops = {
+static struct pci_ecam_ops hisi_pcie_platform_ops = {
.bus_shift = 20,
.init = hisi_pcie_platform_init,
.pci_ops = {
--
2.7.4
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] pci: fix warning for struct hisi_pcie_platform_ops
2019-04-15 8:53 [PATCH] pci: fix warning for struct hisi_pcie_platform_ops Mao Wenan
@ 2019-04-16 6:27 ` Zhou Wang
2019-04-16 10:05 ` Lorenzo Pieralisi
1 sibling, 0 replies; 3+ messages in thread
From: Zhou Wang @ 2019-04-16 6:27 UTC (permalink / raw)
To: Mao Wenan, lorenzo.pieralisi, bhelgaas; +Cc: linux-pci, linux-kernel
On 2019/4/15 16:53, Mao Wenan wrote:
> There is one warning exist while compiling drivers/pci/controller/dwc/pcie-hisi.c.
> make allmodconfig ARCH=arm64 CROSS_COMPILE=aarch64-linux-gnu-
> make C=2 drivers/pci/controller/dwc/pcie-hisi.o ARCH=arm64 CROSS_COMPILE=aarch64-linux-gnu-
> drivers/pci/controller/dwc/pcie-hisi.c:365:21: warning: symbol 'hisi_pcie_platform_ops' was not declared. Should it be static?
>
> Fixes: a2ec1996098("PCI: hisi: Add DT almost-ECAM support for Hip06/Hip07 host controllers")
> Reported-by: Hulk Robot <hulkci@huawei.com>
> Signed-off-by: Mao Wenan <maowenan@huawei.com>
Acked-by: Zhou Wang <wangzhou1@hisilicon.com>
Thanks,
Zhou
> ---
> drivers/pci/controller/dwc/pcie-hisi.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/pci/controller/dwc/pcie-hisi.c b/drivers/pci/controller/dwc/pcie-hisi.c
> index 6d9e1b2..11f5ff7 100644
> --- a/drivers/pci/controller/dwc/pcie-hisi.c
> +++ b/drivers/pci/controller/dwc/pcie-hisi.c
> @@ -362,7 +362,7 @@ static int hisi_pcie_platform_init(struct pci_config_window *cfg)
> return 0;
> }
>
> -struct pci_ecam_ops hisi_pcie_platform_ops = {
> +static struct pci_ecam_ops hisi_pcie_platform_ops = {
> .bus_shift = 20,
> .init = hisi_pcie_platform_init,
> .pci_ops = {
>
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] pci: fix warning for struct hisi_pcie_platform_ops
2019-04-15 8:53 [PATCH] pci: fix warning for struct hisi_pcie_platform_ops Mao Wenan
2019-04-16 6:27 ` Zhou Wang
@ 2019-04-16 10:05 ` Lorenzo Pieralisi
1 sibling, 0 replies; 3+ messages in thread
From: Lorenzo Pieralisi @ 2019-04-16 10:05 UTC (permalink / raw)
To: Mao Wenan; +Cc: wangzhou1, bhelgaas, linux-pci, linux-kernel
On Mon, Apr 15, 2019 at 04:53:49PM +0800, Mao Wenan wrote:
> There is one warning exist while compiling drivers/pci/controller/dwc/pcie-hisi.c.
> make allmodconfig ARCH=arm64 CROSS_COMPILE=aarch64-linux-gnu-
> make C=2 drivers/pci/controller/dwc/pcie-hisi.o ARCH=arm64 CROSS_COMPILE=aarch64-linux-gnu-
> drivers/pci/controller/dwc/pcie-hisi.c:365:21: warning: symbol 'hisi_pcie_platform_ops' was not declared. Should it be static?
>
> Fixes: a2ec1996098("PCI: hisi: Add DT almost-ECAM support for Hip06/Hip07 host controllers")
> Reported-by: Hulk Robot <hulkci@huawei.com>
> Signed-off-by: Mao Wenan <maowenan@huawei.com>
> ---
> drivers/pci/controller/dwc/pcie-hisi.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
Applied to pci/misc, thanks.
Lorenzo
> diff --git a/drivers/pci/controller/dwc/pcie-hisi.c b/drivers/pci/controller/dwc/pcie-hisi.c
> index 6d9e1b2..11f5ff7 100644
> --- a/drivers/pci/controller/dwc/pcie-hisi.c
> +++ b/drivers/pci/controller/dwc/pcie-hisi.c
> @@ -362,7 +362,7 @@ static int hisi_pcie_platform_init(struct pci_config_window *cfg)
> return 0;
> }
>
> -struct pci_ecam_ops hisi_pcie_platform_ops = {
> +static struct pci_ecam_ops hisi_pcie_platform_ops = {
> .bus_shift = 20,
> .init = hisi_pcie_platform_init,
> .pci_ops = {
> --
> 2.7.4
>
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2019-04-16 10:05 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-04-15 8:53 [PATCH] pci: fix warning for struct hisi_pcie_platform_ops Mao Wenan
2019-04-16 6:27 ` Zhou Wang
2019-04-16 10:05 ` Lorenzo Pieralisi
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).