* [PATCH] PCI: imx6: Allow async probe
@ 2019-04-04 16:45 Lucas Stach
2019-04-04 17:32 ` Fabio Estevam
2019-04-16 10:26 ` Lorenzo Pieralisi
0 siblings, 2 replies; 5+ messages in thread
From: Lucas Stach @ 2019-04-04 16:45 UTC (permalink / raw)
To: Richard Zhu, Lorenzo Pieralisi
Cc: Bjorn Helgaas, linux-pci, linux-arm-kernel, kernel, patchwork-lst
Establishing a PCIe link can take a while. Allow async probing so all
this happens in the background while other devices are being probed.
Signed-off-by: Lucas Stach <l.stach@pengutronix.de>
---
drivers/pci/controller/dwc/pci-imx6.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/pci/controller/dwc/pci-imx6.c b/drivers/pci/controller/dwc/pci-imx6.c
index 3d627f94a166..2eb39d5de4f6 100644
--- a/drivers/pci/controller/dwc/pci-imx6.c
+++ b/drivers/pci/controller/dwc/pci-imx6.c
@@ -1279,6 +1279,7 @@ static struct platform_driver imx6_pcie_driver = {
.of_match_table = imx6_pcie_of_match,
.suppress_bind_attrs = true,
.pm = &imx6_pcie_pm_ops,
+ .probe_type = PROBE_PREFER_ASYNCHRONOUS,
},
.probe = imx6_pcie_probe,
.shutdown = imx6_pcie_shutdown,
--
2.20.1
^ permalink raw reply related [flat|nested] 5+ messages in thread* Re: [PATCH] PCI: imx6: Allow async probe
2019-04-04 16:45 [PATCH] PCI: imx6: Allow async probe Lucas Stach
@ 2019-04-04 17:32 ` Fabio Estevam
2019-04-05 8:38 ` Lucas Stach
2019-04-16 10:26 ` Lorenzo Pieralisi
1 sibling, 1 reply; 5+ messages in thread
From: Fabio Estevam @ 2019-04-04 17:32 UTC (permalink / raw)
To: Lucas Stach
Cc: Richard Zhu, Lorenzo Pieralisi, Bjorn Helgaas, linux-pci,
moderated list:ARM/FREESCALE IMX / MXC ARM ARCHITECTURE,
Sascha Hauer, patchwork-lst
Hi Lucas,
On Thu, Apr 4, 2019 at 1:46 PM Lucas Stach <l.stach@pengutronix.de> wrote:
>
> Establishing a PCIe link can take a while. Allow async probing so all
> this happens in the background while other devices are being probed.
>
> Signed-off-by: Lucas Stach <l.stach@pengutronix.de>
> ---
> drivers/pci/controller/dwc/pci-imx6.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/pci/controller/dwc/pci-imx6.c b/drivers/pci/controller/dwc/pci-imx6.c
> index 3d627f94a166..2eb39d5de4f6 100644
> --- a/drivers/pci/controller/dwc/pci-imx6.c
> +++ b/drivers/pci/controller/dwc/pci-imx6.c
> @@ -1279,6 +1279,7 @@ static struct platform_driver imx6_pcie_driver = {
> .of_match_table = imx6_pcie_of_match,
> .suppress_bind_attrs = true,
> .pm = &imx6_pcie_pm_ops,
> + .probe_type = PROBE_PREFER_ASYNCHRONOUS,
This does not seem to be imx6 specific.
Should this be moved to
drivers/pci/controller/dwc/pcie-designware-plat.c instead?
Thanks
^ permalink raw reply [flat|nested] 5+ messages in thread* Re: [PATCH] PCI: imx6: Allow async probe
2019-04-04 17:32 ` Fabio Estevam
@ 2019-04-05 8:38 ` Lucas Stach
2019-04-05 11:42 ` Fabio Estevam
0 siblings, 1 reply; 5+ messages in thread
From: Lucas Stach @ 2019-04-05 8:38 UTC (permalink / raw)
To: Fabio Estevam
Cc: Richard Zhu, Lorenzo Pieralisi, Bjorn Helgaas, linux-pci,
moderated list:ARM/FREESCALE IMX / MXC ARM ARCHITECTURE,
Sascha Hauer, patchwork-lst
Hi Fabio,
Am Donnerstag, den 04.04.2019, 14:32 -0300 schrieb Fabio Estevam:
> Hi Lucas,
>
> > On Thu, Apr 4, 2019 at 1:46 PM Lucas Stach <l.stach@pengutronix.de> wrote:
> >
> > Establishing a PCIe link can take a while. Allow async probing so all
> > this happens in the background while other devices are being probed.
> >
> > > > Signed-off-by: Lucas Stach <l.stach@pengutronix.de>
> > ---
> > drivers/pci/controller/dwc/pci-imx6.c | 1 +
> > 1 file changed, 1 insertion(+)
> >
> > diff --git a/drivers/pci/controller/dwc/pci-imx6.c b/drivers/pci/controller/dwc/pci-imx6.c
> > index 3d627f94a166..2eb39d5de4f6 100644
> > --- a/drivers/pci/controller/dwc/pci-imx6.c
> > +++ b/drivers/pci/controller/dwc/pci-imx6.c
> > @@ -1279,6 +1279,7 @@ static struct platform_driver imx6_pcie_driver = {
> > .of_match_table = imx6_pcie_of_match,
> > .suppress_bind_attrs = true,
> > .pm = &imx6_pcie_pm_ops,
> > + .probe_type = PROBE_PREFER_ASYNCHRONOUS,
>
> This does not seem to be imx6 specific.
>
> Should this be moved to
> drivers/pci/controller/dwc/pcie-designware-plat.c instead?
This property needs to be set in the SoC specific driver that gets
probed, we don't use pcie-designware-plat.c t all. While it isn't
really i.MX specific, I won't go around and set it for platforms I
can't test, as the async behavior may have some unexpected consequences
on other platforms.
Regards,
Lucas
^ permalink raw reply [flat|nested] 5+ messages in thread* Re: [PATCH] PCI: imx6: Allow async probe
2019-04-05 8:38 ` Lucas Stach
@ 2019-04-05 11:42 ` Fabio Estevam
0 siblings, 0 replies; 5+ messages in thread
From: Fabio Estevam @ 2019-04-05 11:42 UTC (permalink / raw)
To: Lucas Stach
Cc: Richard Zhu, Lorenzo Pieralisi, Bjorn Helgaas, linux-pci,
moderated list:ARM/FREESCALE IMX / MXC ARM ARCHITECTURE,
Sascha Hauer, patchwork-lst
Hi Lucas,
On Fri, Apr 5, 2019 at 5:38 AM Lucas Stach <l.stach@pengutronix.de> wrote:
> This property needs to be set in the SoC specific driver that gets
> probed, we don't use pcie-designware-plat.c t all. While it isn't
> really i.MX specific, I won't go around and set it for platforms I
> can't test, as the async behavior may have some unexpected consequences
> on other platforms.
Got it. It makes sense:
Reviewed-by: Fabio Estevam <festevam@gmail.com>
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] PCI: imx6: Allow async probe
2019-04-04 16:45 [PATCH] PCI: imx6: Allow async probe Lucas Stach
2019-04-04 17:32 ` Fabio Estevam
@ 2019-04-16 10:26 ` Lorenzo Pieralisi
1 sibling, 0 replies; 5+ messages in thread
From: Lorenzo Pieralisi @ 2019-04-16 10:26 UTC (permalink / raw)
To: Lucas Stach
Cc: Richard Zhu, Bjorn Helgaas, linux-pci, linux-arm-kernel, kernel,
patchwork-lst
On Thu, Apr 04, 2019 at 06:45:17PM +0200, Lucas Stach wrote:
> Establishing a PCIe link can take a while. Allow async probing so all
> this happens in the background while other devices are being probed.
>
> Signed-off-by: Lucas Stach <l.stach@pengutronix.de>
> ---
> drivers/pci/controller/dwc/pci-imx6.c | 1 +
> 1 file changed, 1 insertion(+)
Applied to pci/dwc, thanks.
Lorenzo
> diff --git a/drivers/pci/controller/dwc/pci-imx6.c b/drivers/pci/controller/dwc/pci-imx6.c
> index 3d627f94a166..2eb39d5de4f6 100644
> --- a/drivers/pci/controller/dwc/pci-imx6.c
> +++ b/drivers/pci/controller/dwc/pci-imx6.c
> @@ -1279,6 +1279,7 @@ static struct platform_driver imx6_pcie_driver = {
> .of_match_table = imx6_pcie_of_match,
> .suppress_bind_attrs = true,
> .pm = &imx6_pcie_pm_ops,
> + .probe_type = PROBE_PREFER_ASYNCHRONOUS,
> },
> .probe = imx6_pcie_probe,
> .shutdown = imx6_pcie_shutdown,
> --
> 2.20.1
>
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2019-04-16 10:26 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-04-04 16:45 [PATCH] PCI: imx6: Allow async probe Lucas Stach
2019-04-04 17:32 ` Fabio Estevam
2019-04-05 8:38 ` Lucas Stach
2019-04-05 11:42 ` Fabio Estevam
2019-04-16 10:26 ` Lorenzo Pieralisi
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).