From: Keith Busch <kbusch@kernel.org>
To: "Derrick, Jonathan" <jonathan.derrick@intel.com>
Cc: "lorenzo.pieralisi@arm.com" <lorenzo.pieralisi@arm.com>,
"helgaas@kernel.org" <helgaas@kernel.org>,
"andrew.murray@arm.com" <andrew.murray@arm.com>,
"Paszkiewicz, Artur" <artur.paszkiewicz@intel.com>,
"Baldysiak, Pawel" <pawel.baldysiak@intel.com>,
"Fugate, David" <david.fugate@intel.com>,
"Shevchenko, Andriy" <andriy.shevchenko@intel.com>,
"linux-pci@vger.kernel.org" <linux-pci@vger.kernel.org>,
"Busch, Keith" <keith.busch@intel.com>
Subject: Re: [PATCH 2/3] PCI: vmd: Expose VMD details from BIOS
Date: Wed, 6 Nov 2019 07:22:47 +0900 [thread overview]
Message-ID: <20191105222247.GA890@redsun51.ssa.fujisawa.hgst.com> (raw)
In-Reply-To: <5a87add6071259c45522001648b29c9e597ebd69.camel@intel.com>
On Tue, Nov 05, 2019 at 09:32:07PM +0000, Derrick, Jonathan wrote:
> Without this patch, a /dev/mem, resource0, or third-party driver could
> overwrite these values if they don't also restore them on close/unbind.
> I imagine a kexec user would also overwrite these values.
Don't you have the same problem with the in-kernel driver? It
looks like pci core will clear the PCI_IO_BASE config registers in
pci_setup_bridge_io() because VMD doesn't provide an IORESOURCE_IO
resource. If you reload the driver, it'll read the wrong values on the
second probing.
next prev parent reply other threads:[~2019-11-05 22:22 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-10-16 17:04 [PATCH 0/3] Expose VMD BIOS domain info Jon Derrick
2019-10-16 17:04 ` [PATCH 1/3] PCI: vmd: Add helpers to access device config space Jon Derrick
2019-10-16 17:04 ` [PATCH 2/3] PCI: vmd: Expose VMD details from BIOS Jon Derrick
2019-10-31 11:37 ` Lorenzo Pieralisi
2019-11-01 13:16 ` Andrew Murray
2019-11-01 14:24 ` Derrick, Jonathan
2019-11-01 14:44 ` Andrew Murray
2019-11-01 21:53 ` Bjorn Helgaas
2019-11-01 22:16 ` Derrick, Jonathan
2019-11-04 18:07 ` Lorenzo Pieralisi
2019-11-05 10:12 ` Lorenzo Pieralisi
2019-11-05 21:32 ` Derrick, Jonathan
2019-11-05 22:22 ` Keith Busch [this message]
2019-11-05 22:38 ` Derrick, Jonathan
2019-11-05 22:45 ` Keith Busch
2020-01-27 10:38 ` Lorenzo Pieralisi
2020-01-27 23:48 ` Derrick, Jonathan
2019-10-16 17:04 ` [PATCH 3/3] PCI: vmd: Restore domain info during resets/unloads Jon Derrick
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20191105222247.GA890@redsun51.ssa.fujisawa.hgst.com \
--to=kbusch@kernel.org \
--cc=andrew.murray@arm.com \
--cc=andriy.shevchenko@intel.com \
--cc=artur.paszkiewicz@intel.com \
--cc=david.fugate@intel.com \
--cc=helgaas@kernel.org \
--cc=jonathan.derrick@intel.com \
--cc=keith.busch@intel.com \
--cc=linux-pci@vger.kernel.org \
--cc=lorenzo.pieralisi@arm.com \
--cc=pawel.baldysiak@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).