From: "Derrick, Jonathan" <jonathan.derrick@intel.com>
To: "helgaas@kernel.org" <helgaas@kernel.org>
Cc: "lorenzo.pieralisi@arm.com" <lorenzo.pieralisi@arm.com>,
"andrew.murray@arm.com" <andrew.murray@arm.com>,
"Paszkiewicz, Artur" <artur.paszkiewicz@intel.com>,
"Baldysiak, Pawel" <pawel.baldysiak@intel.com>,
"Fugate, David" <david.fugate@intel.com>,
"Shevchenko, Andriy" <andriy.shevchenko@intel.com>,
"linux-pci@vger.kernel.org" <linux-pci@vger.kernel.org>,
"Busch, Keith" <keith.busch@intel.com>
Subject: Re: [PATCH 2/3] PCI: vmd: Expose VMD details from BIOS
Date: Fri, 1 Nov 2019 22:16:39 +0000 [thread overview]
Message-ID: <5c4521d26f45cfe01631d14c3d7edc9a10f99245.camel@intel.com> (raw)
In-Reply-To: <20191101215302.GA217821@google.com>
Hi Bjorn,
On Fri, 2019-11-01 at 16:53 -0500, Bjorn Helgaas wrote:
> [+cc Andrew]
>
> On Wed, Oct 16, 2019 at 11:04:47AM -0600, Jon Derrick wrote:
> > When some VMDs are enabled and others are not, it's difficult to
> > determine which IIO stack corresponds to the enabled VMD.
> >
> > To assist userspace with management tasks, VMD BIOS will write the VMD
> > instance number and socket number into the first enabled root port's IO
> > Base/Limit registers prior to OS handoff. VMD driver can capture this
> > information and expose it to userspace.
>
> Hmmm, I'm not sure I understand this, but it sounds possibly fragile.
> Are these Root Ports visible to the generic PCI core device
> enumeration? If so, it will find them and read these I/O window
> registers. Maybe today the PCI core doesn't change them, but I'm not
> sure we should rely on them always being preserved until the vmd
> driver can claim the device.
>
The Root Ports are on the VMD PCI domain, and this IO BASE/LIMIT
parsing occurs before this PCI domain is exposed to the generic PCI
scancode with pci_scan_child_bus(). Until that point the VMD PCI domain
is invisible to the kernel outside of /dev/mem or resource0.
However, yes, it is somewhat fragile in that a third-party driver could
attach to the VMD endpoint prior to the VMD driver and modify the
values. A /dev/mem or resource0 user could also do this on an
unattached VMD endpoint.
I'm wondering if this would also be better suited for a special reset
in quirks.c, but it would need to expose a bit of VMD config accessing
in quirks.c to do that.
> But I guess you're using a special config accessor (vmd_cfg_read()),
> so these are probably invisible to the generic enumeration?
>
Yes the VMD domain is invisible to generic PCI until the domain is
enumerated late in vmd_enable_domain().
> > + * for_each_vmd_root_port - iterate over all enabled VMD Root Ports
> > + * @vmd: &struct vmd_dev VMD device descriptor
> > + * @rp: int iterator cursor
> > + * @temp: u32 temporary value for config read
> > + *
> > + * VMD Root Ports are located in the VMD PCIe Domain at 00:[0-3].0, and config
> > + * space can be determinately accessed through the VMD Config BAR. Because VMD
>
> I'm not sure how to parse "determinately accessed". Maybe this config
> space can *only* be accessed via the VMD Config BAR?
Perhaps it should instead say determinately addressed, as each Root
Port config space is addressable at some offset of N * 0x8000 from the
base of the VMD endpoint config bar. I can see the comment may not be
helpful as that detail is abstracted using the vmd_cfg_read() helper.
>
> > + * Root Ports can be individually disabled, it's important to iterate for the
> > + * first enabled Root Port as determined by reading the Vendor/Device register.
> > + */
> > +#define for_each_vmd_root_port(vmd, rp, temp) \
> > + for (rp = 0; rp < 4; rp++) \
> > + if (vmd_cfg_read(vmd, 0, PCI_DEVFN(root_port, 0), \
> > + PCI_VENDOR_ID, 4, &temp) || \
> > + temp == 0xffffffff) {} else
next prev parent reply other threads:[~2019-11-01 22:16 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-10-16 17:04 [PATCH 0/3] Expose VMD BIOS domain info Jon Derrick
2019-10-16 17:04 ` [PATCH 1/3] PCI: vmd: Add helpers to access device config space Jon Derrick
2019-10-16 17:04 ` [PATCH 2/3] PCI: vmd: Expose VMD details from BIOS Jon Derrick
2019-10-31 11:37 ` Lorenzo Pieralisi
2019-11-01 13:16 ` Andrew Murray
2019-11-01 14:24 ` Derrick, Jonathan
2019-11-01 14:44 ` Andrew Murray
2019-11-01 21:53 ` Bjorn Helgaas
2019-11-01 22:16 ` Derrick, Jonathan [this message]
2019-11-04 18:07 ` Lorenzo Pieralisi
2019-11-05 10:12 ` Lorenzo Pieralisi
2019-11-05 21:32 ` Derrick, Jonathan
2019-11-05 22:22 ` Keith Busch
2019-11-05 22:38 ` Derrick, Jonathan
2019-11-05 22:45 ` Keith Busch
2020-01-27 10:38 ` Lorenzo Pieralisi
2020-01-27 23:48 ` Derrick, Jonathan
2019-10-16 17:04 ` [PATCH 3/3] PCI: vmd: Restore domain info during resets/unloads Jon Derrick
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5c4521d26f45cfe01631d14c3d7edc9a10f99245.camel@intel.com \
--to=jonathan.derrick@intel.com \
--cc=andrew.murray@arm.com \
--cc=andriy.shevchenko@intel.com \
--cc=artur.paszkiewicz@intel.com \
--cc=david.fugate@intel.com \
--cc=helgaas@kernel.org \
--cc=keith.busch@intel.com \
--cc=linux-pci@vger.kernel.org \
--cc=lorenzo.pieralisi@arm.com \
--cc=pawel.baldysiak@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).