linux-pci.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* [PATCH -next] PCI: uniphier: Fix Kconfig warning
@ 2020-06-02 13:10 YueHaibing
  2020-06-02 14:38 ` Lorenzo Pieralisi
  0 siblings, 1 reply; 2+ messages in thread
From: YueHaibing @ 2020-06-02 13:10 UTC (permalink / raw)
  To: lorenzo.pieralisi, robh, bhelgaas, hayashi.kunihiko
  Cc: linux-pci, linux-kernel, YueHaibing

WARNING: unmet direct dependencies detected for PCIE_DW_EP
  Depends on [n]: PCI [=y] && PCI_ENDPOINT [=n]
  Selected by [y]:
  - PCIE_UNIPHIER_EP [=y] && PCI [=y] && (ARCH_UNIPHIER || COMPILE_TEST [=y]) && OF [=y] && HAS_IOMEM [=y]

Add missing dependency to fix this.

Fixes: 006564dee825 ("PCI: uniphier: Add Socionext UniPhier Pro5 PCIe endpoint controller driver")
Signed-off-by: YueHaibing <yuehaibing@huawei.com>
---
 drivers/pci/controller/dwc/Kconfig | 1 +
 1 file changed, 1 insertion(+)

diff --git a/drivers/pci/controller/dwc/Kconfig b/drivers/pci/controller/dwc/Kconfig
index 43a29f7a4501..044a3761c44f 100644
--- a/drivers/pci/controller/dwc/Kconfig
+++ b/drivers/pci/controller/dwc/Kconfig
@@ -293,6 +293,7 @@ config PCIE_UNIPHIER_EP
 	bool "Socionext UniPhier PCIe endpoint controllers"
 	depends on ARCH_UNIPHIER || COMPILE_TEST
 	depends on OF && HAS_IOMEM
+	depends on PCI_ENDPOINT
 	select PCIE_DW_EP
 	help
 	  Say Y here if you want PCIe endpoint controller support on
-- 
2.17.1



^ permalink raw reply related	[flat|nested] 2+ messages in thread

* Re: [PATCH -next] PCI: uniphier: Fix Kconfig warning
  2020-06-02 13:10 [PATCH -next] PCI: uniphier: Fix Kconfig warning YueHaibing
@ 2020-06-02 14:38 ` Lorenzo Pieralisi
  0 siblings, 0 replies; 2+ messages in thread
From: Lorenzo Pieralisi @ 2020-06-02 14:38 UTC (permalink / raw)
  To: YueHaibing; +Cc: robh, bhelgaas, hayashi.kunihiko, linux-pci, linux-kernel

On Tue, Jun 02, 2020 at 09:10:33PM +0800, YueHaibing wrote:
> WARNING: unmet direct dependencies detected for PCIE_DW_EP
>   Depends on [n]: PCI [=y] && PCI_ENDPOINT [=n]
>   Selected by [y]:
>   - PCIE_UNIPHIER_EP [=y] && PCI [=y] && (ARCH_UNIPHIER || COMPILE_TEST [=y]) && OF [=y] && HAS_IOMEM [=y]
> 
> Add missing dependency to fix this.
> 
> Fixes: 006564dee825 ("PCI: uniphier: Add Socionext UniPhier Pro5 PCIe endpoint controller driver")
> Signed-off-by: YueHaibing <yuehaibing@huawei.com>
> ---
>  drivers/pci/controller/dwc/Kconfig | 1 +
>  1 file changed, 1 insertion(+)

Squashed in the commit it is fixing, thanks !

Lorenzo

> diff --git a/drivers/pci/controller/dwc/Kconfig b/drivers/pci/controller/dwc/Kconfig
> index 43a29f7a4501..044a3761c44f 100644
> --- a/drivers/pci/controller/dwc/Kconfig
> +++ b/drivers/pci/controller/dwc/Kconfig
> @@ -293,6 +293,7 @@ config PCIE_UNIPHIER_EP
>  	bool "Socionext UniPhier PCIe endpoint controllers"
>  	depends on ARCH_UNIPHIER || COMPILE_TEST
>  	depends on OF && HAS_IOMEM
> +	depends on PCI_ENDPOINT
>  	select PCIE_DW_EP
>  	help
>  	  Say Y here if you want PCIe endpoint controller support on
> -- 
> 2.17.1
> 
> 

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2020-06-02 14:39 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-06-02 13:10 [PATCH -next] PCI: uniphier: Fix Kconfig warning YueHaibing
2020-06-02 14:38 ` Lorenzo Pieralisi

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).