* [PATCH v2] PCI/ACPI: Suppress missing MCFG message
@ 2020-09-08 21:03 Jeremy Linton
2020-09-09 0:59 ` Hanjun Guo
2020-09-09 14:42 ` Bjorn Helgaas
0 siblings, 2 replies; 3+ messages in thread
From: Jeremy Linton @ 2020-09-08 21:03 UTC (permalink / raw)
To: linux-acpi
Cc: tn, bhelgaas, lorenzo.pieralisi, steven.price, rjw, lenb,
sudeep.holla, guohanjun, linux-pci, linux-arm-kernel,
Jeremy Linton
MCFG is an optional ACPI table. Given there are machines
without PCI(e) (or it is hidden) we have been receiving
queries/complaints about what this message means given
its being presented as an error.
Lets reduce the severity, the ACPI table list printed at
boot will continue to provide another way to detect when
the table is missing.
Signed-off-by: Jeremy Linton <jeremy.linton@arm.com>
---
drivers/acpi/pci_mcfg.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/acpi/pci_mcfg.c b/drivers/acpi/pci_mcfg.c
index 54b36b7ad47d..c8ef3bb5aa00 100644
--- a/drivers/acpi/pci_mcfg.c
+++ b/drivers/acpi/pci_mcfg.c
@@ -280,5 +280,5 @@ void __init pci_mmcfg_late_init(void)
{
int err = acpi_table_parse(ACPI_SIG_MCFG, pci_mcfg_parse);
if (err)
- pr_err("Failed to parse MCFG (%d)\n", err);
+ pr_debug("Failed to parse MCFG (%d)\n", err);
}
--
2.25.4
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH v2] PCI/ACPI: Suppress missing MCFG message
2020-09-08 21:03 [PATCH v2] PCI/ACPI: Suppress missing MCFG message Jeremy Linton
@ 2020-09-09 0:59 ` Hanjun Guo
2020-09-09 14:42 ` Bjorn Helgaas
1 sibling, 0 replies; 3+ messages in thread
From: Hanjun Guo @ 2020-09-09 0:59 UTC (permalink / raw)
To: Jeremy Linton, linux-acpi
Cc: tn, bhelgaas, lorenzo.pieralisi, steven.price, rjw, lenb,
sudeep.holla, linux-pci, linux-arm-kernel
On 2020/9/9 5:03, Jeremy Linton wrote:
> MCFG is an optional ACPI table. Given there are machines
> without PCI(e) (or it is hidden) we have been receiving
> queries/complaints about what this message means given
> its being presented as an error.
>
> Lets reduce the severity, the ACPI table list printed at
> boot will continue to provide another way to detect when
> the table is missing.
>
> Signed-off-by: Jeremy Linton <jeremy.linton@arm.com>
> ---
> drivers/acpi/pci_mcfg.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/acpi/pci_mcfg.c b/drivers/acpi/pci_mcfg.c
> index 54b36b7ad47d..c8ef3bb5aa00 100644
> --- a/drivers/acpi/pci_mcfg.c
> +++ b/drivers/acpi/pci_mcfg.c
> @@ -280,5 +280,5 @@ void __init pci_mmcfg_late_init(void)
> {
> int err = acpi_table_parse(ACPI_SIG_MCFG, pci_mcfg_parse);
> if (err)
> - pr_err("Failed to parse MCFG (%d)\n", err);
> + pr_debug("Failed to parse MCFG (%d)\n", err);
> }
>
Reviewed-by: Hanjun Guo <guohanjun@huawei.com>
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH v2] PCI/ACPI: Suppress missing MCFG message
2020-09-08 21:03 [PATCH v2] PCI/ACPI: Suppress missing MCFG message Jeremy Linton
2020-09-09 0:59 ` Hanjun Guo
@ 2020-09-09 14:42 ` Bjorn Helgaas
1 sibling, 0 replies; 3+ messages in thread
From: Bjorn Helgaas @ 2020-09-09 14:42 UTC (permalink / raw)
To: Jeremy Linton
Cc: linux-acpi, tn, bhelgaas, lorenzo.pieralisi, steven.price, rjw,
lenb, sudeep.holla, guohanjun, linux-pci, linux-arm-kernel
On Tue, Sep 08, 2020 at 04:03:59PM -0500, Jeremy Linton wrote:
> MCFG is an optional ACPI table. Given there are machines
> without PCI(e) (or it is hidden) we have been receiving
> queries/complaints about what this message means given
> its being presented as an error.
>
> Lets reduce the severity, the ACPI table list printed at
> boot will continue to provide another way to detect when
> the table is missing.
>
> Signed-off-by: Jeremy Linton <jeremy.linton@arm.com>
Applied to pci/enumeration with Hanjun's reviewed-by, thanks!
> ---
> drivers/acpi/pci_mcfg.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/acpi/pci_mcfg.c b/drivers/acpi/pci_mcfg.c
> index 54b36b7ad47d..c8ef3bb5aa00 100644
> --- a/drivers/acpi/pci_mcfg.c
> +++ b/drivers/acpi/pci_mcfg.c
> @@ -280,5 +280,5 @@ void __init pci_mmcfg_late_init(void)
> {
> int err = acpi_table_parse(ACPI_SIG_MCFG, pci_mcfg_parse);
> if (err)
> - pr_err("Failed to parse MCFG (%d)\n", err);
> + pr_debug("Failed to parse MCFG (%d)\n", err);
> }
> --
> 2.25.4
>
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2020-09-09 16:05 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-09-08 21:03 [PATCH v2] PCI/ACPI: Suppress missing MCFG message Jeremy Linton
2020-09-09 0:59 ` Hanjun Guo
2020-09-09 14:42 ` Bjorn Helgaas
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).