From: Bjorn Helgaas <helgaas@kernel.org>
To: Niklas Schnelle <schnelle@linux.ibm.com>
Cc: Bjorn Helgaas <bhelgaas@google.com>,
linux-pci@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-s390@vger.kernel.org, Pierre Morel <pmorel@linux.ibm.com>,
Peter Oberparleiter <oberpar@linux.ibm.com>,
Viktor Mihajlovski <mihajlov@linux.ibm.com>
Subject: Re: [RFC 1/1] s390/pci: expose UID checking state in sysfs
Date: Tue, 12 Jan 2021 15:50:04 -0600 [thread overview]
Message-ID: <20210112215004.GA1855697@bjorn-Precision-5520> (raw)
In-Reply-To: <20210111093857.24070-2-schnelle@linux.ibm.com>
On Mon, Jan 11, 2021 at 10:38:57AM +0100, Niklas Schnelle wrote:
> We use the UID of a zPCI adapter, or the UID of the function zero if
> there are multiple functions in an adapter, as PCI domain if and only if
> UID Checking is turned on.
> Otherwise we automatically generate domains as devices appear.
>
> The state of UID Checking is thus essential to know if the PCI domain
> will be stable, yet currently there is no way to access this information
> from userspace.
> So let's solve this by showing the state of UID checking as a sysfs
> attribute in /sys/bus/pci/uid_checking
Cosmetic: can't tell if the above is two paragraphs separated by blank
lines or four separated by either blank lines or short last lines.
Please separate or reflow to avoid the ambiguity.
I don't have any input on the s390 issues, and I assume this will go
via the s390 tree.
> Signed-off-by: Niklas Schnelle <schnelle@linux.ibm.com>
> ---
> Documentation/ABI/testing/sysfs-bus-pci | 11 ++++++++
> arch/s390/include/asm/pci.h | 3 +++
> arch/s390/pci/pci.c | 4 +++
> arch/s390/pci/pci_sysfs.c | 34 +++++++++++++++++++++++++
> 4 files changed, 52 insertions(+)
>
> diff --git a/Documentation/ABI/testing/sysfs-bus-pci b/Documentation/ABI/testing/sysfs-bus-pci
> index 25c9c39770c6..a174aac0ebb0 100644
> --- a/Documentation/ABI/testing/sysfs-bus-pci
> +++ b/Documentation/ABI/testing/sysfs-bus-pci
> @@ -375,3 +375,14 @@ Description:
> The value comes from the PCI kernel device state and can be one
> of: "unknown", "error", "D0", D1", "D2", "D3hot", "D3cold".
> The file is read only.
> +What: /sys/bus/pci/zpci/uid_checking
> +Date: December 2020
> +Contact: Niklas Schnelle <schnelle@linux.ibm.com>
> +Description:
> + This attribute exposes the global state of UID Checking on
> + an s390 Linux system. If UID Checking is on this file
> + contains '1' otherwise '0'. If UID Checking is on the UID of
> + a zPCI device, or the UID of function zero for a multi-function
> + device will be used as its PCI Domain number. If UID Checking
> + is off PCI Domain numbers are generated automatically and
> + are not stable across reboots.
> diff --git a/arch/s390/include/asm/pci.h b/arch/s390/include/asm/pci.h
> index 212628932ddc..3cfa6cc701ba 100644
> --- a/arch/s390/include/asm/pci.h
> +++ b/arch/s390/include/asm/pci.h
> @@ -285,6 +285,9 @@ void zpci_debug_exit_device(struct zpci_dev *);
> /* Error reporting */
> int zpci_report_error(struct pci_dev *, struct zpci_report_error_header *);
>
> +/* Sysfs Entries */
> +int zpci_sysfs_init(void);
> +
> #ifdef CONFIG_NUMA
>
> /* Returns the node based on PCI bus */
> diff --git a/arch/s390/pci/pci.c b/arch/s390/pci/pci.c
> index 41df8fcfddde..c16c93e5f9af 100644
> --- a/arch/s390/pci/pci.c
> +++ b/arch/s390/pci/pci.c
> @@ -881,6 +881,10 @@ static int __init pci_base_init(void)
> if (rc)
> goto out_find;
>
> + rc = zpci_sysfs_init();
> + if (rc)
> + goto out_find;
> +
> s390_pci_initialized = 1;
> return 0;
>
> diff --git a/arch/s390/pci/pci_sysfs.c b/arch/s390/pci/pci_sysfs.c
> index 5c028bee91b9..d00690f73539 100644
> --- a/arch/s390/pci/pci_sysfs.c
> +++ b/arch/s390/pci/pci_sysfs.c
> @@ -172,3 +172,37 @@ const struct attribute_group *zpci_attr_groups[] = {
> &pfip_attr_group,
> NULL,
> };
> +
> +/* Global zPCI attributes */
> +static ssize_t uid_checking_show(struct kobject *kobj,
> + struct kobj_attribute *attr, char *buf)
> +{
> + return sprintf(buf, "%i\n", zpci_unique_uid);
> +}
> +
> +static struct kobj_attribute sys_zpci_uid_checking_attr =
> + __ATTR(uid_checking, 0444, uid_checking_show, NULL);
Use DEVICE_ATTR_RO instead of __ATTR.
> +static struct kset *zpci_global_kset;
> +
> +static struct attribute *zpci_attrs_global[] = {
> + &sys_zpci_uid_checking_attr.attr,
> + NULL,
> +};
> +
> +static struct attribute_group zpci_attr_group_global = {
> + .attrs = zpci_attrs_global,
> +};
> +
> +int __init zpci_sysfs_init(void)
> +{
> + struct kset *pci_bus_kset;
> +
> + pci_bus_kset = bus_get_kset(&pci_bus_type);
> +
> + zpci_global_kset = kset_create_and_add("zpci", NULL, &pci_bus_kset->kobj);
> + if (!zpci_global_kset)
> + return -ENOMEM;
> +
> + return sysfs_create_group(&zpci_global_kset->kobj, &zpci_attr_group_global);
> +}
> --
> 2.17.1
>
next prev parent reply other threads:[~2021-01-12 21:51 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-01-11 9:38 [RFC 0/1] PCI: s390 global attribute "UID Checking" Niklas Schnelle
2021-01-11 9:38 ` [RFC 1/1] s390/pci: expose UID checking state in sysfs Niklas Schnelle
2021-01-12 21:50 ` Bjorn Helgaas [this message]
2021-01-13 7:47 ` Niklas Schnelle
2021-01-13 18:55 ` Bjorn Helgaas
2021-01-14 13:20 ` Niklas Schnelle
2021-01-14 13:44 ` Christian Brauner
2021-01-14 13:58 ` Greg Kroah-Hartman
2021-01-14 15:06 ` Niklas Schnelle
2021-01-14 15:17 ` Greg Kroah-Hartman
2021-01-14 15:51 ` Niklas Schnelle
2021-01-14 16:14 ` Greg Kroah-Hartman
2021-01-15 11:20 ` Niklas Schnelle
2021-01-15 12:02 ` Greg Kroah-Hartman
2021-01-15 15:29 ` Bjorn Helgaas
2021-01-15 16:15 ` Niklas Schnelle
2021-01-21 15:31 ` Niklas Schnelle
2021-01-21 15:54 ` Bjorn Helgaas
2021-01-21 16:11 ` Greg Kroah-Hartman
2021-01-21 17:04 ` Niklas Schnelle
2021-01-21 17:28 ` Greg Kroah-Hartman
2021-01-21 17:43 ` Niklas Schnelle
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210112215004.GA1855697@bjorn-Precision-5520 \
--to=helgaas@kernel.org \
--cc=bhelgaas@google.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pci@vger.kernel.org \
--cc=linux-s390@vger.kernel.org \
--cc=mihajlov@linux.ibm.com \
--cc=oberpar@linux.ibm.com \
--cc=pmorel@linux.ibm.com \
--cc=schnelle@linux.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).