From: Stephen Boyd <sboyd@kernel.org>
To: "Andy Gross" <agross@kernel.org>,
"Bjorn Andersson" <bjorn.andersson@linaro.org>,
"Bjorn Helgaas" <bhelgaas@google.com>,
"Dmitry Baryshkov" <dmitry.baryshkov@linaro.org>,
"Johan Hovold" <johan+linaro@kernel.org>,
"Krzysztof Wilczyński" <kw@linux.com>,
"Lorenzo Pieralisi" <lorenzo.pieralisi@arm.com>,
"Manivannan Sadhasivam" <manivannan.sadhasivam@linaro.org>,
"Michael Turquette" <mturquette@baylibre.com>,
"Rob Herring" <robh@kernel.org>,
"Stanimir Varbanov" <svarbanov@mm-sol.com>
Cc: Vinod Koul <vkoul@kernel.org>,
linux-arm-msm@vger.kernel.org, linux-pci@vger.kernel.org,
linux-clk@vger.kernel.org
Subject: Re: [PATCH v6 3/5] clk: qcom: gcc-sm8450: use new clk_regmap_pipe_src_ops for PCIe pipe clocks
Date: Wed, 18 May 2022 11:31:17 -0700 [thread overview]
Message-ID: <20220518183119.9AAF9C385A9@smtp.kernel.org> (raw)
In-Reply-To: <783bbf39-779d-3ac8-a965-9d98ec1993ec@linaro.org>
- bouncing Prasad
Quoting Dmitry Baryshkov (2022-05-18 11:26:16)
> On 18/05/2022 20:59, Stephen Boyd wrote:
> > Quoting Dmitry Baryshkov (2022-05-13 10:53:37)
> >> diff --git a/drivers/clk/qcom/gcc-sm8450.c b/drivers/clk/qcom/gcc-sm8450.c
> >> index 593a195467ff..a140a89b73b4 100644
> >> --- a/drivers/clk/qcom/gcc-sm8450.c
> >> +++ b/drivers/clk/qcom/gcc-sm8450.c
> >> @@ -239,17 +218,21 @@ static const struct clk_parent_data gcc_parent_data_11[] = {
> >> { .fw_name = "bi_tcxo" },
> >> };
> >>
> >> -static struct clk_regmap_mux gcc_pcie_0_pipe_clk_src = {
> >> +static struct clk_regmap_phy_mux gcc_pcie_0_pipe_clk_src = {
> >> .reg = 0x7b060,
> >> .shift = 0,
> >> .width = 2,
> >> - .parent_map = gcc_parent_map_4,
> >> + .phy_src_val = 0, /* pipe_clk */
> >
> > Make a define? PCIE0_PIPE_CLK_SRC_VAL and drop the comment?
>
> This value can change between the muxes. Thus I'd prefer not to do this.
> Compare it with the parent_maps, where we do not use defines for the
> 'val' part.
>
We don't have defines for the parent maps because they have defines for
the other side.
next prev parent reply other threads:[~2022-05-18 18:31 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-05-13 17:53 [PATCH v6 0/5] PCI: qcom: Rework pipe_clk/pipe_clk_src handling Dmitry Baryshkov
2022-05-13 17:53 ` [PATCH v6 1/5] PCI: qcom: Remove unnecessary pipe_clk handling Dmitry Baryshkov
2022-05-18 7:42 ` Johan Hovold
2022-05-13 17:53 ` [PATCH v6 2/5] clk: qcom: regmap: add PHY clock source implementation Dmitry Baryshkov
2022-05-18 7:34 ` Johan Hovold
2022-05-18 7:48 ` Johan Hovold
2022-05-19 11:44 ` Dmitry Baryshkov
2022-05-18 17:58 ` Stephen Boyd
2022-05-18 19:19 ` Dmitry Baryshkov
2022-05-19 11:16 ` Dmitry Baryshkov
2022-05-20 22:49 ` Stephen Boyd
2022-05-21 0:38 ` Dmitry Baryshkov
2022-05-13 17:53 ` [PATCH v6 3/5] clk: qcom: gcc-sm8450: use new clk_regmap_pipe_src_ops for PCIe pipe clocks Dmitry Baryshkov
2022-05-18 7:36 ` Johan Hovold
2022-05-18 17:59 ` Stephen Boyd
2022-05-18 18:26 ` Dmitry Baryshkov
2022-05-18 18:31 ` Stephen Boyd [this message]
2022-05-13 17:53 ` [PATCH v6 4/5] clk: qcom: gcc-sc7280: " Dmitry Baryshkov
2022-05-18 7:37 ` Johan Hovold
2022-05-13 17:53 ` [PATCH v6 5/5] PCI: qcom: Drop manual pipe_clk_src handling Dmitry Baryshkov
2022-05-18 7:41 ` Johan Hovold
2022-05-18 7:53 ` [PATCH v6 0/5] PCI: qcom: Rework pipe_clk/pipe_clk_src handling Johan Hovold
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220518183119.9AAF9C385A9@smtp.kernel.org \
--to=sboyd@kernel.org \
--cc=agross@kernel.org \
--cc=bhelgaas@google.com \
--cc=bjorn.andersson@linaro.org \
--cc=dmitry.baryshkov@linaro.org \
--cc=johan+linaro@kernel.org \
--cc=kw@linux.com \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-clk@vger.kernel.org \
--cc=linux-pci@vger.kernel.org \
--cc=lorenzo.pieralisi@arm.com \
--cc=manivannan.sadhasivam@linaro.org \
--cc=mturquette@baylibre.com \
--cc=robh@kernel.org \
--cc=svarbanov@mm-sol.com \
--cc=vkoul@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).