From: Dmitry Baryshkov <dmitry.baryshkov@linaro.org>
To: "Stephen Boyd" <sboyd@kernel.org>,
"Andy Gross" <agross@kernel.org>,
"Bjorn Andersson" <bjorn.andersson@linaro.org>,
"Bjorn Helgaas" <bhelgaas@google.com>,
"Johan Hovold" <johan+linaro@kernel.org>,
"Krzysztof Wilczyński" <kw@linux.com>,
"Lorenzo Pieralisi" <lorenzo.pieralisi@arm.com>,
"Manivannan Sadhasivam" <manivannan.sadhasivam@linaro.org>,
"Michael Turquette" <mturquette@baylibre.com>,
"Rob Herring" <robh@kernel.org>,
"Stanimir Varbanov" <svarbanov@mm-sol.com>
Cc: Prasad Malisetty <quic_pmaliset@quicinc.com>,
Vinod Koul <vkoul@kernel.org>,
linux-arm-msm@vger.kernel.org, linux-pci@vger.kernel.org,
linux-clk@vger.kernel.org
Subject: Re: [PATCH v6 2/5] clk: qcom: regmap: add PHY clock source implementation
Date: Sat, 21 May 2022 03:38:12 +0300 [thread overview]
Message-ID: <7893eb9d-a4ff-ae08-2996-f5a5adf6f53d@linaro.org> (raw)
In-Reply-To: <20220520224916.56AA5C385A9@smtp.kernel.org>
On 21/05/2022 01:49, Stephen Boyd wrote:
> Quoting Dmitry Baryshkov (2022-05-19 04:16:19)
>> On 18/05/2022 20:58, Stephen Boyd wrote:
>>> Quoting Dmitry Baryshkov (2022-05-13 10:53:36)
>>>> diff --git a/drivers/clk/qcom/clk-regmap-phy-mux.c b/drivers/clk/qcom/clk-regmap-phy-mux.c
>>>> new file mode 100644
>>>> index 000000000000..d7a45f7fa1aa
>>>> --- /dev/null
>>>> +++ b/drivers/clk/qcom/clk-regmap-phy-mux.c
> [...]
>>>> +
>>>> +#include "clk-regmap-phy-mux.h"
>>>
>>> Same for clk-regmap.h, avoid include hell.
>>
>> I couldn't catch this comment. I think we need clk-regmap.h in
>> clk-regmap-phy-mux.h as clk_regmap is a part of defined structure.
>>
>
> Don't rely on implicit includes. It makes changing header files error
> prone. Also, please trim replies.
Ack. Will change this in v8.
--
With best wishes
Dmitry
next prev parent reply other threads:[~2022-05-21 0:38 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-05-13 17:53 [PATCH v6 0/5] PCI: qcom: Rework pipe_clk/pipe_clk_src handling Dmitry Baryshkov
2022-05-13 17:53 ` [PATCH v6 1/5] PCI: qcom: Remove unnecessary pipe_clk handling Dmitry Baryshkov
2022-05-18 7:42 ` Johan Hovold
2022-05-13 17:53 ` [PATCH v6 2/5] clk: qcom: regmap: add PHY clock source implementation Dmitry Baryshkov
2022-05-18 7:34 ` Johan Hovold
2022-05-18 7:48 ` Johan Hovold
2022-05-19 11:44 ` Dmitry Baryshkov
2022-05-18 17:58 ` Stephen Boyd
2022-05-18 19:19 ` Dmitry Baryshkov
2022-05-19 11:16 ` Dmitry Baryshkov
2022-05-20 22:49 ` Stephen Boyd
2022-05-21 0:38 ` Dmitry Baryshkov [this message]
2022-05-13 17:53 ` [PATCH v6 3/5] clk: qcom: gcc-sm8450: use new clk_regmap_pipe_src_ops for PCIe pipe clocks Dmitry Baryshkov
2022-05-18 7:36 ` Johan Hovold
2022-05-18 17:59 ` Stephen Boyd
2022-05-18 18:26 ` Dmitry Baryshkov
2022-05-18 18:31 ` Stephen Boyd
2022-05-13 17:53 ` [PATCH v6 4/5] clk: qcom: gcc-sc7280: " Dmitry Baryshkov
2022-05-18 7:37 ` Johan Hovold
2022-05-13 17:53 ` [PATCH v6 5/5] PCI: qcom: Drop manual pipe_clk_src handling Dmitry Baryshkov
2022-05-18 7:41 ` Johan Hovold
2022-05-18 7:53 ` [PATCH v6 0/5] PCI: qcom: Rework pipe_clk/pipe_clk_src handling Johan Hovold
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=7893eb9d-a4ff-ae08-2996-f5a5adf6f53d@linaro.org \
--to=dmitry.baryshkov@linaro.org \
--cc=agross@kernel.org \
--cc=bhelgaas@google.com \
--cc=bjorn.andersson@linaro.org \
--cc=johan+linaro@kernel.org \
--cc=kw@linux.com \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-clk@vger.kernel.org \
--cc=linux-pci@vger.kernel.org \
--cc=lorenzo.pieralisi@arm.com \
--cc=manivannan.sadhasivam@linaro.org \
--cc=mturquette@baylibre.com \
--cc=quic_pmaliset@quicinc.com \
--cc=robh@kernel.org \
--cc=sboyd@kernel.org \
--cc=svarbanov@mm-sol.com \
--cc=vkoul@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).