* [PATCH] NTB: EPF: Mark pci_read and pci_write as static
@ 2022-07-08 2:00 Souptick Joarder
2022-07-12 19:49 ` Bjorn Helgaas
0 siblings, 1 reply; 3+ messages in thread
From: Souptick Joarder @ 2022-07-08 2:00 UTC (permalink / raw)
To: kishon, lpieralisi, kw, bhelgaas, jdmason, Frank.Li
Cc: linux-pci, linux-kernel, Souptick Joarder (HPE), kernel test robot
From: "Souptick Joarder (HPE)" <jrdr.linux@gmail.com>
kernel test robot throws below warning ->
drivers/pci/endpoint/functions/pci-epf-vntb.c:975:5: warning:
no previous prototype for 'pci_read' [-Wmissing-prototypes]
drivers/pci/endpoint/functions/pci-epf-vntb.c:984:5: warning:
no previous prototype for 'pci_write' [-Wmissing-prototypes]
mark them as static.
Reported-by: kernel test robot <lkp@intel.com>
Signed-off-by: Souptick Joarder (HPE) <jrdr.linux@gmail.com>
---
drivers/pci/endpoint/functions/pci-epf-vntb.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/pci/endpoint/functions/pci-epf-vntb.c b/drivers/pci/endpoint/functions/pci-epf-vntb.c
index ebf7e243eefa..111568089d45 100644
--- a/drivers/pci/endpoint/functions/pci-epf-vntb.c
+++ b/drivers/pci/endpoint/functions/pci-epf-vntb.c
@@ -972,7 +972,7 @@ uint32_t pci_space[] = {
0, //Max Lat, Min Gnt, interrupt pin, interrupt line
};
-int pci_read(struct pci_bus *bus, unsigned int devfn, int where, int size, u32 *val)
+static int pci_read(struct pci_bus *bus, unsigned int devfn, int where, int size, u32 *val)
{
if (devfn == 0) {
memcpy(val, ((uint8_t *)pci_space) + where, size);
@@ -981,7 +981,7 @@ int pci_read(struct pci_bus *bus, unsigned int devfn, int where, int size, u32 *
return -1;
}
-int pci_write(struct pci_bus *bus, unsigned int devfn, int where, int size, u32 val)
+static int pci_write(struct pci_bus *bus, unsigned int devfn, int where, int size, u32 val)
{
return 0;
}
--
2.25.1
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] NTB: EPF: Mark pci_read and pci_write as static
2022-07-08 2:00 [PATCH] NTB: EPF: Mark pci_read and pci_write as static Souptick Joarder
@ 2022-07-12 19:49 ` Bjorn Helgaas
2022-08-12 14:14 ` Jon Mason
0 siblings, 1 reply; 3+ messages in thread
From: Bjorn Helgaas @ 2022-07-12 19:49 UTC (permalink / raw)
To: Souptick Joarder
Cc: kishon, lpieralisi, kw, bhelgaas, jdmason, Frank.Li, linux-pci,
linux-kernel, kernel test robot
On Fri, Jul 08, 2022 at 07:30:35AM +0530, Souptick Joarder wrote:
> From: "Souptick Joarder (HPE)" <jrdr.linux@gmail.com>
>
> kernel test robot throws below warning ->
>
> drivers/pci/endpoint/functions/pci-epf-vntb.c:975:5: warning:
> no previous prototype for 'pci_read' [-Wmissing-prototypes]
> drivers/pci/endpoint/functions/pci-epf-vntb.c:984:5: warning:
> no previous prototype for 'pci_write' [-Wmissing-prototypes]
>
> mark them as static.
>
> Reported-by: kernel test robot <lkp@intel.com>
> Signed-off-by: Souptick Joarder (HPE) <jrdr.linux@gmail.com>
IIUC this series is going via Jon. Let me know if I need to do
anything.
> ---
> drivers/pci/endpoint/functions/pci-epf-vntb.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/pci/endpoint/functions/pci-epf-vntb.c b/drivers/pci/endpoint/functions/pci-epf-vntb.c
> index ebf7e243eefa..111568089d45 100644
> --- a/drivers/pci/endpoint/functions/pci-epf-vntb.c
> +++ b/drivers/pci/endpoint/functions/pci-epf-vntb.c
> @@ -972,7 +972,7 @@ uint32_t pci_space[] = {
> 0, //Max Lat, Min Gnt, interrupt pin, interrupt line
> };
>
> -int pci_read(struct pci_bus *bus, unsigned int devfn, int where, int size, u32 *val)
> +static int pci_read(struct pci_bus *bus, unsigned int devfn, int where, int size, u32 *val)
> {
> if (devfn == 0) {
> memcpy(val, ((uint8_t *)pci_space) + where, size);
> @@ -981,7 +981,7 @@ int pci_read(struct pci_bus *bus, unsigned int devfn, int where, int size, u32 *
> return -1;
> }
>
> -int pci_write(struct pci_bus *bus, unsigned int devfn, int where, int size, u32 val)
> +static int pci_write(struct pci_bus *bus, unsigned int devfn, int where, int size, u32 val)
> {
> return 0;
> }
> --
> 2.25.1
>
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] NTB: EPF: Mark pci_read and pci_write as static
2022-07-12 19:49 ` Bjorn Helgaas
@ 2022-08-12 14:14 ` Jon Mason
0 siblings, 0 replies; 3+ messages in thread
From: Jon Mason @ 2022-08-12 14:14 UTC (permalink / raw)
To: Bjorn Helgaas
Cc: Souptick Joarder, kishon, lpieralisi, kw, bhelgaas, Frank.Li,
linux-pci, linux-kernel, kernel test robot
On Tue, Jul 12, 2022 at 02:49:36PM -0500, Bjorn Helgaas wrote:
> On Fri, Jul 08, 2022 at 07:30:35AM +0530, Souptick Joarder wrote:
> > From: "Souptick Joarder (HPE)" <jrdr.linux@gmail.com>
> >
> > kernel test robot throws below warning ->
> >
> > drivers/pci/endpoint/functions/pci-epf-vntb.c:975:5: warning:
> > no previous prototype for 'pci_read' [-Wmissing-prototypes]
> > drivers/pci/endpoint/functions/pci-epf-vntb.c:984:5: warning:
> > no previous prototype for 'pci_write' [-Wmissing-prototypes]
> >
> > mark them as static.
> >
> > Reported-by: kernel test robot <lkp@intel.com>
> > Signed-off-by: Souptick Joarder (HPE) <jrdr.linux@gmail.com>
>
> IIUC this series is going via Jon. Let me know if I need to do
> anything.
Sorry for the extremely long delay in response. This series is in my
ntb branch and will be in my pull request for v5.20 which should be
going out later today.
Thanks,
Jon
>
> > ---
> > drivers/pci/endpoint/functions/pci-epf-vntb.c | 4 ++--
> > 1 file changed, 2 insertions(+), 2 deletions(-)
> >
> > diff --git a/drivers/pci/endpoint/functions/pci-epf-vntb.c b/drivers/pci/endpoint/functions/pci-epf-vntb.c
> > index ebf7e243eefa..111568089d45 100644
> > --- a/drivers/pci/endpoint/functions/pci-epf-vntb.c
> > +++ b/drivers/pci/endpoint/functions/pci-epf-vntb.c
> > @@ -972,7 +972,7 @@ uint32_t pci_space[] = {
> > 0, //Max Lat, Min Gnt, interrupt pin, interrupt line
> > };
> >
> > -int pci_read(struct pci_bus *bus, unsigned int devfn, int where, int size, u32 *val)
> > +static int pci_read(struct pci_bus *bus, unsigned int devfn, int where, int size, u32 *val)
> > {
> > if (devfn == 0) {
> > memcpy(val, ((uint8_t *)pci_space) + where, size);
> > @@ -981,7 +981,7 @@ int pci_read(struct pci_bus *bus, unsigned int devfn, int where, int size, u32 *
> > return -1;
> > }
> >
> > -int pci_write(struct pci_bus *bus, unsigned int devfn, int where, int size, u32 val)
> > +static int pci_write(struct pci_bus *bus, unsigned int devfn, int where, int size, u32 val)
> > {
> > return 0;
> > }
> > --
> > 2.25.1
> >
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2022-08-12 14:14 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-07-08 2:00 [PATCH] NTB: EPF: Mark pci_read and pci_write as static Souptick Joarder
2022-07-12 19:49 ` Bjorn Helgaas
2022-08-12 14:14 ` Jon Mason
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).