From: Manivannan Sadhasivam <manivannan.sadhasivam@linaro.org>
To: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
Cc: lpieralisi@kernel.org, robh@kernel.org, andersson@kernel.org,
kw@linux.com, bhelgaas@google.com, linux-pci@vger.kernel.org,
linux-arm-msm@vger.kernel.org, linux-kernel@vger.kernel.org,
konrad.dybcio@somainline.org, robh+dt@kernel.org,
krzysztof.kozlowski+dt@linaro.org, devicetree@vger.kernel.org,
dmitry.baryshkov@linaro.org
Subject: Re: [PATCH 09/11] dt-bindings: PCI: qcom-ep: Define clocks per platform
Date: Tue, 30 Aug 2022 17:26:42 +0530 [thread overview]
Message-ID: <20220830115642.GE135982@thinkpad> (raw)
In-Reply-To: <b188b3fe-cc35-f902-b316-0c1632893e9d@linaro.org>
On Sun, Aug 28, 2022 at 06:20:21PM +0300, Krzysztof Kozlowski wrote:
> On 26/08/2022 21:19, Manivannan Sadhasivam wrote:
> > In preparation of adding the bindings for future SoCs, let's define the
> > clocks per platform.
> >
> > Signed-off-by: Manivannan Sadhasivam <manivannan.sadhasivam@linaro.org>
> > ---
> > .../devicetree/bindings/pci/qcom,pcie-ep.yaml | 46 +++++++++++--------
> > 1 file changed, 27 insertions(+), 19 deletions(-)
> >
> > diff --git a/Documentation/devicetree/bindings/pci/qcom,pcie-ep.yaml b/Documentation/devicetree/bindings/pci/qcom,pcie-ep.yaml
> > index b728ede3f09f..83a2cfc63bc1 100644
> > --- a/Documentation/devicetree/bindings/pci/qcom,pcie-ep.yaml
> > +++ b/Documentation/devicetree/bindings/pci/qcom,pcie-ep.yaml
> > @@ -9,9 +9,6 @@ title: Qualcomm PCIe Endpoint Controller binding
> > maintainers:
> > - Manivannan Sadhasivam <manivannan.sadhasivam@linaro.org>
> >
> > -allOf:
> > - - $ref: "pci-ep.yaml#"
> > -
> > properties:
> > compatible:
> > const: qcom,sdx55-pcie-ep
> > @@ -35,24 +32,12 @@ properties:
> > - const: mmio
> >
> > clocks:
> > - items:
> > - - description: PCIe Auxiliary clock
> > - - description: PCIe CFG AHB clock
> > - - description: PCIe Master AXI clock
> > - - description: PCIe Slave AXI clock
> > - - description: PCIe Slave Q2A AXI clock
> > - - description: PCIe Sleep clock
> > - - description: PCIe Reference clock
> > + minItems: 7
> > + maxItems: 7
> >
> > clock-names:
> > - items:
> > - - const: aux
> > - - const: cfg
> > - - const: bus_master
> > - - const: bus_slave
> > - - const: slave_q2a
> > - - const: sleep
> > - - const: ref
> > + minItems: 7
> > + maxItems: 7
> >
> > qcom,perst-regs:
> > description: Reference to a syscon representing TCSR followed by the two
> > @@ -112,6 +97,29 @@ required:
> > - reset-names
> > - power-domains
> >
> > +allOf:
> > + - $ref: "pci-ep.yaml#"
> > + - if:
> > + properties:
> > + compatible:
> > + contains:
> > + enum:
> > + - qcom,sdx55-pcie-ep
> > + then:
> > + properties:
> > + clocks:
> > + minItems: 7
> > + maxItems: 7
>
> One more thing - the previous way of describing items is more readable
> instead of names followed by a comment, so I propose to keep it. This
> applies also to patch 10.
>
Okay.
Thanks,
Mani
> Best regards,
> Krzysztof
--
மணிவண்ணன் சதாசிவம்
next prev parent reply other threads:[~2022-08-30 11:57 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-08-26 18:19 [PATCH 00/11] Improvements to the Qcom PCIe Endpoint driver Manivannan Sadhasivam
2022-08-26 18:19 ` [PATCH 01/11] PCI: qcom-ep: Add kernel-doc for qcom_pcie_ep structure Manivannan Sadhasivam
2022-08-26 18:19 ` [PATCH 02/11] PCI: qcom-ep: Do not use hardcoded clks in driver Manivannan Sadhasivam
2022-08-26 18:19 ` [PATCH 03/11] PCI: qcom-ep: Make use of the cached dev pointer Manivannan Sadhasivam
2022-08-26 18:19 ` [PATCH 04/11] PCI: qcom-ep: Add eDMA support Manivannan Sadhasivam
2022-08-26 18:19 ` [PATCH 05/11] PCI: qcom-ep: Disable IRQs during driver remove Manivannan Sadhasivam
2022-08-26 18:19 ` [PATCH 06/11] PCI: qcom-ep: Add debugfs support for expose link transition counts Manivannan Sadhasivam
2022-08-26 18:19 ` [PATCH 07/11] dt-bindings: PCI: qcom-ep: Make PERST separation optional Manivannan Sadhasivam
2022-08-28 15:12 ` Krzysztof Kozlowski
2022-08-26 18:19 ` [PATCH 08/11] " Manivannan Sadhasivam
2022-08-26 18:19 ` [PATCH 09/11] dt-bindings: PCI: qcom-ep: Define clocks per platform Manivannan Sadhasivam
2022-08-28 15:14 ` Krzysztof Kozlowski
2022-08-28 15:20 ` Krzysztof Kozlowski
2022-08-30 11:56 ` Manivannan Sadhasivam [this message]
2022-08-26 18:19 ` [PATCH 10/11] dt-bindings: PCI: qcom-ep: Add support for SM8450 SoC Manivannan Sadhasivam
2022-08-28 14:21 ` Rob Herring
2022-08-28 15:17 ` Krzysztof Kozlowski
2022-08-30 11:57 ` Manivannan Sadhasivam
2022-08-26 18:19 ` [PATCH 11/11] " Manivannan Sadhasivam
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220830115642.GE135982@thinkpad \
--to=manivannan.sadhasivam@linaro.org \
--cc=andersson@kernel.org \
--cc=bhelgaas@google.com \
--cc=devicetree@vger.kernel.org \
--cc=dmitry.baryshkov@linaro.org \
--cc=konrad.dybcio@somainline.org \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=krzysztof.kozlowski@linaro.org \
--cc=kw@linux.com \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pci@vger.kernel.org \
--cc=lpieralisi@kernel.org \
--cc=robh+dt@kernel.org \
--cc=robh@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).