From: Trevor Jacobs <trevor_jacobs@aol.com>
To: "Michael ." <keltoiboy@gmail.com>, Arvind Sankar <nivedita@alum.mit.edu>
Cc: Ulf Hansson <ulf.hansson@linaro.org>,
Bjorn Helgaas <helgaas@kernel.org>,
Dominik Brodowski <linux@dominikbrodowski.net>,
Linux PCI <linux-pci@vger.kernel.org>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
Kris Cleveland <tridentperfusion@yahoo.com>,
Jeff <bluerocksaddles@willitsonline.com>,
Morgan Klym <moklym@gmail.com>,
Philip Langdale <philipl@overt.org>,
Pierre Ossman <pierre@ossman.eu>,
Maxim Levitsky <maximlevitsky@gmail.com>,
"linux-mmc@vger.kernel.org" <linux-mmc@vger.kernel.org>
Subject: Re: PCI device function not being enumerated [Was: PCMCIA not working on Panasonic Toughbook CF-29]
Date: Tue, 25 Feb 2020 21:12:48 -0600 [thread overview]
Message-ID: <6e9db1f6-60c4-872b-c7c8-96ee411aa3ca@aol.com> (raw)
In-Reply-To: <CAFjuqNg_NW7hcssWmMTtt=ioY143qn76ooT7GRhxEEe9ZVCqeQ@mail.gmail.com>
That's correct, I tested a bunch of the old distros including slackware,
and 2.6.32 is where the problem began.
Also, the Panasonic Toughbook CF-29s effected that we tested are the
later marks, MK4 and MK5 for certain. The MK2 CF-29 worked just fine
because it has different hardware supporting the PCMCIA slots. I have
not tested a MK3 but suspect it would work ok as it also uses the older
hardware.
Thanks for your help guys!
Trevor
On 2/25/20 7:50 PM, Michael . wrote:
> Through our own testing it hasn't worked on any of the regular Linux
> releases (both Deb and RPM varieties, and I think someone tested Arch
> or Slackware as well) after 2.6.32 .
>
> On 26/02/2020, Arvind Sankar <nivedita@alum.mit.edu> wrote:
>> On Tue, Feb 25, 2020 at 04:03:32PM +0100, Ulf Hansson wrote:
>>> On Sat, 22 Feb 2020 at 17:56, Bjorn Helgaas <helgaas@kernel.org> wrote:
>>>> On Tue, Oct 29, 2019 at 12:02:50PM -0500, Bjorn Helgaas wrote:
>>>>> [+cc Ulf, Philip, Pierre, Maxim, linux-mmc; see [1] for beginning of
>>>>> thread, [2] for problem report and the patch Michael tested]
>>>>>
>>>>> On Tue, Oct 29, 2019 at 07:58:27PM +1100, Michael . wrote:
>>>>>> Bjorn and Dominik.
>>>>>> I am happy to let you know the patch did the trick, it compiled
>>>>>> well
>>>>>> on 5.4-rc4 and my friends in the CC list have tested the modified
>>>>>> kernel and confirmed that both slots are now working as they
>>>>>> should.
>>>>>> As a group of dedicated Toughbook users and Linux users please
>>>>>> accept
>>>>>> our thanks your efforts and assistance is greatly appreciated.
>>>>>>
>>>>>> Now that we know this patch works what kernel do you think it will
>>>>>> be
>>>>>> released in? Will it make 5.4 or will it be put into 5.5
>>>>>> development
>>>>>> for further testing?
>>>>> That patch was not intended to be a fix; it was just to test my guess
>>>>> that the quirk might be related.
>>>>>
>>>>> Removing the quirk solved the problem *you're* seeing, but the quirk
>>>>> was added in the first place to solve some other problem, and if we
>>>>> simply remove the quirk, we may reintroduce the original problem.
>>>>>
>>>>> So we have to look at the history and figure out some way to solve
>>>>> both problems. I cc'd some people who might have insight. Here are
>>>>> some commits that look relevant:
>>>>>
>>>>> 5ae70296c85f ("mmc: Disabler for Ricoh MMC controller")
>>>>> 03cd8f7ebe0c ("ricoh_mmc: port from driver to pci quirk")
>>>>>
>>>>>
>>>>> [1]
>>>>> https://lore.kernel.org/r/CAFjuqNi+knSb9WVQOahCVFyxsiqoGgwoM7Z1aqDBebNzp_-jYw@mail.gmail.com/
>>>>> [2] https://lore.kernel.org/r/20191021160952.GA229204@google.com/
>>>> I guess this problem is still unfixed? I hate the fact that we broke
>>>> something that used to work.
>>>>
>>>> Maybe we need some sort of DMI check in ricoh_mmc_fixup_rl5c476() so
>>>> we skip it for Toughbooks? Or maybe we limit the quirk to the
>>>> machines where it was originally needed?
>>> Both options seems reasonable to me. Do you have time to put together a
>>> patch?
>>>
>>> Kind regards
>>> Uffe
>> The quirk is controlled by MMC_RICOH_MMC configuration option. At least
>> as a short-term fix a bit better than patching the kernel, building one
>> with that config option disabled should have the same effect.
>>
>> From the commit messages, the quirk was required to support MMC (as
>> opposed to SD) cards in the SD slot. I would assume this will be an
>> issue with the chip in any machine as the commit indicates that the
>> hardware in the chip detects MMC cards and doesn't expose them through
>> the SDHCI function.
>>
>> It looks like the quirk was only enabled by default in 2015, at least
>> upstream [1], though in Debian it was enabled in May 2010 going by their
>> git repo, maybe in 2.6.32-16.
>>
>> [1] commit ba2f73250e4a ("mmc: Enable Ricoh MMC quirk by default")
>>
next prev parent reply other threads:[~2020-02-26 3:13 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <CAFjuqNh1=B7Ft6v7nzo3BW70EbAvK=Eko_4yqrJ4Z4N3w_Y+Xw@mail.gmail.com>
[not found] ` <CAFjuqNjLJw8J0nU2oo8rDfDUBavHLC7D0=AAwM62tp6=kHHk-A@mail.gmail.com>
[not found] ` <20191015064801.GA104469@owl.dominikbrodowski.net>
[not found] ` <CAFjuqNgxAuf+JTkWqhimDspzPd0+s5yGJro=Zi164uoxu4CmOA@mail.gmail.com>
[not found] ` <CANfzparZ17SMzE1qzzF=Rixu=aYpf1RiKqR4KXXS0S+u7Q3TwQ@mail.gmail.com>
2019-10-20 9:08 ` PCI device function not being enumerated [Was: PCMCIA not working on Panasonic Toughbook CF-29] Dominik Brodowski
2019-10-21 16:09 ` Bjorn Helgaas
2019-10-21 18:17 ` Michael .
2019-10-21 18:47 ` Dominik Brodowski
2019-10-21 18:59 ` Michael .
[not found] ` <CAFjuqNg8_G-B5Owz1NBxa-nw620hXwcn9WkE4sfETVR81MWatA@mail.gmail.com>
[not found] ` <CAFjuqNiToDC9BSJVdahdkPz8Ejb-rM3VRkyoBNUTJr8go=7zrg@mail.gmail.com>
[not found] ` <20191025075536.GA14531@owl.dominikbrodowski.net>
2019-10-25 18:34 ` Michael .
2019-10-29 8:58 ` Michael .
2019-10-29 17:02 ` Bjorn Helgaas
2020-02-22 16:56 ` Bjorn Helgaas
2020-02-22 18:14 ` Michael .
2020-02-25 15:03 ` Ulf Hansson
2020-02-25 19:15 ` Bjorn Helgaas
2020-02-25 23:46 ` bluerocksaddles
2020-02-26 1:13 ` Arvind Sankar
2020-02-26 1:50 ` Michael .
2020-02-26 3:12 ` Trevor Jacobs [this message]
2020-02-26 4:51 ` Arvind Sankar
2020-02-26 5:20 ` Philip Langdale
2020-02-26 6:10 ` Michael .
2020-02-26 19:46 ` bluerocksaddles
2020-07-28 1:50 ` Michael .
2020-08-02 5:58 ` Michael .
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=6e9db1f6-60c4-872b-c7c8-96ee411aa3ca@aol.com \
--to=trevor_jacobs@aol.com \
--cc=bluerocksaddles@willitsonline.com \
--cc=helgaas@kernel.org \
--cc=keltoiboy@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mmc@vger.kernel.org \
--cc=linux-pci@vger.kernel.org \
--cc=linux@dominikbrodowski.net \
--cc=maximlevitsky@gmail.com \
--cc=moklym@gmail.com \
--cc=nivedita@alum.mit.edu \
--cc=philipl@overt.org \
--cc=pierre@ossman.eu \
--cc=tridentperfusion@yahoo.com \
--cc=ulf.hansson@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).