* [PATCH] dt-bindings: pci: apple,pcie: Drop max-link-speed from example
@ 2022-05-02 9:13 Hector Martin
2022-05-02 11:40 ` Alyssa Rosenzweig
2022-05-04 22:18 ` Rob Herring
0 siblings, 2 replies; 3+ messages in thread
From: Hector Martin @ 2022-05-02 9:13 UTC (permalink / raw)
To: Sven Peter
Cc: Alyssa Rosenzweig, Rob Herring, Mark Kettenis, Marc Zyngier,
linux-arm-kernel, linux-pci, devicetree, linux-kernel,
Hector Martin
We no longer use these since 111659c2a570 (and they never worked
anyway); drop them from the example to avoid confusion.
Fixes: 111659c2a570 ("arm64: dts: apple: t8103: Remove PCIe max-link-speed properties")
Signed-off-by: Hector Martin <marcan@marcan.st>
---
Documentation/devicetree/bindings/pci/apple,pcie.yaml | 3 ---
1 file changed, 3 deletions(-)
diff --git a/Documentation/devicetree/bindings/pci/apple,pcie.yaml b/Documentation/devicetree/bindings/pci/apple,pcie.yaml
index 7f01e15fc81c..daf602ac0d0f 100644
--- a/Documentation/devicetree/bindings/pci/apple,pcie.yaml
+++ b/Documentation/devicetree/bindings/pci/apple,pcie.yaml
@@ -142,7 +142,6 @@ examples:
device_type = "pci";
reg = <0x0 0x0 0x0 0x0 0x0>;
reset-gpios = <&pinctrl_ap 152 0>;
- max-link-speed = <2>;
#address-cells = <3>;
#size-cells = <2>;
@@ -153,7 +152,6 @@ examples:
device_type = "pci";
reg = <0x800 0x0 0x0 0x0 0x0>;
reset-gpios = <&pinctrl_ap 153 0>;
- max-link-speed = <2>;
#address-cells = <3>;
#size-cells = <2>;
@@ -164,7 +162,6 @@ examples:
device_type = "pci";
reg = <0x1000 0x0 0x0 0x0 0x0>;
reset-gpios = <&pinctrl_ap 33 0>;
- max-link-speed = <1>;
#address-cells = <3>;
#size-cells = <2>;
--
2.35.1
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] dt-bindings: pci: apple,pcie: Drop max-link-speed from example
2022-05-02 9:13 [PATCH] dt-bindings: pci: apple,pcie: Drop max-link-speed from example Hector Martin
@ 2022-05-02 11:40 ` Alyssa Rosenzweig
2022-05-04 22:18 ` Rob Herring
1 sibling, 0 replies; 3+ messages in thread
From: Alyssa Rosenzweig @ 2022-05-02 11:40 UTC (permalink / raw)
To: Hector Martin
Cc: Sven Peter, Rob Herring, Mark Kettenis, Marc Zyngier,
linux-arm-kernel, linux-pci, devicetree, linux-kernel
Reviewed-by: Alyssa Rosenzweig <alyssa@rosenzweig.io>
On Mon, May 02, 2022 at 06:13:08PM +0900, Hector Martin wrote:
> We no longer use these since 111659c2a570 (and they never worked
> anyway); drop them from the example to avoid confusion.
>
> Fixes: 111659c2a570 ("arm64: dts: apple: t8103: Remove PCIe max-link-speed properties")
> Signed-off-by: Hector Martin <marcan@marcan.st>
> ---
> Documentation/devicetree/bindings/pci/apple,pcie.yaml | 3 ---
> 1 file changed, 3 deletions(-)
>
> diff --git a/Documentation/devicetree/bindings/pci/apple,pcie.yaml b/Documentation/devicetree/bindings/pci/apple,pcie.yaml
> index 7f01e15fc81c..daf602ac0d0f 100644
> --- a/Documentation/devicetree/bindings/pci/apple,pcie.yaml
> +++ b/Documentation/devicetree/bindings/pci/apple,pcie.yaml
> @@ -142,7 +142,6 @@ examples:
> device_type = "pci";
> reg = <0x0 0x0 0x0 0x0 0x0>;
> reset-gpios = <&pinctrl_ap 152 0>;
> - max-link-speed = <2>;
>
> #address-cells = <3>;
> #size-cells = <2>;
> @@ -153,7 +152,6 @@ examples:
> device_type = "pci";
> reg = <0x800 0x0 0x0 0x0 0x0>;
> reset-gpios = <&pinctrl_ap 153 0>;
> - max-link-speed = <2>;
>
> #address-cells = <3>;
> #size-cells = <2>;
> @@ -164,7 +162,6 @@ examples:
> device_type = "pci";
> reg = <0x1000 0x0 0x0 0x0 0x0>;
> reset-gpios = <&pinctrl_ap 33 0>;
> - max-link-speed = <1>;
>
> #address-cells = <3>;
> #size-cells = <2>;
> --
> 2.35.1
>
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] dt-bindings: pci: apple,pcie: Drop max-link-speed from example
2022-05-02 9:13 [PATCH] dt-bindings: pci: apple,pcie: Drop max-link-speed from example Hector Martin
2022-05-02 11:40 ` Alyssa Rosenzweig
@ 2022-05-04 22:18 ` Rob Herring
1 sibling, 0 replies; 3+ messages in thread
From: Rob Herring @ 2022-05-04 22:18 UTC (permalink / raw)
To: Hector Martin
Cc: Mark Kettenis, Marc Zyngier, linux-arm-kernel, Rob Herring,
devicetree, Sven Peter, Alyssa Rosenzweig, linux-kernel,
linux-pci
On Mon, 02 May 2022 18:13:08 +0900, Hector Martin wrote:
> We no longer use these since 111659c2a570 (and they never worked
> anyway); drop them from the example to avoid confusion.
>
> Fixes: 111659c2a570 ("arm64: dts: apple: t8103: Remove PCIe max-link-speed properties")
> Signed-off-by: Hector Martin <marcan@marcan.st>
> ---
> Documentation/devicetree/bindings/pci/apple,pcie.yaml | 3 ---
> 1 file changed, 3 deletions(-)
>
Applied, thanks!
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2022-05-04 22:18 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-05-02 9:13 [PATCH] dt-bindings: pci: apple,pcie: Drop max-link-speed from example Hector Martin
2022-05-02 11:40 ` Alyssa Rosenzweig
2022-05-04 22:18 ` Rob Herring
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).