From: Rob Herring <robh@kernel.org>
To: Geert Uytterhoeven <geert@linux-m68k.org>
Cc: "Krzysztof Kozlowski" <krzysztof.kozlowski@linaro.org>,
"Herve Codina" <herve.codina@bootlin.com>,
"Marek Vasut" <marek.vasut+renesas@gmail.com>,
"Yoshihiro Shimoda" <yoshihiro.shimoda.uh@renesas.com>,
"Bjorn Helgaas" <bhelgaas@google.com>,
"Krzysztof Kozlowski" <krzk+dt@kernel.org>,
"Geert Uytterhoeven" <geert+renesas@glider.be>,
"Magnus Damm" <magnus.damm@gmail.com>,
"Lorenzo Pieralisi" <lorenzo.pieralisi@arm.com>,
"Krzysztof Wilczyński" <kw@linux.com>,
linux-pci <linux-pci@vger.kernel.org>,
Linux-Renesas <linux-renesas-soc@vger.kernel.org>,
"open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS"
<devicetree@vger.kernel.org>,
"Linux Kernel Mailing List" <linux-kernel@vger.kernel.org>,
"Sergey Shtylyov" <s.shtylyov@omp.ru>,
"Thomas Petazzoni" <thomas.petazzoni@bootlin.com>,
"Clement Leger" <clement.leger@bootlin.com>,
"Miquel Raynal" <miquel.raynal@bootlin.com>
Subject: Re: [PATCH v5 2/6] dt-bindings: PCI: renesas,pci-rcar-gen2: Add device tree support for r9a06g032
Date: Mon, 2 May 2022 14:44:09 -0500 [thread overview]
Message-ID: <YnA0id1rXlNHNz+N@robh.at.kernel.org> (raw)
In-Reply-To: <CAMuHMdWN_ni_V+e3QipWH2qKXeNPkEcVpHpb5iBYw1YQSAnCDA@mail.gmail.com>
On Mon, May 02, 2022 at 11:19:19AM +0200, Geert Uytterhoeven wrote:
> Hi Krzysztof,
>
> On Sun, May 1, 2022 at 10:51 AM Krzysztof Kozlowski
> <krzysztof.kozlowski@linaro.org> wrote:
> > On 29/04/2022 15:41, Herve Codina wrote:
> > > Add internal PCI bridge support for the r9a06g032 SOC. The Renesas
> > > RZ/N1D (R9A06G032) internal PCI bridge is compatible with the one
> > > present in the R-Car Gen2 family.
> > > Compared to the R-Car Gen2 family, it needs three clocks instead of
> > > one.
> > >
> > > The 'resets' property for the RZ/N1 family is not required since
> > > there is no reset-controller support yet for the RZ/N1 family.
> >
> > This should not be a reason why a property is or is not required. Either
> > this is required for device operation or not. If it is required, should
> > be in the bindings. Otherwise what are you going to do in the future?
> > Add a required property breaking the ABI?
>
> The problem is that there are no bindings for the reset controller
> (actually the reset controller feature of the system-controller) yet.
> Yeah, we can just add #reset-cells = <1> to the system-controller
> device node, but we cannot add the actual resets properties to the
> consumers, until the actual cell values are defined.
Sounds like you should implement providers first. Or just live with the
warning as a reminder to implement the reset provider?
Rob
next prev parent reply other threads:[~2022-05-02 19:44 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-04-29 13:41 [PATCH v5 0/6] RZN1 USB Host support Herve Codina
2022-04-29 13:41 ` [PATCH v4 " Herve Codina
2022-04-29 13:41 ` [PATCH v5 1/6] dt-bindings: PCI: pci-rcar-gen2: Convert bindings to json-schema Herve Codina
2022-04-29 13:41 ` [PATCH v5 2/6] dt-bindings: PCI: renesas,pci-rcar-gen2: Add device tree support for r9a06g032 Herve Codina
2022-05-01 8:51 ` Krzysztof Kozlowski
2022-05-02 9:19 ` Geert Uytterhoeven
2022-05-02 19:44 ` Rob Herring [this message]
2022-05-03 6:51 ` Geert Uytterhoeven
2022-05-03 9:29 ` Krzysztof Kozlowski
2022-05-03 9:37 ` Geert Uytterhoeven
2022-05-06 12:35 ` Herve Codina
2022-05-04 13:53 ` Rob Herring
2022-05-20 8:23 ` Herve Codina
2022-05-20 8:29 ` Geert Uytterhoeven
2022-05-20 8:31 ` Krzysztof Kozlowski
2022-04-29 13:41 ` [PATCH v5 3/6] PCI: rcar-gen2: Add RZ/N1 SOCs family compatible string Herve Codina
2022-05-11 9:42 ` Lorenzo Pieralisi
2022-05-11 12:05 ` Geert Uytterhoeven
2022-04-29 13:41 ` [PATCH v5 4/6] ARM: dts: r9a06g032: Add internal PCI bridge node Herve Codina
2022-04-29 13:41 ` [PATCH v5 5/6] ARM: dts: r9a06g032: Add USB PHY DT support Herve Codina
2022-04-29 13:41 ` [PATCH v5 6/6] ARM: dts: r9a06g032: Link the PCI USB devices to the USB PHY Herve Codina
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YnA0id1rXlNHNz+N@robh.at.kernel.org \
--to=robh@kernel.org \
--cc=bhelgaas@google.com \
--cc=clement.leger@bootlin.com \
--cc=devicetree@vger.kernel.org \
--cc=geert+renesas@glider.be \
--cc=geert@linux-m68k.org \
--cc=herve.codina@bootlin.com \
--cc=krzk+dt@kernel.org \
--cc=krzysztof.kozlowski@linaro.org \
--cc=kw@linux.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pci@vger.kernel.org \
--cc=linux-renesas-soc@vger.kernel.org \
--cc=lorenzo.pieralisi@arm.com \
--cc=magnus.damm@gmail.com \
--cc=marek.vasut+renesas@gmail.com \
--cc=miquel.raynal@bootlin.com \
--cc=s.shtylyov@omp.ru \
--cc=thomas.petazzoni@bootlin.com \
--cc=yoshihiro.shimoda.uh@renesas.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).