From: Logan Gunthorpe <logang@deltatee.com>
To: Nicholas Johnson <nicholas.johnson-opensource@outlook.com.au>,
"benh@kernel.crashing.org" <benh@kernel.crashing.org>
Cc: "linux-pci@vger.kernel.org" <linux-pci@vger.kernel.org>,
Bjorn Helgaas <helgaas@kernel.org>
Subject: Re: [nicholas.johnson-opensource@outlook.com.au: [PATCH v6 4/4] PCI: Add pci=hpmemprefsize parameter to set MMIO_PREF size independently]
Date: Wed, 19 Jun 2019 10:45:38 -0600 [thread overview]
Message-ID: <a473bee0-0a25-64d5-bd29-1d5bdc43d027@deltatee.com> (raw)
In-Reply-To: <SL2P216MB018784C16CC1903DF2CEDCB880E50@SL2P216MB0187.KORP216.PROD.OUTLOOK.COM>
On 2019-06-19 8:01 a.m., Nicholas Johnson wrote:
> Hi Ben and Logan,
>
> It looks like my git send-email has been not working correctly since I
> started trying to get these patches accepted. I may have remedied this
> now, but I have seen that Logan tried to find these patches and failed.
> So as a courtesy until I post PATCH v7 (hopefully correctly, this time),
> I am forwarding you the patches. I hope you like them. I would love to
> know of any concerns or questions you may have, and / or what happens if
> you test them. Thanks and all the best!
>
> ----- Forwarded message from Nicholas Johnson <nicholas.johnson-opensource@outlook.com.au> -----
>
> Date: Thu, 23 May 2019 06:29:28 +0800
> From: Nicholas Johnson <nicholas.johnson-opensource@outlook.com.au>
> To: linux-kernel@vger.kernel.org
> Cc: linux-pci@vger.kernel.org, bhelgaas@google.com, mika.westerberg@linux.intel.com, corbet@lwn.net, Nicholas Johnson <nicholas.johnson-opensource@outlook.com.au>
> Subject: [PATCH v6 4/4] PCI: Add pci=hpmemprefsize parameter to set MMIO_PREF size independently
> X-Mailer: git-send-email 2.19.1
>
> Add kernel parameter pci=hpmemprefsize=nn[KMG] to control MMIO_PREF size
> for PCI hotplug bridges.
Makes sense.
> Change behaviour of pci=hpmemsize=nn[KMG] to not set MMIO_PREF size if
> hpmempref has been specified, rather than controlling both MMIO and
> MMIO_PREF sizes unconditionally.
I don't think I like that fact that hpmemsize behaves differently if
hpmempref size is specfied before it. I'd probably suggest having three
parameters: hpmemsize which sets both as it always has, a pref one and a
regular one which each set one of parameters.
Logan
next parent reply other threads:[~2019-06-19 16:45 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <SL2P216MB018784C16CC1903DF2CEDCB880E50@SL2P216MB0187.KORP216.PROD.OUTLOOK.COM>
2019-06-19 16:45 ` Logan Gunthorpe [this message]
2019-06-20 0:56 ` [nicholas.johnson-opensource@outlook.com.au: [PATCH v6 4/4] PCI: Add pci=hpmemprefsize parameter to set MMIO_PREF size independently] Nicholas Johnson
2019-06-20 1:35 ` Logan Gunthorpe
2019-06-20 13:47 ` Bjorn Helgaas
2019-06-21 2:57 ` Nicholas Johnson
2019-06-21 5:11 ` Logan Gunthorpe
2019-06-21 6:01 ` Nicholas Johnson
2019-06-21 16:03 ` Logan Gunthorpe
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=a473bee0-0a25-64d5-bd29-1d5bdc43d027@deltatee.com \
--to=logang@deltatee.com \
--cc=benh@kernel.crashing.org \
--cc=helgaas@kernel.org \
--cc=linux-pci@vger.kernel.org \
--cc=nicholas.johnson-opensource@outlook.com.au \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).