From: Shameerali Kolothum Thodi <shameerali.kolothum.thodi@huawei.com>
To: Alex Williamson <alex.williamson@redhat.com>,
Jason Gunthorpe <jgg@nvidia.com>
Cc: "kvm@vger.kernel.org" <kvm@vger.kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"linux-crypto@vger.kernel.org" <linux-crypto@vger.kernel.org>,
"linux-pci@vger.kernel.org" <linux-pci@vger.kernel.org>,
"cohuck@redhat.com" <cohuck@redhat.com>,
"mgurtovoy@nvidia.com" <mgurtovoy@nvidia.com>,
"yishaih@nvidia.com" <yishaih@nvidia.com>,
Linuxarm <linuxarm@huawei.com>,
liulongfang <liulongfang@huawei.com>,
"Zengtao (B)" <prime.zeng@hisilicon.com>,
Jonathan Cameron <jonathan.cameron@huawei.com>,
"Wangzhou (B)" <wangzhou1@hisilicon.com>,
Xu Zaibo <xuzaibo@huawei.com>
Subject: RE: [PATCH v8 8/9] hisi_acc_vfio_pci: Add support for VFIO live migration
Date: Mon, 7 Mar 2022 19:29:06 +0000 [thread overview]
Message-ID: <aac9a26dc27140d9a1ce56ebdec393a6@huawei.com> (raw)
In-Reply-To: <20220307120513.74743f17.alex.williamson@redhat.com>
> -----Original Message-----
> From: Alex Williamson [mailto:alex.williamson@redhat.com]
> Sent: 07 March 2022 19:05
> To: Jason Gunthorpe <jgg@nvidia.com>
> Cc: Shameerali Kolothum Thodi <shameerali.kolothum.thodi@huawei.com>;
> kvm@vger.kernel.org; linux-kernel@vger.kernel.org;
> linux-crypto@vger.kernel.org; linux-pci@vger.kernel.org; cohuck@redhat.com;
> mgurtovoy@nvidia.com; yishaih@nvidia.com; Linuxarm
> <linuxarm@huawei.com>; liulongfang <liulongfang@huawei.com>; Zengtao (B)
> <prime.zeng@hisilicon.com>; Jonathan Cameron
> <jonathan.cameron@huawei.com>; Wangzhou (B) <wangzhou1@hisilicon.com>
> Subject: Re: [PATCH v8 8/9] hisi_acc_vfio_pci: Add support for VFIO live
> migration
>
> On Fri, 4 Mar 2022 16:57:20 -0400
> Jason Gunthorpe <jgg@nvidia.com> wrote:
>
> > On Thu, Mar 03, 2022 at 11:01:30PM +0000, Shameer Kolothum wrote:
> > > From: Longfang Liu <liulongfang@huawei.com>
> > >
> > > VMs assigned with HiSilicon ACC VF devices can now perform live
> migration
> > > if the VF devices are bind to the hisi_acc_vfio_pci driver.
> > >
> > > Signed-off-by: Longfang Liu <liulongfang@huawei.com>
> > > Signed-off-by: Shameer Kolothum
> <shameerali.kolothum.thodi@huawei.com>
> > > ---
> > > drivers/vfio/pci/hisilicon/Kconfig | 7 +
> > > .../vfio/pci/hisilicon/hisi_acc_vfio_pci.c | 1078 ++++++++++++++++-
> > > .../vfio/pci/hisilicon/hisi_acc_vfio_pci.h | 114 ++
> > > 3 files changed, 1181 insertions(+), 18 deletions(-)
> > > create mode 100644 drivers/vfio/pci/hisilicon/hisi_acc_vfio_pci.h
> > >
> > > diff --git a/drivers/vfio/pci/hisilicon/Kconfig
> b/drivers/vfio/pci/hisilicon/Kconfig
> > > index dc723bad05c2..2a68d39f339f 100644
> > > --- a/drivers/vfio/pci/hisilicon/Kconfig
> > > +++ b/drivers/vfio/pci/hisilicon/Kconfig
> > > @@ -3,6 +3,13 @@ config HISI_ACC_VFIO_PCI
> > > tristate "VFIO PCI support for HiSilicon ACC devices"
> > > depends on ARM64 || (COMPILE_TEST && 64BIT)
> > > depends on VFIO_PCI_CORE
> > > + depends on PCI && PCI_MSI
> >
> > PCI is already in the depends from the 2nd line in
> > drivers/vfio/pci/Kconfig, but it is harmless
> >
> > > + depends on UACCE || UACCE=n
> > > + depends on ACPI
> >
> > Scratching my head a bit on why we have these
>
> Same curiosity from me, each of the CRYPTO_DEV_HISI_* options selected
> also depend on these so they seem redundant.
Yes, they are redundant now since we have added CRYPTO_DEV_HISI_ drivers
as "depends" now. I will remove that.
> I think we still require acks from Bjorn and Zaibo for select patches
> in this series.
I checked with Ziabo. He moved projects and is no longer looking into crypto stuff.
Wangzhou and LiuLongfang now take care of this. Received acks from Wangzhou
already and I will request Longfang to provide his. Hope that's ok.
>
> From me, I would request a MAINTAINERS entry similar to the one the
> mlx5 folks added for their driver. This should be in patch 4/9 where
> the driver is originally added. Thanks,
Ok I will do that. I will pick up the R-by tags as well and send out v9 by
tomorrow.
Thanks,
Shameer
next prev parent reply other threads:[~2022-03-07 19:29 UTC|newest]
Thread overview: 56+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-03-03 23:01 [PATCH v8 0/9] vfio/hisilicon: add ACC live migration driver Shameer Kolothum
2022-03-03 23:01 ` [PATCH v8 1/9] crypto: hisilicon/qm: Move the QM header to include/linux Shameer Kolothum
2022-03-04 9:03 ` Zhou Wang
2022-03-04 11:33 ` Shameerali Kolothum Thodi
2022-03-08 1:07 ` liulongfang
2022-03-08 10:27 ` yekai(A)
2022-03-03 23:01 ` [PATCH v8 2/9] crypto: hisilicon/qm: Move few definitions to common header Shameer Kolothum
2022-03-04 9:06 ` Zhou Wang
2022-03-03 23:01 ` [PATCH v8 3/9] hisi_acc_qm: Move VF PCI device IDs " Shameer Kolothum
2022-03-04 9:34 ` Zhou Wang
2022-03-04 11:35 ` Shameerali Kolothum Thodi
2022-03-07 17:53 ` Alex Williamson
2022-03-10 13:55 ` Shameerali Kolothum Thodi
2022-03-08 1:08 ` liulongfang
2022-03-08 10:28 ` yekai(A)
2022-03-03 23:01 ` [PATCH v8 4/9] hisi_acc_vfio_pci: add new vfio_pci driver for HiSilicon ACC devices Shameer Kolothum
2022-03-03 23:01 ` [PATCH v8 5/9] hisi_acc_vfio_pci: Restrict access to VF dev BAR2 migration region Shameer Kolothum
2022-03-08 1:11 ` liulongfang
2022-03-08 6:23 ` Tian, Kevin
2022-03-08 8:33 ` Shameerali Kolothum Thodi
2022-03-08 10:09 ` Tian, Kevin
2022-03-08 11:02 ` Shameerali Kolothum Thodi
2022-03-03 23:01 ` [PATCH v8 6/9] hisi_acc_vfio_pci: Add helper to retrieve the struct pci_driver Shameer Kolothum
2022-03-04 9:40 ` Zhou Wang
2022-03-04 11:31 ` Shameerali Kolothum Thodi
2022-03-08 10:28 ` yekai(A)
2022-03-08 12:02 ` liulongfang
2022-03-03 23:01 ` [PATCH v8 7/9] crypto: hisilicon/qm: Set the VF QM state register Shameer Kolothum
2022-03-04 9:43 ` Zhou Wang
2022-03-08 6:31 ` Tian, Kevin
2022-03-08 8:46 ` Shameerali Kolothum Thodi
2022-03-08 10:10 ` Tian, Kevin
2022-03-03 23:01 ` [PATCH v8 8/9] hisi_acc_vfio_pci: Add support for VFIO live migration Shameer Kolothum
2022-03-04 8:48 ` Shameerali Kolothum Thodi
2022-03-04 19:44 ` Alex Williamson
2022-03-04 20:36 ` Shameerali Kolothum Thodi
2022-03-04 20:40 ` Alex Williamson
2022-03-04 20:57 ` Jason Gunthorpe
2022-03-07 19:05 ` Alex Williamson
2022-03-07 19:29 ` Shameerali Kolothum Thodi [this message]
2022-03-07 19:52 ` Alex Williamson
2022-03-08 8:11 ` Tian, Kevin
2022-03-08 19:33 ` Alex Williamson
2022-03-09 10:11 ` Tian, Kevin
2022-03-10 20:49 ` Alex Williamson
2022-03-11 8:52 ` Cornelia Huck
2022-03-11 13:21 ` Shameerali Kolothum Thodi
2022-03-14 3:40 ` Tian, Kevin
2022-03-14 15:03 ` Jason Gunthorpe
2022-03-08 9:46 ` liulongfang
2022-03-08 7:41 ` Tian, Kevin
2022-03-08 8:52 ` Shameerali Kolothum Thodi
2022-03-08 10:17 ` Tian, Kevin
2022-03-03 23:01 ` [PATCH v8 9/9] hisi_acc_vfio_pci: Use its own PCI reset_done error handler Shameer Kolothum
2022-03-04 20:54 ` Jason Gunthorpe
2022-03-08 1:14 ` liulongfang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=aac9a26dc27140d9a1ce56ebdec393a6@huawei.com \
--to=shameerali.kolothum.thodi@huawei.com \
--cc=alex.williamson@redhat.com \
--cc=cohuck@redhat.com \
--cc=jgg@nvidia.com \
--cc=jonathan.cameron@huawei.com \
--cc=kvm@vger.kernel.org \
--cc=linux-crypto@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pci@vger.kernel.org \
--cc=linuxarm@huawei.com \
--cc=liulongfang@huawei.com \
--cc=mgurtovoy@nvidia.com \
--cc=prime.zeng@hisilicon.com \
--cc=wangzhou1@hisilicon.com \
--cc=xuzaibo@huawei.com \
--cc=yishaih@nvidia.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).