linux-pci.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* [PATCH v4] PCI: mediatek-gen3: Change driver name to mtk-pcie-gen3
@ 2022-05-05  8:39 Felix Fietkau
  2022-05-05 12:06 ` Jianjun Wang
  2022-08-23 13:00 ` Lorenzo Pieralisi
  0 siblings, 2 replies; 3+ messages in thread
From: Felix Fietkau @ 2022-05-05  8:39 UTC (permalink / raw)
  To: Ryder Lee, Jianjun Wang, Lorenzo Pieralisi, Rob Herring,
	Krzysztof Wilczyński, Bjorn Helgaas, Matthias Brugger
  Cc: AngeloGioacchino Del Regno, linux-pci, linux-mediatek,
	linux-kernel, linux-arm-kernel

driver_register() will refuse to register another driver with the same name.
This change allows pcie-mediatek-gen3 to coexist with pcie-mediatek built into
the kernel.

Fixes: d3bf75b579b9 ("PCI: mediatek-gen3: Add MediaTek Gen3 driver for MT8192")
Reviewed-by: AngeloGioacchino Del Regno <angelogioacchino.delregno@collabora.com>
Signed-off-by: Felix Fietkau <nbd@nbd.name>
---
 drivers/pci/controller/pcie-mediatek-gen3.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/pci/controller/pcie-mediatek-gen3.c b/drivers/pci/controller/pcie-mediatek-gen3.c
index 3e8d70bfabc6..2e665cd7e735 100644
--- a/drivers/pci/controller/pcie-mediatek-gen3.c
+++ b/drivers/pci/controller/pcie-mediatek-gen3.c
@@ -1021,7 +1021,7 @@ static struct platform_driver mtk_pcie_driver = {
 	.probe = mtk_pcie_probe,
 	.remove = mtk_pcie_remove,
 	.driver = {
-		.name = "mtk-pcie",
+		.name = "mtk-pcie-gen3",
 		.of_match_table = mtk_pcie_of_match,
 		.pm = &mtk_pcie_pm_ops,
 	},
-- 
2.35.1


^ permalink raw reply related	[flat|nested] 3+ messages in thread

* Re: [PATCH v4] PCI: mediatek-gen3: Change driver name to mtk-pcie-gen3
  2022-05-05  8:39 [PATCH v4] PCI: mediatek-gen3: Change driver name to mtk-pcie-gen3 Felix Fietkau
@ 2022-05-05 12:06 ` Jianjun Wang
  2022-08-23 13:00 ` Lorenzo Pieralisi
  1 sibling, 0 replies; 3+ messages in thread
From: Jianjun Wang @ 2022-05-05 12:06 UTC (permalink / raw)
  To: Felix Fietkau, Ryder Lee, Lorenzo Pieralisi, Rob Herring,
	Krzysztof Wilczyński, Bjorn Helgaas, Matthias Brugger
  Cc: AngeloGioacchino Del Regno, linux-pci, linux-mediatek,
	linux-kernel, linux-arm-kernel

Hi Felix,

Thanks for the fix.

Reviewed-by: Jianjun Wang <jianjun.wang@mediatek.com>

Thanks.

On Thu, 2022-05-05 at 10:39 +0200, Felix Fietkau wrote:
> driver_register() will refuse to register another driver with the
> same name.
> This change allows pcie-mediatek-gen3 to coexist with pcie-mediatek
> built into
> the kernel.
> 
> Fixes: d3bf75b579b9 ("PCI: mediatek-gen3: Add MediaTek Gen3 driver
> for MT8192")
> Reviewed-by: AngeloGioacchino Del Regno <
> angelogioacchino.delregno@collabora.com>
> Signed-off-by: Felix Fietkau <nbd@nbd.name>
> ---
>  drivers/pci/controller/pcie-mediatek-gen3.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/pci/controller/pcie-mediatek-gen3.c
> b/drivers/pci/controller/pcie-mediatek-gen3.c
> index 3e8d70bfabc6..2e665cd7e735 100644
> --- a/drivers/pci/controller/pcie-mediatek-gen3.c
> +++ b/drivers/pci/controller/pcie-mediatek-gen3.c
> @@ -1021,7 +1021,7 @@ static struct platform_driver mtk_pcie_driver =
> {
>  	.probe = mtk_pcie_probe,
>  	.remove = mtk_pcie_remove,
>  	.driver = {
> -		.name = "mtk-pcie",
> +		.name = "mtk-pcie-gen3",
>  		.of_match_table = mtk_pcie_of_match,
>  		.pm = &mtk_pcie_pm_ops,
>  	},


^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [PATCH v4] PCI: mediatek-gen3: Change driver name to mtk-pcie-gen3
  2022-05-05  8:39 [PATCH v4] PCI: mediatek-gen3: Change driver name to mtk-pcie-gen3 Felix Fietkau
  2022-05-05 12:06 ` Jianjun Wang
@ 2022-08-23 13:00 ` Lorenzo Pieralisi
  1 sibling, 0 replies; 3+ messages in thread
From: Lorenzo Pieralisi @ 2022-08-23 13:00 UTC (permalink / raw)
  To: Ryder Lee, Krzysztof Wilczyński, Felix Fietkau, Rob Herring,
	Bjorn Helgaas, Matthias Brugger, Jianjun Wang, Lorenzo Pieralisi
  Cc: linux-arm-kernel, linux-pci, linux-kernel, linux-mediatek,
	AngeloGioacchino Del Regno

On Thu, 5 May 2022 10:39:07 +0200, Felix Fietkau wrote:
> driver_register() will refuse to register another driver with the same name.
> This change allows pcie-mediatek-gen3 to coexist with pcie-mediatek built into
> the kernel.
> 
> 

Applied to pci/mediatek, thanks!

[1/1] PCI: mediatek-gen3: Change driver name to mtk-pcie-gen3
      https://git.kernel.org/lpieralisi/pci/c/034fdac01fe5

Thanks,
Lorenzo

^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2022-08-23 16:31 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-05-05  8:39 [PATCH v4] PCI: mediatek-gen3: Change driver name to mtk-pcie-gen3 Felix Fietkau
2022-05-05 12:06 ` Jianjun Wang
2022-08-23 13:00 ` Lorenzo Pieralisi

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).