From: Tony Garnock-Jones <tonyg@leastfixedpoint.com>
To: Ian Rogers <irogers@google.com>
Cc: peterz@infradead.org, mingo@redhat.com, acme@kernel.org,
linux-perf-users@vger.kernel.org
Subject: Re: [PATCH v2] tools/perf: Use long-running addr2line per dso
Date: Sat, 11 Sep 2021 00:55:54 +0200 [thread overview]
Message-ID: <77d5e86c-e02a-3462-3334-696b9933334d@leastfixedpoint.com> (raw)
In-Reply-To: <CAP-5=fXXyfWJLDMKZEfgu2RAkJrE45m3+3FYzE5xceMjcm1TEg@mail.gmail.com>
Hi Ian,
On 9/11/21 12:45 AM, Ian Rogers wrote:
> I tested with memory sanitizer and no issues.
Great!
> The assignments of 0 and NULL here are redundant.
Yes, ok. I usually spell these things out for the reader, but it makes
perfect sense to let zalloc() do its job :)
> I'm not clear on the use of stanza here, it seems to imply reading >1
> line but the out arguments/function don't agree with this. I think
> this would read better by just dropping the word stanza.
It does read more than one line - it reads exactly two lines. But
calling it a stanza is a bit silly, I agree; how about "record"?
I'm about to mail v3 of the patch incorporating your comments.
Regards,
Tony
next prev parent reply other threads:[~2021-09-10 22:55 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-09-09 11:22 [PATCH] tools/perf: Use long-running addr2line per dso Tony Garnock-Jones
2021-09-09 16:52 ` Alex Xu (Hello71)
2021-09-09 20:19 ` Arnaldo Carvalho de Melo
2021-09-10 8:58 ` Tony Garnock-Jones
2021-09-10 8:54 ` Tony Garnock-Jones
2021-09-09 19:05 ` Ian Rogers
2021-09-10 8:57 ` Tony Garnock-Jones
2021-09-10 10:23 ` [PATCH v2] " Tony Garnock-Jones
2021-09-10 22:45 ` Ian Rogers
2021-09-10 22:55 ` Tony Garnock-Jones [this message]
2021-09-10 22:55 ` [PATCH v3] " Tony Garnock-Jones
2021-09-11 0:25 ` Ian Rogers
2021-09-13 20:05 ` Arnaldo Carvalho de Melo
2021-09-16 12:09 ` [PATCH v4] " Tony Garnock-Jones
2021-10-01 0:29 ` Ian Rogers
2021-10-01 1:20 ` Arnaldo Carvalho de Melo
2021-10-04 12:29 ` Arnaldo Carvalho de Melo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=77d5e86c-e02a-3462-3334-696b9933334d@leastfixedpoint.com \
--to=tonyg@leastfixedpoint.com \
--cc=acme@kernel.org \
--cc=irogers@google.com \
--cc=linux-perf-users@vger.kernel.org \
--cc=mingo@redhat.com \
--cc=peterz@infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).