linux-perf-users.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Arnaldo Carvalho de Melo <acme@kernel.org>
To: Tony Garnock-Jones <tonyg@leastfixedpoint.com>
Cc: peterz@infradead.org, mingo@redhat.com,
	linux-perf-users@vger.kernel.org, Ian Rogers <irogers@google.com>
Subject: Re: [PATCH v4] tools/perf: Use long-running addr2line per dso
Date: Mon, 4 Oct 2021 09:29:00 -0300	[thread overview]
Message-ID: <YVrzjCSXaO2AuYQe@kernel.org> (raw)
In-Reply-To: <20210916120939.453536-1-tonyg@leastfixedpoint.com>

Em Thu, Sep 16, 2021 at 02:09:39PM +0200, Tony Garnock-Jones escreveu:
> Invoking addr2line in a separate subprocess, one for each required
> lookup, takes a terribly long time. This patch introduces a
> long-running addr2line process for each dso, *DRAMATICALLY* speeding
> up runs of perf. What used to take tens of minutes now takes tens of
> seconds.
> 
> Debian bug report about this issue:
> https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=911815
> 
> Signed-off-by: Tony Garnock-Jones <tonyg@leastfixedpoint.com>
> Tested-by: Ian Rogers <irogers@google.com>
> 
> ---
> Changes since v3:
>  - use zfree(), plus some small code compaction edits
>  - rebase against upstream master ff1ffd71d5f0612cf194f5705c671d6b64bf5f91
> 
> Changes since v2:
>  - remove redundant initializations to 0 and NULL
>  - use terminology "record" instead of "stanza" for input from addr2line
> 
> Changes since v1:
>  - use "subcmd/run-command.h" machinery instead of socketpair/fork/exec directly

Thanks, applied.

- Arnaldo


      parent reply	other threads:[~2021-10-04 12:29 UTC|newest]

Thread overview: 17+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-09-09 11:22 [PATCH] tools/perf: Use long-running addr2line per dso Tony Garnock-Jones
2021-09-09 16:52 ` Alex Xu (Hello71)
2021-09-09 20:19   ` Arnaldo Carvalho de Melo
2021-09-10  8:58     ` Tony Garnock-Jones
2021-09-10  8:54   ` Tony Garnock-Jones
2021-09-09 19:05 ` Ian Rogers
2021-09-10  8:57   ` Tony Garnock-Jones
2021-09-10 10:23 ` [PATCH v2] " Tony Garnock-Jones
2021-09-10 22:45   ` Ian Rogers
2021-09-10 22:55     ` Tony Garnock-Jones
2021-09-10 22:55   ` [PATCH v3] " Tony Garnock-Jones
2021-09-11  0:25     ` Ian Rogers
2021-09-13 20:05     ` Arnaldo Carvalho de Melo
2021-09-16 12:09       ` [PATCH v4] " Tony Garnock-Jones
2021-10-01  0:29         ` Ian Rogers
2021-10-01  1:20           ` Arnaldo Carvalho de Melo
2021-10-04 12:29         ` Arnaldo Carvalho de Melo [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=YVrzjCSXaO2AuYQe@kernel.org \
    --to=acme@kernel.org \
    --cc=irogers@google.com \
    --cc=linux-perf-users@vger.kernel.org \
    --cc=mingo@redhat.com \
    --cc=peterz@infradead.org \
    --cc=tonyg@leastfixedpoint.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).