* [PATCH] cpufreq/pstate: Only mention the BIOS disabling turbo mode once
@ 2020-04-10 19:26 Chris Wilson
2020-04-26 15:02 ` Rafael J. Wysocki
0 siblings, 1 reply; 2+ messages in thread
From: Chris Wilson @ 2020-04-10 19:26 UTC (permalink / raw)
To: intel-gfx
Cc: linux-pm, Chris Wilson, Srinivas Pandruvada, Len Brown,
Rafael J. Wysocki, Viresh Kumar
Make a note of the first time we discover the turbo mode has been
disabled by the BIOS, as otherwise we complain every time we try to
update the mode.
Signed-off-by: Chris Wilson <chris@chris-wilson.co.uk>
Cc: Srinivas Pandruvada <srinivas.pandruvada@linux.intel.com>
Cc: Len Brown <lenb@kernel.org>
Cc: "Rafael J. Wysocki" <rjw@rjwysocki.net>
Cc: Viresh Kumar <viresh.kumar@linaro.org>
---
drivers/cpufreq/intel_pstate.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/cpufreq/intel_pstate.c b/drivers/cpufreq/intel_pstate.c
index c81e1ff29069..b4c014464a20 100644
--- a/drivers/cpufreq/intel_pstate.c
+++ b/drivers/cpufreq/intel_pstate.c
@@ -1058,7 +1058,7 @@ static ssize_t store_no_turbo(struct kobject *a, struct kobj_attribute *b,
update_turbo_state();
if (global.turbo_disabled) {
- pr_warn("Turbo disabled by BIOS or unavailable on processor\n");
+ pr_notice_once("Turbo disabled by BIOS or unavailable on processor\n");
mutex_unlock(&intel_pstate_limits_lock);
mutex_unlock(&intel_pstate_driver_lock);
return -EPERM;
--
2.20.1
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] cpufreq/pstate: Only mention the BIOS disabling turbo mode once
2020-04-10 19:26 [PATCH] cpufreq/pstate: Only mention the BIOS disabling turbo mode once Chris Wilson
@ 2020-04-26 15:02 ` Rafael J. Wysocki
0 siblings, 0 replies; 2+ messages in thread
From: Rafael J. Wysocki @ 2020-04-26 15:02 UTC (permalink / raw)
To: Chris Wilson
Cc: intel-gfx, linux-pm, Srinivas Pandruvada, Len Brown, Viresh Kumar
On Friday, April 10, 2020 9:26:29 PM CEST Chris Wilson wrote:
> Make a note of the first time we discover the turbo mode has been
> disabled by the BIOS, as otherwise we complain every time we try to
> update the mode.
>
> Signed-off-by: Chris Wilson <chris@chris-wilson.co.uk>
> Cc: Srinivas Pandruvada <srinivas.pandruvada@linux.intel.com>
> Cc: Len Brown <lenb@kernel.org>
> Cc: "Rafael J. Wysocki" <rjw@rjwysocki.net>
> Cc: Viresh Kumar <viresh.kumar@linaro.org>
> ---
> drivers/cpufreq/intel_pstate.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/cpufreq/intel_pstate.c b/drivers/cpufreq/intel_pstate.c
> index c81e1ff29069..b4c014464a20 100644
> --- a/drivers/cpufreq/intel_pstate.c
> +++ b/drivers/cpufreq/intel_pstate.c
> @@ -1058,7 +1058,7 @@ static ssize_t store_no_turbo(struct kobject *a, struct kobj_attribute *b,
>
> update_turbo_state();
> if (global.turbo_disabled) {
> - pr_warn("Turbo disabled by BIOS or unavailable on processor\n");
> + pr_notice_once("Turbo disabled by BIOS or unavailable on processor\n");
> mutex_unlock(&intel_pstate_limits_lock);
> mutex_unlock(&intel_pstate_driver_lock);
> return -EPERM;
>
Applied as a fix for 5.7-rc4, sorry for the delay.
Thanks!
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2020-04-26 15:02 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-04-10 19:26 [PATCH] cpufreq/pstate: Only mention the BIOS disabling turbo mode once Chris Wilson
2020-04-26 15:02 ` Rafael J. Wysocki
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).