linux-pm.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* [PATCH v5] dt-bindings: gpu: mali-utgard: Add the #cooling-cells property
@ 2020-04-11 16:57 Martin Blumenstingl
  2020-04-15  7:52 ` Neil Armstrong
  2020-04-20 19:15 ` Rob Herring
  0 siblings, 2 replies; 3+ messages in thread
From: Martin Blumenstingl @ 2020-04-11 16:57 UTC (permalink / raw)
  To: robh+dt, dri-devel, devicetree
  Cc: linux-kernel, linux-pm, linux-amlogic, Martin Blumenstingl, Qiang Yu

The GPU can be one of the big heat sources on a SoC. Allow the
"#cooling-cells" property to be specified for ARM Mali Utgard GPUs so
the GPU clock speeds (and voltages) can be reduced to prevent a SoC from
overheating.

Reviewed-by: Qiang Yu <yuq825@gmail.com>
Signed-off-by: Martin Blumenstingl <martin.blumenstingl@googlemail.com>
---
Changes since v4 at [0]:
- Added Qiang's Reviewed-by (many thanks)
- re-send because I missed the devicetree mailing list in v4


[0] https://patchwork.kernel.org/patch/11448013/


 Documentation/devicetree/bindings/gpu/arm,mali-utgard.yaml | 4 ++++
 1 file changed, 4 insertions(+)

diff --git a/Documentation/devicetree/bindings/gpu/arm,mali-utgard.yaml b/Documentation/devicetree/bindings/gpu/arm,mali-utgard.yaml
index f5401cc8de4a..4869258daadb 100644
--- a/Documentation/devicetree/bindings/gpu/arm,mali-utgard.yaml
+++ b/Documentation/devicetree/bindings/gpu/arm,mali-utgard.yaml
@@ -107,6 +107,9 @@ properties:
 
   operating-points-v2: true
 
+  "#cooling-cells":
+    const: 2
+
 required:
   - compatible
   - reg
@@ -164,6 +167,7 @@ examples:
       clocks = <&ccu 1>, <&ccu 2>;
       clock-names = "bus", "core";
       resets = <&ccu 1>;
+      #cooling-cells = <2>;
     };
 
 ...
-- 
2.26.0


^ permalink raw reply related	[flat|nested] 3+ messages in thread

* Re: [PATCH v5] dt-bindings: gpu: mali-utgard: Add the #cooling-cells property
  2020-04-11 16:57 [PATCH v5] dt-bindings: gpu: mali-utgard: Add the #cooling-cells property Martin Blumenstingl
@ 2020-04-15  7:52 ` Neil Armstrong
  2020-04-20 19:15 ` Rob Herring
  1 sibling, 0 replies; 3+ messages in thread
From: Neil Armstrong @ 2020-04-15  7:52 UTC (permalink / raw)
  To: Martin Blumenstingl, robh+dt, dri-devel, devicetree
  Cc: linux-amlogic, Qiang Yu, linux-kernel, linux-pm

On 11/04/2020 18:57, Martin Blumenstingl wrote:
> The GPU can be one of the big heat sources on a SoC. Allow the
> "#cooling-cells" property to be specified for ARM Mali Utgard GPUs so
> the GPU clock speeds (and voltages) can be reduced to prevent a SoC from
> overheating.
> 
> Reviewed-by: Qiang Yu <yuq825@gmail.com>
> Signed-off-by: Martin Blumenstingl <martin.blumenstingl@googlemail.com>
> ---
> Changes since v4 at [0]:
> - Added Qiang's Reviewed-by (many thanks)
> - re-send because I missed the devicetree mailing list in v4
> 
> 
> [0] https://patchwork.kernel.org/patch/11448013/
> 
> 
>  Documentation/devicetree/bindings/gpu/arm,mali-utgard.yaml | 4 ++++
>  1 file changed, 4 insertions(+)
> 
> diff --git a/Documentation/devicetree/bindings/gpu/arm,mali-utgard.yaml b/Documentation/devicetree/bindings/gpu/arm,mali-utgard.yaml
> index f5401cc8de4a..4869258daadb 100644
> --- a/Documentation/devicetree/bindings/gpu/arm,mali-utgard.yaml
> +++ b/Documentation/devicetree/bindings/gpu/arm,mali-utgard.yaml
> @@ -107,6 +107,9 @@ properties:
>  
>    operating-points-v2: true
>  
> +  "#cooling-cells":
> +    const: 2
> +
>  required:
>    - compatible
>    - reg
> @@ -164,6 +167,7 @@ examples:
>        clocks = <&ccu 1>, <&ccu 2>;
>        clock-names = "bus", "core";
>        resets = <&ccu 1>;
> +      #cooling-cells = <2>;
>      };
>  
>  ...
> 

Reviewed-by: Neil Armstrong <narmstrong@baylibre.com>

^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [PATCH v5] dt-bindings: gpu: mali-utgard: Add the #cooling-cells property
  2020-04-11 16:57 [PATCH v5] dt-bindings: gpu: mali-utgard: Add the #cooling-cells property Martin Blumenstingl
  2020-04-15  7:52 ` Neil Armstrong
@ 2020-04-20 19:15 ` Rob Herring
  1 sibling, 0 replies; 3+ messages in thread
From: Rob Herring @ 2020-04-20 19:15 UTC (permalink / raw)
  To: Martin Blumenstingl
  Cc: robh+dt, dri-devel, devicetree, linux-kernel, linux-pm,
	linux-amlogic, Martin Blumenstingl, Qiang Yu

On Sat, 11 Apr 2020 18:57:00 +0200, Martin Blumenstingl wrote:
> The GPU can be one of the big heat sources on a SoC. Allow the
> "#cooling-cells" property to be specified for ARM Mali Utgard GPUs so
> the GPU clock speeds (and voltages) can be reduced to prevent a SoC from
> overheating.
> 
> Reviewed-by: Qiang Yu <yuq825@gmail.com>
> Signed-off-by: Martin Blumenstingl <martin.blumenstingl@googlemail.com>
> ---
> Changes since v4 at [0]:
> - Added Qiang's Reviewed-by (many thanks)
> - re-send because I missed the devicetree mailing list in v4
> 
> 
> [0] https://patchwork.kernel.org/patch/11448013/
> 
> 
>  Documentation/devicetree/bindings/gpu/arm,mali-utgard.yaml | 4 ++++
>  1 file changed, 4 insertions(+)
> 

Applied, thanks.

Rob

^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2020-04-20 19:15 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-04-11 16:57 [PATCH v5] dt-bindings: gpu: mali-utgard: Add the #cooling-cells property Martin Blumenstingl
2020-04-15  7:52 ` Neil Armstrong
2020-04-20 19:15 ` Rob Herring

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).