From: Thara Gopinath <thara.gopinath@linaro.org>
To: daniel.lezcano@linaro.org, rui.zhang@intel.com, robh+dt@kernel.org
Cc: linux-pm@vger.kernel.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: [RFC PATCH 4/4] thermal: Modify thermal governors to do nothing for "cold" trip points
Date: Fri, 10 Jul 2020 09:51:54 -0400 [thread overview]
Message-ID: <20200710135154.181454-5-thara.gopinath@linaro.org> (raw)
In-Reply-To: <20200710135154.181454-1-thara.gopinath@linaro.org>
For now, thermal governors do not support monitoring of falling
temperature. Hence, in case of calls to the governor for trip points marked
as cold, return doing nothing.
Signed-off-by: Thara Gopinath <thara.gopinath@linaro.org>
---
drivers/thermal/gov_bang_bang.c | 8 ++++++++
drivers/thermal/gov_fair_share.c | 8 ++++++++
drivers/thermal/gov_power_allocator.c | 8 ++++++++
drivers/thermal/gov_step_wise.c | 8 ++++++++
4 files changed, 32 insertions(+)
diff --git a/drivers/thermal/gov_bang_bang.c b/drivers/thermal/gov_bang_bang.c
index 991a1c54296d..8324d13de1e7 100644
--- a/drivers/thermal/gov_bang_bang.c
+++ b/drivers/thermal/gov_bang_bang.c
@@ -99,6 +99,14 @@ static void thermal_zone_trip_update(struct thermal_zone_device *tz, int trip)
static int bang_bang_control(struct thermal_zone_device *tz, int trip)
{
struct thermal_instance *instance;
+ enum thermal_trip_type trip_type;
+
+ /* Return doing nothing in case of cold trip point */
+ if (trip != THERMAL_TRIPS_NONE) {
+ tz->ops->get_trip_type(tz, trip, &trip_type);
+ if (trip_type == THERMAL_TRIP_COLD)
+ return 0;
+ }
thermal_zone_trip_update(tz, trip);
diff --git a/drivers/thermal/gov_fair_share.c b/drivers/thermal/gov_fair_share.c
index aaa07180ab48..c0adce525faa 100644
--- a/drivers/thermal/gov_fair_share.c
+++ b/drivers/thermal/gov_fair_share.c
@@ -81,6 +81,14 @@ static int fair_share_throttle(struct thermal_zone_device *tz, int trip)
int total_weight = 0;
int total_instance = 0;
int cur_trip_level = get_trip_level(tz);
+ enum thermal_trip_type trip_type;
+
+ /* Return doing nothing in case of cold trip point */
+ if (trip != THERMAL_TRIPS_NONE) {
+ tz->ops->get_trip_type(tz, trip, &trip_type);
+ if (trip_type == THERMAL_TRIP_COLD)
+ return 0;
+ }
list_for_each_entry(instance, &tz->thermal_instances, tz_node) {
if (instance->trip != trip)
diff --git a/drivers/thermal/gov_power_allocator.c b/drivers/thermal/gov_power_allocator.c
index 44636475b2a3..2644ad4d4032 100644
--- a/drivers/thermal/gov_power_allocator.c
+++ b/drivers/thermal/gov_power_allocator.c
@@ -613,8 +613,16 @@ static int power_allocator_throttle(struct thermal_zone_device *tz, int trip)
{
int ret;
int switch_on_temp, control_temp;
+ enum thermal_trip_type trip_type;
struct power_allocator_params *params = tz->governor_data;
+ /* Return doing nothing in case of cold trip point */
+ if (trip != THERMAL_TRIPS_NONE) {
+ tz->ops->get_trip_type(tz, trip, &trip_type);
+ if (trip_type == THERMAL_TRIP_COLD)
+ return 0;
+ }
+
/*
* We get called for every trip point but we only need to do
* our calculations once
diff --git a/drivers/thermal/gov_step_wise.c b/drivers/thermal/gov_step_wise.c
index 2ae7198d3067..009aefda0441 100644
--- a/drivers/thermal/gov_step_wise.c
+++ b/drivers/thermal/gov_step_wise.c
@@ -186,6 +186,14 @@ static void thermal_zone_trip_update(struct thermal_zone_device *tz, int trip)
static int step_wise_throttle(struct thermal_zone_device *tz, int trip)
{
struct thermal_instance *instance;
+ enum thermal_trip_type trip_type;
+
+ /* For now, return doing nothing in case of cold trip point */
+ if (trip != THERMAL_TRIPS_NONE) {
+ tz->ops->get_trip_type(tz, trip, &trip_type);
+ if (trip_type == THERMAL_TRIP_COLD)
+ return 0;
+ }
thermal_zone_trip_update(tz, trip);
--
2.25.1
next prev parent reply other threads:[~2020-07-10 13:52 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-07-10 13:51 [RFC PATCH 0/4] thermal: Introduce support for monitoring falling temperature Thara Gopinath
2020-07-10 13:51 ` [RFC PATCH 1/4] dt-bindings:thermal:Add cold trip point type Thara Gopinath
2020-07-13 15:05 ` Daniel Lezcano
2020-07-13 17:01 ` Thara Gopinath
2020-07-13 17:03 ` Daniel Lezcano
2020-07-10 13:51 ` [RFC PATCH 2/4] thermal: Add support for cold trip point Thara Gopinath
2020-07-10 13:51 ` [RFC PATCH 3/4] thermal:core:Add genetlink notifications for monitoring falling temperature Thara Gopinath
2020-07-15 8:46 ` Zhang Rui
2020-07-15 23:15 ` Thara Gopinath
2020-07-10 13:51 ` Thara Gopinath [this message]
2020-07-15 8:35 ` [RFC PATCH 4/4] thermal: Modify thermal governors to do nothing for "cold" trip points Zhang Rui
2020-07-15 23:13 ` Thara Gopinath
2020-07-13 15:03 ` [RFC PATCH 0/4] thermal: Introduce support for monitoring falling temperature Daniel Lezcano
2020-07-14 13:49 ` Zhang Rui
2020-07-14 21:39 ` Thara Gopinath
2020-07-15 8:27 ` Zhang Rui
2020-07-15 23:10 ` Thara Gopinath
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200710135154.181454-5-thara.gopinath@linaro.org \
--to=thara.gopinath@linaro.org \
--cc=daniel.lezcano@linaro.org \
--cc=devicetree@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=robh+dt@kernel.org \
--cc=rui.zhang@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).