linux-pm.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* [PATCH -next] x86/power: fix doc warnings in cpu.c
@ 2021-06-08  2:54 Baokun Li
  2021-06-11 16:47 ` Rafael J. Wysocki
  0 siblings, 1 reply; 2+ messages in thread
From: Baokun Li @ 2021-06-08  2:54 UTC (permalink / raw)
  To: rjw, pavel, tglx, mingo, bp, x86, hpa, linux-pm, linux-kernel
  Cc: weiyongjun1, yuehaibing, yangjihong1, yukuai3, libaokun1

Fixes the following W=1 kernel build warning(s):

 arch/x86/power/cpu.c:76: warning: Function parameter or
  member 'ctxt' not described in '__save_processor_state'
 arch/x86/power/cpu.c:192: warning: Function parameter or
  member 'ctxt' not described in '__restore_processor_state'

Signed-off-by: Baokun Li <libaokun1@huawei.com>
---
 arch/x86/power/cpu.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/arch/x86/power/cpu.c b/arch/x86/power/cpu.c
index 3a070e7cdb8b..2640b9128479 100644
--- a/arch/x86/power/cpu.c
+++ b/arch/x86/power/cpu.c
@@ -60,7 +60,7 @@ static void msr_restore_context(struct saved_context *ctxt)
 /**
  *	__save_processor_state - save CPU registers before creating a
  *		hibernation image and before restoring the memory state from it
- *	@ctxt - structure to store the registers contents in
+ *	@ctxt: structure to store the registers contents in
  *
  *	NOTE: If there is a CPU register the modification of which by the
  *	boot kernel (ie. the kernel used for loading the hibernation image)
@@ -183,7 +183,7 @@ static void fix_processor_context(void)
 /**
  * __restore_processor_state - restore the contents of CPU registers saved
  *                             by __save_processor_state()
- * @ctxt - structure to load the registers contents from
+ * @ctxt: structure to load the registers contents from
  *
  * The asm code that gets us here will have restored a usable GDT, although
  * it will be pointing to the wrong alias.
-- 
2.31.1


^ permalink raw reply related	[flat|nested] 2+ messages in thread

* Re: [PATCH -next] x86/power: fix doc warnings in cpu.c
  2021-06-08  2:54 [PATCH -next] x86/power: fix doc warnings in cpu.c Baokun Li
@ 2021-06-11 16:47 ` Rafael J. Wysocki
  0 siblings, 0 replies; 2+ messages in thread
From: Rafael J. Wysocki @ 2021-06-11 16:47 UTC (permalink / raw)
  To: Baokun Li
  Cc: Rafael J. Wysocki, Pavel Machek, Thomas Gleixner, Ingo Molnar,
	Borislav Petkov, the arch/x86 maintainers, H. Peter Anvin,
	Linux PM, Linux Kernel Mailing List, Wei Yongjun, Yue Haibing,
	yangjihong1, yu kuai

On Tue, Jun 8, 2021 at 4:45 AM Baokun Li <libaokun1@huawei.com> wrote:
>
> Fixes the following W=1 kernel build warning(s):
>
>  arch/x86/power/cpu.c:76: warning: Function parameter or
>   member 'ctxt' not described in '__save_processor_state'
>  arch/x86/power/cpu.c:192: warning: Function parameter or
>   member 'ctxt' not described in '__restore_processor_state'
>
> Signed-off-by: Baokun Li <libaokun1@huawei.com>
> ---
>  arch/x86/power/cpu.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/arch/x86/power/cpu.c b/arch/x86/power/cpu.c
> index 3a070e7cdb8b..2640b9128479 100644
> --- a/arch/x86/power/cpu.c
> +++ b/arch/x86/power/cpu.c
> @@ -60,7 +60,7 @@ static void msr_restore_context(struct saved_context *ctxt)
>  /**
>   *     __save_processor_state - save CPU registers before creating a
>   *             hibernation image and before restoring the memory state from it
> - *     @ctxt - structure to store the registers contents in
> + *     @ctxt: structure to store the registers contents in

Any chance to fix the formatting of this kerneldoc comment too in this patch?

>   *
>   *     NOTE: If there is a CPU register the modification of which by the
>   *     boot kernel (ie. the kernel used for loading the hibernation image)
> @@ -183,7 +183,7 @@ static void fix_processor_context(void)
>  /**
>   * __restore_processor_state - restore the contents of CPU registers saved
>   *                             by __save_processor_state()
> - * @ctxt - structure to load the registers contents from
> + * @ctxt: structure to load the registers contents from
>   *
>   * The asm code that gets us here will have restored a usable GDT, although
>   * it will be pointing to the wrong alias.
> --
> 2.31.1
>

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2021-06-11 16:47 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-06-08  2:54 [PATCH -next] x86/power: fix doc warnings in cpu.c Baokun Li
2021-06-11 16:47 ` Rafael J. Wysocki

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).