* [PATCH] PM / devfreq: imx8m-ddrc: Fix argument swap in error print
@ 2019-12-19 15:43 Leonard Crestez
2019-12-19 16:21 ` Chanwoo Choi
0 siblings, 1 reply; 2+ messages in thread
From: Leonard Crestez @ 2019-12-19 15:43 UTC (permalink / raw)
To: Chanwoo Choi, Kyungmin Park, MyungJoo Ham
Cc: Adam Ford, Martin Kepplinger, Jacky Bai, Shawn Guo, Dong Aisheng,
Fabio Estevam, kernel, linux-imx, linux-arm-kernel, linux-pm
When frequency adjustment fails the old/new frequencies are swapped on
the dev_err call.
Signed-off-by: Leonard Crestez <leonard.crestez@nxp.com>
---
drivers/devfreq/imx8m-ddrc.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/devfreq/imx8m-ddrc.c b/drivers/devfreq/imx8m-ddrc.c
index ecbb1db05ea0..53df7923d893 100644
--- a/drivers/devfreq/imx8m-ddrc.c
+++ b/drivers/devfreq/imx8m-ddrc.c
@@ -258,14 +258,14 @@ static int imx8m_ddrc_target(struct device *dev, unsigned long *freq, u32 flags)
ret = imx8m_ddrc_set_freq(dev, freq_info);
new_freq = clk_get_rate(priv->dram_core);
if (ret)
dev_err(dev, "ddrc failed freq switch to %lu from %lu: error %d. now at %lu\n",
- old_freq, *freq, ret, new_freq);
+ *freq, old_freq, ret, new_freq);
else if (*freq != new_freq)
dev_err(dev, "ddrc failed freq update to %lu from %lu, now at %lu\n",
- old_freq, *freq, new_freq);
+ *freq, old_freq, new_freq);
else
dev_dbg(dev, "ddrc freq set to %lu (was %lu)\n",
*freq, old_freq);
return ret;
--
2.17.1
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] PM / devfreq: imx8m-ddrc: Fix argument swap in error print
2019-12-19 15:43 [PATCH] PM / devfreq: imx8m-ddrc: Fix argument swap in error print Leonard Crestez
@ 2019-12-19 16:21 ` Chanwoo Choi
0 siblings, 0 replies; 2+ messages in thread
From: Chanwoo Choi @ 2019-12-19 16:21 UTC (permalink / raw)
To: Leonard Crestez
Cc: Chanwoo Choi, Kyungmin Park, MyungJoo Ham, Adam Ford,
Martin Kepplinger, Jacky Bai, Shawn Guo, Dong Aisheng,
Fabio Estevam, kernel, dl-linux-imx, linux-arm-kernel,
Linux PM list
2019년 12월 20일 (금) 오전 12:44, Leonard Crestez <leonard.crestez@nxp.com>님이 작성:
>
> When frequency adjustment fails the old/new frequencies are swapped on
> the dev_err call.
>
> Signed-off-by: Leonard Crestez <leonard.crestez@nxp.com>
> ---
> drivers/devfreq/imx8m-ddrc.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/devfreq/imx8m-ddrc.c b/drivers/devfreq/imx8m-ddrc.c
> index ecbb1db05ea0..53df7923d893 100644
> --- a/drivers/devfreq/imx8m-ddrc.c
> +++ b/drivers/devfreq/imx8m-ddrc.c
> @@ -258,14 +258,14 @@ static int imx8m_ddrc_target(struct device *dev, unsigned long *freq, u32 flags)
> ret = imx8m_ddrc_set_freq(dev, freq_info);
>
> new_freq = clk_get_rate(priv->dram_core);
> if (ret)
> dev_err(dev, "ddrc failed freq switch to %lu from %lu: error %d. now at %lu\n",
> - old_freq, *freq, ret, new_freq);
> + *freq, old_freq, ret, new_freq);
> else if (*freq != new_freq)
> dev_err(dev, "ddrc failed freq update to %lu from %lu, now at %lu\n",
> - old_freq, *freq, new_freq);
> + *freq, old_freq, new_freq);
> else
> dev_dbg(dev, "ddrc freq set to %lu (was %lu)\n",
> *freq, old_freq);
>
> return ret;
> --
> 2.17.1
>
If you agree, I want to squash this patch to original patch on
devfreq-next patch
without separate patch applied.
--
Best Regards,
Chanwoo Choi
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2019-12-19 16:22 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-12-19 15:43 [PATCH] PM / devfreq: imx8m-ddrc: Fix argument swap in error print Leonard Crestez
2019-12-19 16:21 ` Chanwoo Choi
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).