From: Hugh Dickins <hughd@google.com>
To: "Rafael J. Wysocki" <rafael@kernel.org>
Cc: Hugh Dickins <hughd@google.com>,
Thierry Reding <treding@nvidia.com>,
Jonathan Hunter <jonathanh@nvidia.com>,
Saravana Kannan <saravanak@google.com>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
Linux PM <linux-pm@vger.kernel.org>
Subject: Re: 5.11-rc device reordering breaks ThinkPad rmi4 suspend
Date: Mon, 11 Jan 2021 09:20:37 -0800 (PST) [thread overview]
Message-ID: <alpine.LSU.2.11.2101110908170.1561@eggly.anvils> (raw)
In-Reply-To: <CAJZ5v0gUQApODPUuHkfmHUw30XhX3U-5zYDu5JrgehzVrtyJQw@mail.gmail.com>
On Mon, 11 Jan 2021, Rafael J. Wysocki wrote:
> On Mon, Jan 11, 2021 at 5:44 AM Hugh Dickins <hughd@google.com> wrote:
> >
> > Hi Rafael,
> >
> > Synaptics RMI4 SMBus touchpad on ThinkPad X1 Carbon (5th generation)
> > fails to suspend when running 5.11-rc kernels: bisected to
> > 5b6164d3465f ("driver core: Reorder devices on successful probe"),
> > and reverting that fixes it. dmesg.xz attached, but go ahead and ask
> > me to switch on a debug option to extract further info if that may help.
>
> Does the driver abort the suspend transition by returning an error or
> does something else happen?
Both. Thierry has pointed to the lines showing failed suspend transition;
and I forgot to mention that the touchpad is unresponsive from then on
(I might not have noticed the failed suspend without that). But I don't
suppose that unresponsiveness is worth worrying about: things went wrong
in suspend, so it's not surprising if the driver does not recover well.
Thank you both for getting on to this so quickly - but don't worry about
getting my touchpad working: I'm glad to see you discussing the wider
issues of ordering that this has brought up.
Hugh
next prev parent reply other threads:[~2021-01-11 17:21 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-01-11 4:44 5.11-rc device reordering breaks ThinkPad rmi4 suspend Hugh Dickins
2021-01-11 12:57 ` Rafael J. Wysocki
2021-01-11 17:20 ` Hugh Dickins [this message]
2021-01-11 13:43 ` Thierry Reding
2021-01-11 14:43 ` Rafael J. Wysocki
2021-01-11 14:57 ` Rafael J. Wysocki
2021-01-11 16:12 ` Thierry Reding
2021-01-11 16:57 ` Rafael J. Wysocki
2021-01-11 22:44 ` Saravana Kannan
2021-01-11 23:42 ` Hugh Dickins
2021-01-12 0:14 ` Saravana Kannan
2021-01-12 0:44 ` Hugh Dickins
2021-01-12 2:16 ` Saravana Kannan
2021-01-12 12:43 ` Rafael J. Wysocki
2021-01-12 17:37 ` Thierry Reding
2021-01-12 17:57 ` Thierry Reding
2021-01-12 20:38 ` Saravana Kannan
2021-01-11 17:42 ` Hugh Dickins
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=alpine.LSU.2.11.2101110908170.1561@eggly.anvils \
--to=hughd@google.com \
--cc=gregkh@linuxfoundation.org \
--cc=jonathanh@nvidia.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=rafael@kernel.org \
--cc=saravanak@google.com \
--cc=treding@nvidia.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).