From: Hugh Dickins <hughd@google.com>
To: Saravana Kannan <saravanak@google.com>
Cc: Hugh Dickins <hughd@google.com>,
"Rafael J. Wysocki" <rafael@kernel.org>,
Thierry Reding <treding@nvidia.com>,
Jonathan Hunter <jonathanh@nvidia.com>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Vincent Huang <vincent.huang@tw.synaptics.com>,
"Jason A. Donenfeld" <Jason@zx2c4.com>,
Andrew Duggan <aduggan@synaptics.com>,
Lucas Stach <l.stach@pengutronix.de>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
Linux PM <linux-pm@vger.kernel.org>
Subject: Re: 5.11-rc device reordering breaks ThinkPad rmi4 suspend
Date: Mon, 11 Jan 2021 16:44:21 -0800 (PST) [thread overview]
Message-ID: <alpine.LSU.2.11.2101111637330.2964@eggly.anvils> (raw)
In-Reply-To: <CAGETcx-gPA3HeSKS6XW1zYj_imjDH_86897Jub56b9ctBOqmwg@mail.gmail.com>
On Mon, 11 Jan 2021, Saravana Kannan wrote:
> On Mon, Jan 11, 2021 at 3:42 PM Hugh Dickins <hughd@google.com> wrote:
> > On Mon, 11 Jan 2021, Saravana Kannan wrote:
> > >
> > > I happen to have an X1 Carbon (different gen though) lying around and
> > > I poked at its /sys folders. None of the devices in the rmi4_smbus are
> > > considered the grandchildren of the i2c device. I think the real
> > > problem is rmi_register_transport_device() [1] not setting up the
> > > parent for any of the new devices it's adding.
> > >
> > > Hugh, can you try this patch?
> >
> > Just tried, but no, this patch does not help; but I bet
> > you're along the right lines, and something as simple will do it.
>
> Did you see this patch change the organization of devices under /sys/devices/?
> The rmi* devices need to be under one of the i2c devices after this
> patch. Is that not the case? Or is that the case, but you are still
> seeing suspend/resume issues?
Now that I look, yes, that patch has moved the directory
/sys/devices/rmi4-00
to
/sys/devices/pci0000:00/0000:00:1f.4/i2c-6/6-002c/rmi4-00
But I still see the same suspend issues despite that.
Hugh
next prev parent reply other threads:[~2021-01-12 0:45 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-01-11 4:44 5.11-rc device reordering breaks ThinkPad rmi4 suspend Hugh Dickins
2021-01-11 12:57 ` Rafael J. Wysocki
2021-01-11 17:20 ` Hugh Dickins
2021-01-11 13:43 ` Thierry Reding
2021-01-11 14:43 ` Rafael J. Wysocki
2021-01-11 14:57 ` Rafael J. Wysocki
2021-01-11 16:12 ` Thierry Reding
2021-01-11 16:57 ` Rafael J. Wysocki
2021-01-11 22:44 ` Saravana Kannan
2021-01-11 23:42 ` Hugh Dickins
2021-01-12 0:14 ` Saravana Kannan
2021-01-12 0:44 ` Hugh Dickins [this message]
2021-01-12 2:16 ` Saravana Kannan
2021-01-12 12:43 ` Rafael J. Wysocki
2021-01-12 17:37 ` Thierry Reding
2021-01-12 17:57 ` Thierry Reding
2021-01-12 20:38 ` Saravana Kannan
2021-01-11 17:42 ` Hugh Dickins
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=alpine.LSU.2.11.2101111637330.2964@eggly.anvils \
--to=hughd@google.com \
--cc=Jason@zx2c4.com \
--cc=aduggan@synaptics.com \
--cc=gregkh@linuxfoundation.org \
--cc=jonathanh@nvidia.com \
--cc=l.stach@pengutronix.de \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=rafael@kernel.org \
--cc=saravanak@google.com \
--cc=treding@nvidia.com \
--cc=vincent.huang@tw.synaptics.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).