From: Cyrill Gorcunov <gorcunov@gmail.com>
To: Cong Wang <xiyou.wangcong@gmail.com>
Cc: netdev@vger.kernel.org, Matt.Bennett@alliedtelesis.co.nz,
Paul Mackerras <paulus@samba.org>,
linux-ppp@vger.kernel.org, Guillaume Nault <g.nault@alphalink.fr>
Subject: Re: [Patch net] ppp: defer netns reference release for ppp channel
Date: Wed, 06 Jul 2016 08:26:02 +0000 [thread overview]
Message-ID: <20160706082602.GM4666@uranus> (raw)
In-Reply-To: <1467781956-2229-1-git-send-email-xiyou.wangcong@gmail.com>
On Tue, Jul 05, 2016 at 10:12:36PM -0700, Cong Wang wrote:
> Matt reported that we have a NULL pointer dereference
> in ppp_pernet() from ppp_connect_channel(),
> i.e. pch->chan_net is NULL.
>
> This is due to that a parallel ppp_unregister_channel()
> could happen while we are in ppp_connect_channel(), during
> which pch->chan_net set to NULL. Since we need a reference
> to net per channel, it makes sense to sync the refcnt
> with the life time of the channel, therefore we should
> release this reference when we destroy it.
>
> Fixes: 1f461dcdd296 ("ppp: take reference on channels netns")
> Reported-by: Matt Bennett <Matt.Bennett@alliedtelesis.co.nz>
> Cc: Paul Mackerras <paulus@samba.org>
> Cc: linux-ppp@vger.kernel.org
> Cc: Guillaume Nault <g.nault@alphalink.fr>
> Cc: Cyrill Gorcunov <gorcunov@openvz.org>
> Signed-off-by: Cong Wang <xiyou.wangcong@gmail.com>
> ---
Hi Cong! I may be wrong, but this doesn't look right in general.
We take the net in ppp_register_channel->ppp_register_net_channel
and (name) context implies that ppp_unregister_channel does
the reverse. Maybe there some sync point missed? I'll review
in detail a bit later.
next prev parent reply other threads:[~2016-07-06 8:26 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-07-06 5:12 [Patch net] ppp: defer netns reference release for ppp channel Cong Wang
2016-07-06 8:26 ` Cyrill Gorcunov [this message]
2016-07-06 12:25 ` Cyrill Gorcunov
2016-07-28 10:33 ` Guillaume Nault
2016-07-31 22:22 ` Cyrill Gorcunov
2016-07-09 3:47 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160706082602.GM4666@uranus \
--to=gorcunov@gmail.com \
--cc=Matt.Bennett@alliedtelesis.co.nz \
--cc=g.nault@alphalink.fr \
--cc=linux-ppp@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=paulus@samba.org \
--cc=xiyou.wangcong@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).