From: Cyrill Gorcunov <gorcunov@gmail.com>
To: Guillaume Nault <g.nault@alphalink.fr>
Cc: Cong Wang <xiyou.wangcong@gmail.com>,
netdev@vger.kernel.org, Matt.Bennett@alliedtelesis.co.nz,
Paul Mackerras <paulus@samba.org>,
linux-ppp@vger.kernel.org
Subject: Re: [Patch net] ppp: defer netns reference release for ppp channel
Date: Sun, 31 Jul 2016 22:22:02 +0000 [thread overview]
Message-ID: <20160731222202.GI26208@uranus> (raw)
In-Reply-To: <20160728103357.GA3031@alphalink.fr>
On Thu, Jul 28, 2016 at 12:33:58PM +0200, Guillaume Nault wrote:
> >
> > After staring more I think the patch should be fine as a fix
> > since implementing sync with ppp_[re|un]register_channel and
> > ppp_ioctl might need a way more work.
> >
>
> [Sorry for arriving so late in the game, I was offline the last 3 weeks]
>
> I agree having some symmetry between the creation and deletion
> processes would be nice and would make the code easier to reason about.
> Actually, I released the channel netns in ppp_unregister_channel() for
> exactly this reason (and failed to spot this race).
>
> But the code is already quite asymmetric and it's certainly too late to
> move away from this scheme now. So releasing the channel netns in
Yes, this module needs cleanup in general, so fix is fine, thanks!
next prev parent reply other threads:[~2016-07-31 22:22 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-07-06 5:12 [Patch net] ppp: defer netns reference release for ppp channel Cong Wang
2016-07-06 8:26 ` Cyrill Gorcunov
2016-07-06 12:25 ` Cyrill Gorcunov
2016-07-28 10:33 ` Guillaume Nault
2016-07-31 22:22 ` Cyrill Gorcunov [this message]
2016-07-09 3:47 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160731222202.GI26208@uranus \
--to=gorcunov@gmail.com \
--cc=Matt.Bennett@alliedtelesis.co.nz \
--cc=g.nault@alphalink.fr \
--cc=linux-ppp@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=paulus@samba.org \
--cc=xiyou.wangcong@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).