From: Jakub Kicinski <kuba@kernel.org>
To: Allen Pais <allen.lkml@gmail.com>
Cc: davem@davemloft.net, m.grzeschik@pengutronix.de,
paulus@samba.org, oliver@neukum.org, woojung.huh@microchip.com,
UNGLinuxDriver@microchip.com, petkan@nucleusys.com,
netdev@vger.kernel.org, linux-usb@vger.kernel.org,
linux-ppp@vger.kernel.org, Allen Pais <apais@linux.microsoft.com>,
Romain Perier <romain.perier@gmail.com>
Subject: Re: [RESEND net-next v2 01/12] net: mvpp2: Prepare to use the new tasklet API
Date: Tue, 15 Sep 2020 01:02:44 +0000 [thread overview]
Message-ID: <20200914180244.3581836c@kicinski-fedora-pc1c0hjn.dhcp.thefacebook.com> (raw)
In-Reply-To: <20200914073131.803374-2-allen.lkml@gmail.com>
On Mon, 14 Sep 2020 13:01:20 +0530 Allen Pais wrote:
> From: Allen Pais <apais@linux.microsoft.com>
>
> The future tasklet API will no longer allow to pass an arbitrary
> "unsigned long" data parameter. The tasklet data structure will need to
> be embedded into a data structure that will be retrieved from the tasklet
> handler. Currently, there are no ways to retrieve the "struct mvpp2_port
> *" from a given "struct mvpp2_port_pcpu *". This commit adds a new field
> to get the address of the main port for each pcpu context.
>
> Signed-off-by: Romain Perier <romain.perier@gmail.com>
> Signed-off-by: Allen Pais <apais@linux.microsoft.com>
> ---
> drivers/net/ethernet/marvell/mvpp2/mvpp2.h | 1 +
> drivers/net/ethernet/marvell/mvpp2/mvpp2_main.c | 1 +
> 2 files changed, 2 insertions(+)
>
> diff --git a/drivers/net/ethernet/marvell/mvpp2/mvpp2.h b/drivers/net/ethernet/marvell/mvpp2/mvpp2.h
> index 32753cc771bf..198860a4527d 100644
> --- a/drivers/net/ethernet/marvell/mvpp2/mvpp2.h
> +++ b/drivers/net/ethernet/marvell/mvpp2/mvpp2.h
> @@ -861,6 +861,7 @@ struct mvpp2_port_pcpu {
> struct hrtimer tx_done_timer;
> struct net_device *dev;
> bool timer_scheduled;
> + struct mvpp2_port *port;
> };
>
> struct mvpp2_queue_vector {
> diff --git a/drivers/net/ethernet/marvell/mvpp2/mvpp2_main.c b/drivers/net/ethernet/marvell/mvpp2/mvpp2_main.c
> index 6e140d1b8967..e8e68e8acdb3 100644
> --- a/drivers/net/ethernet/marvell/mvpp2/mvpp2_main.c
> +++ b/drivers/net/ethernet/marvell/mvpp2/mvpp2_main.c
> @@ -6025,6 +6025,7 @@ static int mvpp2_port_probe(struct platform_device *pdev,
> err = -ENOMEM;
> goto err_free_txq_pcpu;
> }
> + port->pcpu->port = port;
>
> if (!port->has_tx_irqs) {
> for (thread = 0; thread < priv->nthreads; thread++) {
Not 100% sure but I think this is yours:
drivers/net/ethernet/marvell/mvpp2/mvpp2_main.c:6442:13: warning: dereference of noderef expression
port->pcpu is __percpu, no?
next prev parent reply other threads:[~2020-09-15 1:02 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-09-14 7:43 [RESEND net-next v2 00/12]drivers: net: convert tasklets to use new tasklet_setup() API Allen Pais
2020-09-14 7:43 ` [RESEND net-next v2 01/12] net: mvpp2: Prepare to use the new tasklet API Allen Pais
2020-09-15 1:02 ` Jakub Kicinski [this message]
2020-09-14 7:43 ` [RESEND net-next v2 02/12] net: arcnet: convert tasklets to use new tasklet_setup() API Allen Pais
2020-09-14 7:43 ` [RESEND net-next v2 03/12] net: caif: " Allen Pais
2020-09-14 7:43 ` [RESEND net-next v2 04/12] net: ifb: " Allen Pais
2020-09-14 7:43 ` [RESEND net-next v2 05/12] net: ppp: " Allen Pais
2020-09-14 7:43 ` [RESEND net-next v2 06/12] net: cdc_ncm: " Allen Pais
2020-09-14 7:43 ` [RESEND net-next v2 07/12] net: hso: " Allen Pais
2020-09-14 7:43 ` [RESEND net-next v2 08/12] net: lan78xx: " Allen Pais
2020-09-14 7:43 ` [RESEND net-next v2 09/12] net: pegasus: " Allen Pais
2020-09-14 7:43 ` [RESEND net-next v2 10/12] net: r8152: " Allen Pais
2020-09-14 7:43 ` [RESEND net-next v2 11/12] net: rtl8150: " Allen Pais
2020-09-14 7:43 ` [RESEND net-next v2 12/12] net: usbnet: " Allen Pais
2020-09-14 8:02 ` Oliver Neukum
2020-09-14 20:24 ` [RESEND net-next v2 00/12]drivers: net: " David Miller
2020-09-15 4:20 ` Allen Pais
2020-09-14 21:16 ` Saeed Mahameed
2020-09-15 4:24 ` Allen Pais
2020-09-15 4:41 ` Saeed Mahameed
2020-09-15 4:56 ` Allen Pais
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200914180244.3581836c@kicinski-fedora-pc1c0hjn.dhcp.thefacebook.com \
--to=kuba@kernel.org \
--cc=UNGLinuxDriver@microchip.com \
--cc=allen.lkml@gmail.com \
--cc=apais@linux.microsoft.com \
--cc=davem@davemloft.net \
--cc=linux-ppp@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=m.grzeschik@pengutronix.de \
--cc=netdev@vger.kernel.org \
--cc=oliver@neukum.org \
--cc=paulus@samba.org \
--cc=petkan@nucleusys.com \
--cc=romain.perier@gmail.com \
--cc=woojung.huh@microchip.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).