From: Allen Pais <apais@linux.microsoft.com>
To: Saeed Mahameed <saeedm@nvidia.com>,
"davem@davemloft.net" <davem@davemloft.net>,
"allen.lkml@gmail.com" <allen.lkml@gmail.com>
Cc: "m.grzeschik@pengutronix.de" <m.grzeschik@pengutronix.de>,
"linux-usb@vger.kernel.org" <linux-usb@vger.kernel.org>,
"woojung.huh@microchip.com" <woojung.huh@microchip.com>,
"petkan@nucleusys.com" <petkan@nucleusys.com>,
"oliver@neukum.org" <oliver@neukum.org>,
"netdev@vger.kernel.org" <netdev@vger.kernel.org>,
"kuba@kernel.org" <kuba@kernel.org>,
"UNGLinuxDriver@microchip.com" <UNGLinuxDriver@microchip.com>,
"paulus@samba.org" <paulus@samba.org>,
"linux-ppp@vger.kernel.org" <linux-ppp@vger.kernel.org>
Subject: Re: [RESEND net-next v2 00/12]drivers: net: convert tasklets to use new tasklet_setup() API
Date: Tue, 15 Sep 2020 04:24:51 +0000 [thread overview]
Message-ID: <87508263-99f1-c56a-5fb1-2f4700b6b375@linux.microsoft.com> (raw)
In-Reply-To: <5ab44bd27936325201e8f71a30e74d8b9d6b34ee.camel@nvidia.com>
>>
>> ommit 12cc923f1ccc ("tasklet: Introduce new initialization API")'
>> introduced a new tasklet initialization API. This series converts
>> all the net/* drivers to use the new tasklet_setup() API
>>
>> This series is based on v5.9-rc5
>>
>> Allen Pais (12):
>> net: mvpp2: Prepare to use the new tasklet API
>> net: arcnet: convert tasklets to use new tasklet_setup() API
>> net: caif: convert tasklets to use new tasklet_setup() API
>> net: ifb: convert tasklets to use new tasklet_setup() API
>> net: ppp: convert tasklets to use new tasklet_setup() API
>> net: cdc_ncm: convert tasklets to use new tasklet_setup() API
>> net: hso: convert tasklets to use new tasklet_setup() API
>> net: lan78xx: convert tasklets to use new tasklet_setup() API
>> net: pegasus: convert tasklets to use new tasklet_setup() API
>> net: r8152: convert tasklets to use new tasklet_setup() API
>> net: rtl8150: convert tasklets to use new tasklet_setup() API
>> net: usbnet: convert tasklets to use new tasklet_setup() API
>>
>>
>
> You are only converting drivers which are passing the taskelt struct as
> data ptr, most of other drivers are passing the container of the
> tasklet as data, why not convert them as well, and let them use
> container_of to find their data ? it is really straight forward and
> will help convert most of net driver if not all.
>
from_tasklet uses container_of internally. use of container_of is
avoided cause it end being really long.
next prev parent reply other threads:[~2020-09-15 4:24 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-09-14 7:43 [RESEND net-next v2 00/12]drivers: net: convert tasklets to use new tasklet_setup() API Allen Pais
2020-09-14 7:43 ` [RESEND net-next v2 01/12] net: mvpp2: Prepare to use the new tasklet API Allen Pais
2020-09-15 1:02 ` Jakub Kicinski
2020-09-14 7:43 ` [RESEND net-next v2 02/12] net: arcnet: convert tasklets to use new tasklet_setup() API Allen Pais
2020-09-14 7:43 ` [RESEND net-next v2 03/12] net: caif: " Allen Pais
2020-09-14 7:43 ` [RESEND net-next v2 04/12] net: ifb: " Allen Pais
2020-09-14 7:43 ` [RESEND net-next v2 05/12] net: ppp: " Allen Pais
2020-09-14 7:43 ` [RESEND net-next v2 06/12] net: cdc_ncm: " Allen Pais
2020-09-14 7:43 ` [RESEND net-next v2 07/12] net: hso: " Allen Pais
2020-09-14 7:43 ` [RESEND net-next v2 08/12] net: lan78xx: " Allen Pais
2020-09-14 7:43 ` [RESEND net-next v2 09/12] net: pegasus: " Allen Pais
2020-09-14 7:43 ` [RESEND net-next v2 10/12] net: r8152: " Allen Pais
2020-09-14 7:43 ` [RESEND net-next v2 11/12] net: rtl8150: " Allen Pais
2020-09-14 7:43 ` [RESEND net-next v2 12/12] net: usbnet: " Allen Pais
2020-09-14 8:02 ` Oliver Neukum
2020-09-14 20:24 ` [RESEND net-next v2 00/12]drivers: net: " David Miller
2020-09-15 4:20 ` Allen Pais
2020-09-14 21:16 ` Saeed Mahameed
2020-09-15 4:24 ` Allen Pais [this message]
2020-09-15 4:41 ` Saeed Mahameed
2020-09-15 4:56 ` Allen Pais
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87508263-99f1-c56a-5fb1-2f4700b6b375@linux.microsoft.com \
--to=apais@linux.microsoft.com \
--cc=UNGLinuxDriver@microchip.com \
--cc=allen.lkml@gmail.com \
--cc=davem@davemloft.net \
--cc=kuba@kernel.org \
--cc=linux-ppp@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=m.grzeschik@pengutronix.de \
--cc=netdev@vger.kernel.org \
--cc=oliver@neukum.org \
--cc=paulus@samba.org \
--cc=petkan@nucleusys.com \
--cc=saeedm@nvidia.com \
--cc=woojung.huh@microchip.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).