[PATCH] pwm: ep93xx: Fix uninitialized variable bug in ep93xx_pwm_apply()

* [PATCH] pwm: ep93xx: Fix uninitialized variable bug in ep93xx_pwm_apply()
@ 2021-06-30 13:46 Dan Carpenter
  2021-06-30 15:36 ` Uwe Kleine-König
  0 siblings, 1 reply; 3+ messages in thread
From: Dan Carpenter @ 2021-06-30 13:46 UTC (permalink / raw)
  To: Thierry Reding, Uwe Kleine-König
  Cc: Lee Jones, linux-pwm, linux-kernel, kernel-janitors

Smatch found a potential uninitialized variable in ep93xx_pwm_apply():

    drivers/pwm/pwm-ep93xx.c:147 ep93xx_pwm_apply()
    error: uninitialized symbol 'ret'.

Initialize "ret" to zero at the start to solve this issue.

Fixes: f6ef94edf0f6 ("pwm: ep93xx: Unfold legacy callbacks into ep93xx_pwm_apply()")
Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
---
 drivers/pwm/pwm-ep93xx.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/pwm/pwm-ep93xx.c b/drivers/pwm/pwm-ep93xx.c
index 70fa2957f9d3..ffa79248c1e1 100644
--- a/drivers/pwm/pwm-ep93xx.c
+++ b/drivers/pwm/pwm-ep93xx.c
@@ -61,7 +61,7 @@ static void ep93xx_pwm_free(struct pwm_chip *chip, struct pwm_device *pwm)
 static int ep93xx_pwm_apply(struct pwm_chip *chip, struct pwm_device *pwm,
 			    const struct pwm_state *state)
 {
-	int ret;
+	int ret = 0;
 	struct ep93xx_pwm *ep93xx_pwm = to_ep93xx_pwm(chip);
 	bool enabled = state->enabled;
 
-- 
2.30.2


^ permalink raw reply related	[flat|nested] 3+ messages in thread