From: Lee Jones <lee@kernel.org>
To: "Uwe Kleine-König" <u.kleine-koenig@pengutronix.de>
Cc: Linux regressions mailing list <regressions@lists.linux.dev>,
linux-leds@vger.kernel.org, linux-pwm@vger.kernel.org,
LKML <linux-kernel@vger.kernel.org>
Subject: Re: [regression] stm32mp1xx based targets stopped entering suspend if pwm-leds exist
Date: Wed, 17 Apr 2024 15:49:43 +0100 [thread overview]
Message-ID: <20240417144943.GA2399047@google.com> (raw)
In-Reply-To: <dqibafuvizvltkblfizxvgrl3744lpxbwgdjid5ekxsju7gmxm@fys22ievmgz5>
On Tue, 16 Apr 2024, Uwe Kleine-König wrote:
> Hey Lee,
>
> On Tue, Apr 16, 2024 at 01:15:19PM +0100, Lee Jones wrote:
> > On Tue, 16 Apr 2024, Linux regression tracking (Thorsten Leemhuis) wrote:
> >
> > > On 06.03.24 09:18, Uwe Kleine-König wrote:
> > > > On Wed, Mar 06, 2024 at 08:05:15AM +0100, Linux regression tracking (Thorsten Leemhuis) wrote:
> > > > > [...]
> > >
> > > Jakob confirmed it helped in the bugzilla ticket. But the patch since
> > > then didn't make any progress afaics -- or did it and I just missed it
> > > in my search?
> >
> > [...]
> >
> > > > ---->8----
> > > > From: Uwe Kleine-König <u.kleine-koenig@pengutronix.de>
> > > > Subject: [PATCH] leds: pwm: Disable PWM when going to suspend
> > > >
> > > > On stm32mp1xx based machines (and others) a PWM consumer has to disable
> > > > the PWM because an enabled PWM refuses to suspend. So check the
> > > > LED_SUSPENDED flag and depending on that set the .enabled property.
> > > >
> > > > Link: https://bugzilla.kernel.org/show_bug.cgi?id=218559
> > > > Fixes: 76fe464c8e64 ("leds: pwm: Don't disable the PWM when the LED should be off")
> > > > Signed-off-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de>
> > > > ---
> > > > [...]
> > > > ---->8----
> >
> > Did you submit this? I don't see it in LORE or in my inbox.
>
> Yeah sure, apply it using:
>
> curl -s https://lore.kernel.org/all/2vbwacjy25z5vekylle3ehwi3be4urm6bssrbg6bxobtdlekt4@mazicwtgf4qb/raw | git am --scissors -s
Nice try!
> :-)
>
> If you don't consider that suitable, I can create a patch that is easier
> to pick up.
Yes, please submit it properly.
--
Lee Jones [李琼斯]
next prev parent reply other threads:[~2024-04-17 14:49 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-03-06 7:05 [regression] stm32mp1xx based targets stopped entering suspend if pwm-leds exist Linux regression tracking (Thorsten Leemhuis)
2024-03-06 8:18 ` Uwe Kleine-König
2024-04-16 8:28 ` Linux regression tracking (Thorsten Leemhuis)
2024-04-16 12:15 ` Lee Jones
2024-04-16 13:18 ` Uwe Kleine-König
2024-04-17 14:49 ` Lee Jones [this message]
2024-04-17 15:38 ` [PATCH] leds: pwm: Disable PWM when going to suspend Uwe Kleine-König
2024-04-26 6:17 ` Uwe Kleine-König
2024-04-26 6:30 ` Linux regression tracking (Thorsten Leemhuis)
2024-05-02 17:02 ` (subset) " Lee Jones
2024-05-02 17:04 ` Lee Jones
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240417144943.GA2399047@google.com \
--to=lee@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-leds@vger.kernel.org \
--cc=linux-pwm@vger.kernel.org \
--cc=regressions@lists.linux.dev \
--cc=u.kleine-koenig@pengutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).