From: "Uwe Kleine-König" <u.kleine-koenig@pengutronix.de>
To: Lee Jones <lee@kernel.org>
Cc: kernel@pengutronix.de, linux-pwm@vger.kernel.org,
Linux regressions mailing list <regressions@lists.linux.dev>,
linux-leds@vger.kernel.org, LKML <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] leds: pwm: Disable PWM when going to suspend
Date: Fri, 26 Apr 2024 08:17:41 +0200 [thread overview]
Message-ID: <yitqw57rdkr44ly32sxukxa2m4a6jm74upfxc74dmbklucl6kq@3ni7emsqgzx4> (raw)
In-Reply-To: <20240417153846.271751-2-u.kleine-koenig@pengutronix.de>
[-- Attachment #1: Type: text/plain, Size: 1190 bytes --]
Hello Lee,
On Wed, Apr 17, 2024 at 05:38:47PM +0200, Uwe Kleine-König wrote:
> On stm32mp1xx based machines (and others) a PWM consumer has to disable
> the PWM because an enabled PWM refuses to suspend. So check the
> LED_SUSPENDED flag and depending on that set the .enabled property.
>
> Link: https://bugzilla.kernel.org/show_bug.cgi?id=218559
> Fixes: 76fe464c8e64 ("leds: pwm: Don't disable the PWM when the LED should be off")
> Signed-off-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de>
> ---
> Hello,
>
> On Wed, Apr 17, 2024 at 03:49:43PM +0100, Lee Jones wrote:
> > On Tue, 16 Apr 2024, Uwe Kleine-König wrote:
> > > If you don't consider that suitable, I can create a patch that is easier
> > > to pick up.
> >
> > Yes, please submit it properly.
Gentle ping. Even given the regression was introduced in v6.7-rc1
already, I think this should go into v6.9. If you don't agree that's
fine, but then getting it onto next to queue it for v6.10-rc1 at least
would be great.
Thanks
Uwe
--
Pengutronix e.K. | Uwe Kleine-König |
Industrial Linux Solutions | https://www.pengutronix.de/ |
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
next prev parent reply other threads:[~2024-04-26 6:17 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-03-06 7:05 [regression] stm32mp1xx based targets stopped entering suspend if pwm-leds exist Linux regression tracking (Thorsten Leemhuis)
2024-03-06 8:18 ` Uwe Kleine-König
2024-04-16 8:28 ` Linux regression tracking (Thorsten Leemhuis)
2024-04-16 12:15 ` Lee Jones
2024-04-16 13:18 ` Uwe Kleine-König
2024-04-17 14:49 ` Lee Jones
2024-04-17 15:38 ` [PATCH] leds: pwm: Disable PWM when going to suspend Uwe Kleine-König
2024-04-26 6:17 ` Uwe Kleine-König [this message]
2024-04-26 6:30 ` Linux regression tracking (Thorsten Leemhuis)
2024-05-02 17:02 ` (subset) " Lee Jones
2024-05-02 17:04 ` Lee Jones
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=yitqw57rdkr44ly32sxukxa2m4a6jm74upfxc74dmbklucl6kq@3ni7emsqgzx4 \
--to=u.kleine-koenig@pengutronix.de \
--cc=kernel@pengutronix.de \
--cc=lee@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-leds@vger.kernel.org \
--cc=linux-pwm@vger.kernel.org \
--cc=regressions@lists.linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).