From: Zhong Lidong <lidong.zhong@suse.com>
To: Nix <nix@esperi.org.uk>
Cc: linux-raid@vger.kernel.org
Subject: Re: [RFC PATCH] Detail: don't display the raid level when it's inactive
Date: Sat, 12 Sep 2020 23:03:25 +0800 [thread overview]
Message-ID: <0fb181ac-e6c4-45e4-d29d-19a98343fb82@suse.com> (raw)
In-Reply-To: <87wo1emyi4.fsf@esperi.org.uk>
On 9/1/20 3:00 AM, Nix wrote:
> On 31 Aug 2020, Zhong Lidong told this:
>
>> On 8/29/20 12:38 AM, Ian Pilcher wrote:
>>> On 8/26/20 10:16 AM, Lidong Zhong wrote:
>>>> ...
>>>> So the misleading "raid0" is shown in this testcase. I think maybe
>>>> the "Raid Level" item shouldn't be displayed any more for the inactive
>>>> array.
>>>
>>> As a system administrator, I'd much rather see "unknown" (or something
>>> similar), rather than simply omitting the information.
>>>
>> Thanks for the suggestion.
>> Yeah, just removing the Raid Level info is not the best option. I also
>> considered to show it as "inactive Raid1" in such case.
>
> If it would be a raid1 when activated, it is still a raid1 when
> inactive: the data on disk doesn't suddenly become not a raid array
> simply because the kernel isn't able to access it right now. This is
> valuable information to expose to the sysadmin and should not be
> concealed (and *certainly* not described as a raid level it actually
> isn't).
>
> I think it should say as much (if the system knows at this stage, which
> if there is a device node, it presumably does).
>
Makes sense to me. I'll try to rewrite the patch.
Thanks for your share.
Regards,
Lidong
prev parent reply other threads:[~2020-09-12 15:03 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-08-26 15:16 [RFC PATCH] Detail: don't display the raid level when it's inactive Lidong Zhong
2020-08-28 16:38 ` Ian Pilcher
2020-08-31 1:28 ` Zhong Lidong
2020-08-31 19:00 ` Nix
2020-09-12 15:03 ` Zhong Lidong [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=0fb181ac-e6c4-45e4-d29d-19a98343fb82@suse.com \
--to=lidong.zhong@suse.com \
--cc=linux-raid@vger.kernel.org \
--cc=nix@esperi.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).