From: Lidong Zhong <lidong.zhong@suse.com>
To: jes@trained-monkey.org, linux-raid@vger.kernel.org
Cc: Lidong Zhong <lidong.zhong@suse.com>
Subject: [RFC PATCH] Detail: don't display the raid level when it's inactive
Date: Wed, 26 Aug 2020 23:16:58 +0800 [thread overview]
Message-ID: <20200826151658.3493-1-lidong.zhong@suse.com> (raw)
Sometimes the raid level in the output of `mdadm -D /dev/mdX` is
misleading when the array is in inactive state. Here is a testcase for
introduction.
1\ creating a raid1 device with two disks. Specify a different hostname
rather than the real one for later verfication.
node1:~ # mdadm --create /dev/md0 --homehost TESTARRAY -o -l 1 -n 2 /dev/sdb
/dev/sdc
2\ remove one of the devices and reboot
3\ show the detail of raid1 device
node1:~ # mdadm -D /dev/md127
/dev/md127:
Version : 1.2
Raid Level : raid0
Total Devices : 1
Persistence : Superblock is persistent
State : inactive
Working Devices : 1
You can see that the "Raid Level" in /dev/md127 is raid0 now.
After step 2\ is done, the degraded raid1 device is recognized
as a "foreign" array in 64-md-raid-assembly.rules. And thus the
timer to activate the raid1 device is not triggered. The array
level returned from GET_ARRAY_INFO ioctl is 0. And the string
shown for "Raid Level" is
str = map_num(pers, array.level);
And the definition of pers is
mapping_t pers[] = {
{ "linear", LEVEL_LINEAR},
{ "raid0", 0},
{ "0", 0}
...
So the misleading "raid0" is shown in this testcase. I think maybe
the "Raid Level" item shouldn't be displayed any more for the inactive
array.
Signed-off-by: Lidong Zhong <lidong.zhong@suse.com>
---
Detail.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/Detail.c b/Detail.c
index 24eeba0..9ac49e5 100644
--- a/Detail.c
+++ b/Detail.c
@@ -427,7 +427,7 @@ int Detail(char *dev, struct context *c)
printf(" Creation Time : %.24s\n", ctime(&atime));
if (is_container)
str = "container";
- if (str)
+ if (str && !inactive)
printf(" Raid Level : %s\n", str);
if (larray_size)
printf(" Array Size : %llu%s\n",
--
2.26.1
next reply other threads:[~2020-08-26 15:17 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-08-26 15:16 Lidong Zhong [this message]
2020-08-28 16:38 ` [RFC PATCH] Detail: don't display the raid level when it's inactive Ian Pilcher
2020-08-31 1:28 ` Zhong Lidong
2020-08-31 19:00 ` Nix
2020-09-12 15:03 ` Zhong Lidong
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200826151658.3493-1-lidong.zhong@suse.com \
--to=lidong.zhong@suse.com \
--cc=jes@trained-monkey.org \
--cc=linux-raid@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).