* [PATCH 1/1] IB/iser: use iser_err instead of pr_err for logging
@ 2019-10-06 12:56 Max Gurtovoy
2019-10-08 19:37 ` Jason Gunthorpe
0 siblings, 1 reply; 2+ messages in thread
From: Max Gurtovoy @ 2019-10-06 12:56 UTC (permalink / raw)
To: jgg, linux-rdma, dledford, leonro, sagi; +Cc: Max Gurtovoy
Make sure all the debug prints in ib_iser module use the common driver
logger.
Signed-off-by: Max Gurtovoy <maxg@mellanox.com>
---
drivers/infiniband/ulp/iser/iser_verbs.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/infiniband/ulp/iser/iser_verbs.c b/drivers/infiniband/ulp/iser/iser_verbs.c
index 94b5011..2531449 100644
--- a/drivers/infiniband/ulp/iser/iser_verbs.c
+++ b/drivers/infiniband/ulp/iser/iser_verbs.c
@@ -1081,7 +1081,7 @@ u8 iser_check_task_pi_status(struct iscsi_iser_task *iser_task,
ret = ib_check_mr_status(desc->rsc.sig_mr,
IB_MR_CHECK_SIG_STATUS, &mr_status);
if (ret) {
- pr_err("ib_check_mr_status failed, ret %d\n", ret);
+ iser_err("ib_check_mr_status failed, ret %d\n", ret);
/* Not a lot we can do, return ambiguous guard error */
*sector = 0;
return 0x1;
@@ -1093,7 +1093,7 @@ u8 iser_check_task_pi_status(struct iscsi_iser_task *iser_task,
sector_div(sector_off, sector_size + 8);
*sector = scsi_get_lba(iser_task->sc) + sector_off;
- pr_err("PI error found type %d at sector %llx "
+ iser_err("PI error found type %d at sector %llx "
"expected %x vs actual %x\n",
mr_status.sig_err.err_type,
(unsigned long long)*sector,
--
1.8.3.1
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH 1/1] IB/iser: use iser_err instead of pr_err for logging
2019-10-06 12:56 [PATCH 1/1] IB/iser: use iser_err instead of pr_err for logging Max Gurtovoy
@ 2019-10-08 19:37 ` Jason Gunthorpe
0 siblings, 0 replies; 2+ messages in thread
From: Jason Gunthorpe @ 2019-10-08 19:37 UTC (permalink / raw)
To: Max Gurtovoy; +Cc: linux-rdma, dledford, leonro, sagi
On Sun, Oct 06, 2019 at 03:56:20PM +0300, Max Gurtovoy wrote:
> Make sure all the debug prints in ib_iser module use the common driver
> logger.
>
> Signed-off-by: Max Gurtovoy <maxg@mellanox.com>
> ---
> drivers/infiniband/ulp/iser/iser_verbs.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
Applied to for-next, thanks
Jason
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2019-10-08 19:37 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-10-06 12:56 [PATCH 1/1] IB/iser: use iser_err instead of pr_err for logging Max Gurtovoy
2019-10-08 19:37 ` Jason Gunthorpe
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).