From: Jason Gunthorpe <jgg@ziepe.ca>
To: Andrew Murray <andrew.murray@arm.com>
Cc: Nicolas Saenz Julienne <nsaenzjulienne@suse.de>,
Heiko Stuebner <heiko@sntech.de>,
linux-pci@vger.kernel.org, Shawn Lin <shawn.lin@rock-chips.com>,
Christoph Hellwig <hch@lst.de>,
Marek Szyprowski <m.szyprowski@samsung.com>,
Lorenzo Pieralisi <lorenzo.pieralisi@arm.com>,
linux-rdma@vger.kernel.org, maz@kernel.org, phil@raspberrypi.org,
iommu@lists.linux-foundation.org,
linux-rockchip@lists.infradead.org, f.fainelli@gmail.com,
Bjorn Helgaas <bhelgaas@google.com>,
linux-arm-kernel@lists.infradead.org, mbrugger@suse.com,
netdev@vger.kernel.org, linux-kernel@vger.kernel.org,
jeremy.linton@arm.com, Tom Joseph <tjoseph@cadence.com>,
wahrenst@gmx.net, james.quinlan@broadcom.com,
Robin Murphy <robin.murphy@arm.com>,
"David S. Miller" <davem@davemloft.net>,
Tariq Toukan <tariqt@mellanox.com>
Subject: Re: [PATCH v2 1/6] linux/log2.h: Add roundup/rounddown_pow_two64() family of functions
Date: Tue, 19 Nov 2019 12:55:02 -0400 [thread overview]
Message-ID: <20191119165502.GB4991@ziepe.ca> (raw)
In-Reply-To: <20191119162849.GT43905@e119886-lin.cambridge.arm.com>
On Tue, Nov 19, 2019 at 04:28:50PM +0000, Andrew Murray wrote:
> On Tue, Nov 19, 2019 at 01:43:39PM +0100, Nicolas Saenz Julienne wrote:
> > On Tue, 2019-11-19 at 12:30 +0100, Nicolas Saenz Julienne wrote:
> > > Hi Andrew, thanks for the review.
> > > > > +/**
> > > > > + * __roundup_pow_of_two64() - round 64bit value up to nearest power of
> > > > > two
> > > > > + * @n: value to round up
> > > > > + */
> > > > > +static inline __attribute__((const)) __u64 __roundup_pow_of_two64(__u64
> > > > > n)
> > > >
> > > > To be consistent with other functions in the same file (__ilog_u64) you may
> > > > want to rename this to __roundup_pow_of_two_u64.
> > >
> > > Sounds good to me.
> > >
> > > > Also do you know why u64 is used in some places and __u64 in others?
> > >
> > > That's unwarranted, it should be __u64 everywhere.
> >
> > Sorry, now that I look deeper into it, it should be u64.
>
> Do you know the reason why? I'd be interested to know.
__u64 must be used in header files that are under uapi - ie it is the
name of the symbol in userspace, and u64 does not exist.
u64 should be used in all code that is only inside the kernel, ie .c
files, internal headers, etc
I routinely discourage use of __uXX in kernel native code.
Jason
next prev parent reply other threads:[~2019-11-19 16:55 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-11-12 15:59 [PATCH v2 0/6] Raspberry Pi 4 PCIe support Nicolas Saenz Julienne
2019-11-12 15:59 ` [PATCH v2 1/6] linux/log2.h: Add roundup/rounddown_pow_two64() family of functions Nicolas Saenz Julienne
2019-11-19 11:13 ` Andrew Murray
2019-11-19 11:30 ` Nicolas Saenz Julienne
2019-11-19 12:43 ` Nicolas Saenz Julienne
2019-11-19 16:28 ` Andrew Murray
2019-11-19 16:55 ` Jason Gunthorpe [this message]
2019-11-19 17:00 ` Andrew Murray
2019-11-19 11:18 ` [PATCH v2 0/6] Raspberry Pi 4 PCIe support Andrew Murray
2019-11-19 11:49 ` Nicolas Saenz Julienne
2019-11-21 12:18 ` Andrew Murray
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20191119165502.GB4991@ziepe.ca \
--to=jgg@ziepe.ca \
--cc=andrew.murray@arm.com \
--cc=bhelgaas@google.com \
--cc=davem@davemloft.net \
--cc=f.fainelli@gmail.com \
--cc=hch@lst.de \
--cc=heiko@sntech.de \
--cc=iommu@lists.linux-foundation.org \
--cc=james.quinlan@broadcom.com \
--cc=jeremy.linton@arm.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pci@vger.kernel.org \
--cc=linux-rdma@vger.kernel.org \
--cc=linux-rockchip@lists.infradead.org \
--cc=lorenzo.pieralisi@arm.com \
--cc=m.szyprowski@samsung.com \
--cc=maz@kernel.org \
--cc=mbrugger@suse.com \
--cc=netdev@vger.kernel.org \
--cc=nsaenzjulienne@suse.de \
--cc=phil@raspberrypi.org \
--cc=robin.murphy@arm.com \
--cc=shawn.lin@rock-chips.com \
--cc=tariqt@mellanox.com \
--cc=tjoseph@cadence.com \
--cc=wahrenst@gmx.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).