* [PATCH] RDMA/ucma: Use refcount_t for the ctx->ref
@ 2020-02-18 19:17 Jason Gunthorpe
2020-02-19 7:16 ` Leon Romanovsky
2020-02-19 20:41 ` Jason Gunthorpe
0 siblings, 2 replies; 3+ messages in thread
From: Jason Gunthorpe @ 2020-02-18 19:17 UTC (permalink / raw)
To: linux-rdma
Don't use an atomic as a refcount.
Signed-off-by: Jason Gunthorpe <jgg@mellanox.com>
---
drivers/infiniband/core/ucma.c | 10 +++++-----
1 file changed, 5 insertions(+), 5 deletions(-)
diff --git a/drivers/infiniband/core/ucma.c b/drivers/infiniband/core/ucma.c
index 57e68491a2fd6a..66ad29c672fce2 100644
--- a/drivers/infiniband/core/ucma.c
+++ b/drivers/infiniband/core/ucma.c
@@ -85,7 +85,7 @@ struct ucma_file {
struct ucma_context {
u32 id;
struct completion comp;
- atomic_t ref;
+ refcount_t ref;
int events_reported;
int backlog;
@@ -152,7 +152,7 @@ static struct ucma_context *ucma_get_ctx(struct ucma_file *file, int id)
if (ctx->closing)
ctx = ERR_PTR(-EIO);
else
- atomic_inc(&ctx->ref);
+ refcount_inc(&ctx->ref);
}
xa_unlock(&ctx_table);
return ctx;
@@ -160,7 +160,7 @@ static struct ucma_context *ucma_get_ctx(struct ucma_file *file, int id)
static void ucma_put_ctx(struct ucma_context *ctx)
{
- if (atomic_dec_and_test(&ctx->ref))
+ if (refcount_dec_and_test(&ctx->ref))
complete(&ctx->comp);
}
@@ -212,7 +212,7 @@ static struct ucma_context *ucma_alloc_ctx(struct ucma_file *file)
return NULL;
INIT_WORK(&ctx->close_work, ucma_close_id);
- atomic_set(&ctx->ref, 1);
+ refcount_set(&ctx->ref, 1);
init_completion(&ctx->comp);
INIT_LIST_HEAD(&ctx->mc_list);
ctx->file = file;
@@ -1502,7 +1502,7 @@ static ssize_t ucma_leave_multicast(struct ucma_file *file,
mc = ERR_PTR(-ENOENT);
else if (mc->ctx->file != file)
mc = ERR_PTR(-EINVAL);
- else if (!atomic_inc_not_zero(&mc->ctx->ref))
+ else if (!refcount_inc_not_zero(&mc->ctx->ref))
mc = ERR_PTR(-ENXIO);
else
__xa_erase(&multicast_table, mc->id);
--
2.25.0
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] RDMA/ucma: Use refcount_t for the ctx->ref
2020-02-18 19:17 [PATCH] RDMA/ucma: Use refcount_t for the ctx->ref Jason Gunthorpe
@ 2020-02-19 7:16 ` Leon Romanovsky
2020-02-19 20:41 ` Jason Gunthorpe
1 sibling, 0 replies; 3+ messages in thread
From: Leon Romanovsky @ 2020-02-19 7:16 UTC (permalink / raw)
To: Jason Gunthorpe; +Cc: linux-rdma
On Tue, Feb 18, 2020 at 07:17:00PM +0000, Jason Gunthorpe wrote:
> Don't use an atomic as a refcount.
>
> Signed-off-by: Jason Gunthorpe <jgg@mellanox.com>
> ---
> drivers/infiniband/core/ucma.c | 10 +++++-----
> 1 file changed, 5 insertions(+), 5 deletions(-)
>
Thanks,
Reviewed-by: Leon Romanovsky <leonro@mellanox.com>
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] RDMA/ucma: Use refcount_t for the ctx->ref
2020-02-18 19:17 [PATCH] RDMA/ucma: Use refcount_t for the ctx->ref Jason Gunthorpe
2020-02-19 7:16 ` Leon Romanovsky
@ 2020-02-19 20:41 ` Jason Gunthorpe
1 sibling, 0 replies; 3+ messages in thread
From: Jason Gunthorpe @ 2020-02-19 20:41 UTC (permalink / raw)
To: linux-rdma
On Tue, Feb 18, 2020 at 07:17:00PM +0000, Jason Gunthorpe wrote:
> Don't use an atomic as a refcount.
>
> Signed-off-by: Jason Gunthorpe <jgg@mellanox.com>
> Reviewed-by: Leon Romanovsky <leonro@mellanox.com>
> ---
> drivers/infiniband/core/ucma.c | 10 +++++-----
> 1 file changed, 5 insertions(+), 5 deletions(-)
Applied
Jason
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2020-02-19 20:41 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-02-18 19:17 [PATCH] RDMA/ucma: Use refcount_t for the ctx->ref Jason Gunthorpe
2020-02-19 7:16 ` Leon Romanovsky
2020-02-19 20:41 ` Jason Gunthorpe
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).