linux-rdma.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* [PATCH] RDMA/core: Clean up tracepoint headers
@ 2020-07-02 14:19 Chuck Lever
  2020-07-05 13:23 ` Leon Romanovsky
  2020-07-06 22:13 ` Jason Gunthorpe
  0 siblings, 2 replies; 3+ messages in thread
From: Chuck Lever @ 2020-07-02 14:19 UTC (permalink / raw)
  To: linux-rdma

There's no need for core/trace.c to include rdma/ib_verbs.h twice.

Signed-off-by: Chuck Lever <chuck.lever@oracle.com>
---
 drivers/infiniband/core/trace.c |    2 --
 1 file changed, 2 deletions(-)

diff --git a/drivers/infiniband/core/trace.c b/drivers/infiniband/core/trace.c
index 6c3514beac4d..31e7860d35bf 100644
--- a/drivers/infiniband/core/trace.c
+++ b/drivers/infiniband/core/trace.c
@@ -9,6 +9,4 @@
 
 #define CREATE_TRACE_POINTS
 
-#include <rdma/ib_verbs.h>
-
 #include <trace/events/rdma_core.h>


^ permalink raw reply related	[flat|nested] 3+ messages in thread

* Re: [PATCH] RDMA/core: Clean up tracepoint headers
  2020-07-02 14:19 [PATCH] RDMA/core: Clean up tracepoint headers Chuck Lever
@ 2020-07-05 13:23 ` Leon Romanovsky
  2020-07-06 22:13 ` Jason Gunthorpe
  1 sibling, 0 replies; 3+ messages in thread
From: Leon Romanovsky @ 2020-07-05 13:23 UTC (permalink / raw)
  To: Chuck Lever; +Cc: linux-rdma

On Thu, Jul 02, 2020 at 10:19:46AM -0400, Chuck Lever wrote:
> There's no need for core/trace.c to include rdma/ib_verbs.h twice.
>
> Signed-off-by: Chuck Lever <chuck.lever@oracle.com>
> ---
>  drivers/infiniband/core/trace.c |    2 --
>  1 file changed, 2 deletions(-)
>

Thanks,
Reviewed-by: Leon Romanovsky <leonro@mellanox.com>

Off-topic,
we have total mess of includes ... in drivers/infiniband/*.

^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [PATCH] RDMA/core: Clean up tracepoint headers
  2020-07-02 14:19 [PATCH] RDMA/core: Clean up tracepoint headers Chuck Lever
  2020-07-05 13:23 ` Leon Romanovsky
@ 2020-07-06 22:13 ` Jason Gunthorpe
  1 sibling, 0 replies; 3+ messages in thread
From: Jason Gunthorpe @ 2020-07-06 22:13 UTC (permalink / raw)
  To: Chuck Lever; +Cc: linux-rdma

On Thu, Jul 02, 2020 at 10:19:46AM -0400, Chuck Lever wrote:
> There's no need for core/trace.c to include rdma/ib_verbs.h twice.
> 
> Signed-off-by: Chuck Lever <chuck.lever@oracle.com>
> Reviewed-by: Leon Romanovsky <leonro@mellanox.com>
> ---
>  drivers/infiniband/core/trace.c |    2 --
>  1 file changed, 2 deletions(-)

Applied to for-next, thanks

Jason

^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2020-07-06 22:13 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-07-02 14:19 [PATCH] RDMA/core: Clean up tracepoint headers Chuck Lever
2020-07-05 13:23 ` Leon Romanovsky
2020-07-06 22:13 ` Jason Gunthorpe

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).