From: Ben Levinsky <BLEVINSK@xilinx.com>
To: Rob Herring <robh@kernel.org>
Cc: "ohad@wizery.com" <ohad@wizery.com>,
"bjorn.andersson@linaro.org" <bjorn.andersson@linaro.org>,
Michal Simek <michals@xilinx.com>, Jolly Shah <JOLLYS@xilinx.com>,
Rajan Vaja <RAJANV@xilinx.com>,
"robh+dt@kernel.org" <robh+dt@kernel.org>,
"mark.rutland@arm.com" <mark.rutland@arm.com>,
"linux-remoteproc@vger.kernel.org"
<linux-remoteproc@vger.kernel.org>,
"linux-arm-kernel@lists.infradead.org"
<linux-arm-kernel@lists.infradead.org>,
"devicetree@vger.kernel.org" <devicetree@vger.kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
Jiaying Liang <jliang@xilinx.com>,
"Ed T. Mooring" <emooring@xilinx.com>
Subject: RE: [PATCH v3 4/5] dt-bindings: remoteproc: Add documentation for ZynqMP R5 rproc bindings
Date: Wed, 22 Apr 2020 20:29:41 +0000 [thread overview]
Message-ID: <BYAPR02MB4856EDC95308C0F91C4413C7B5D20@BYAPR02MB4856.namprd02.prod.outlook.com> (raw)
Message-ID: <20200422202941.Ep8S0aru3mbpyXRqcKmARHbSbQ18lBUNnclTP8bYTlU@z> (raw)
In-Reply-To: <20200422193819.GA1685@bogus>
Hi Rob,
Please see my replies inline.
Best Regards
Ben
-----Original Message-----
From: Rob Herring <robh@kernel.org>
Sent: Wednesday, April 22, 2020 12:38 PM
To: Ben Levinsky <BLEVINSK@xilinx.com>
Cc: ohad@wizery.com; bjorn.andersson@linaro.org; Michal Simek <michals@xilinx.com>; Jolly Shah <JOLLYS@xilinx.com>; Rajan Vaja <RAJANV@xilinx.com>; robh+dt@kernel.org; mark.rutland@arm.com; linux-remoteproc@vger.kernel.org; linux-arm-kernel@lists.infradead.org; devicetree@vger.kernel.org; linux-kernel@vger.kernel.org; Jason Wu <j.wu@xilinx.com>; Jiaying Liang <jliang@xilinx.com>
Subject: Re: [PATCH v3 4/5] dt-bindings: remoteproc: Add documentation for ZynqMP R5 rproc bindings
On Mon, 20 Apr 2020 15:27:08 -0700, Ben Levinsky wrote:
> Add binding for ZynqMP R5 OpenAMP.
>
> Represent the RPU domain resources in one device node. Each RPU
> processor is a subnode of the top RPU domain node.
>
> Signed-off-by: Ben Levinsky <ben.levinsky@xilinx.com>
> Signed-off-by: Jason Wu <j.wu@xilinx.com>
> Signed-off-by: Wendy Liang <jliang@xilinx.com>
> Signed-off-by: Michal Simek <michal.simek@xilinx.com>
> ---
> Changes since v2:
> - update zynqmp_r5 yaml parsing to not raise warnings for extra
> information in children of R5 node. The warning "node has a unit
> name, but no reg or ranges property" will still be raised though
> as this particular node is needed to describe the
> '#address-cells' and '#size-cells' information.
> ---
> .../remoteproc/xilinx,zynqmp-r5-remoteproc.yaml | 126 +++++++++++++++++++++
> 1 file changed, 126 insertions(+)
> create mode 100644
> Documentation/devicetree/bindings/remoteproc/xilinx,zynqmp-r5-remotepr
> oc.yaml
>
My bot found errors running 'make dt_binding_check' on your patch:
Documentation/devicetree/bindings/remoteproc/xilinx,zynqmp-r5-remoteproc.example.dts:45.25-65.16: Warning (unit_address_vs_reg): /example-0/rpu@ff9a0000/r5@0: node has a unit name, but no reg or ranges property
[Ben Levinsky] Yes the following warning is expected. As the node in question has to describe the address-cells and size-cells. As these are needed for its children to then also have address-cells, size-cells and reg values without raising more warnings.
See https://patchwork.ozlabs.org/patch/1273784
If you already ran 'make dt_binding_check' and didn't see the above error(s), then make sure dt-schema is up to date:
pip3 install git+https://github.com/devicetree-org/dt-schema.git@master --upgrade
Please check and re-submit.
next prev parent reply other threads:[~2020-04-22 20:29 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-04-20 22:27 [PATCH v3 0/5] remoteproc: Add zynqmp_r5 driver Ben Levinsky
2020-04-20 22:27 ` Ben Levinsky
2020-04-20 22:27 ` [PATCH v3 1/5] firmware: xilinx: Add ZynqMP firmware ioctl enums for RPU configuration Ben Levinsky
2020-04-20 22:27 ` Ben Levinsky
2020-04-21 5:49 ` Michal Simek
2020-04-21 5:49 ` Michal Simek
2020-04-20 22:27 ` [PATCH v3 2/5] firmware: xilinx: Add shutdown/wakeup APIs Ben Levinsky
2020-04-20 22:27 ` Ben Levinsky
2020-04-21 5:57 ` Michal Simek
2020-04-21 5:57 ` Michal Simek
2020-04-20 22:27 ` [PATCH v3 3/5] firmware: xilinx: Add RPU configuration APIs Ben Levinsky
2020-04-20 22:27 ` Ben Levinsky
2020-04-21 5:59 ` Michal Simek
2020-04-21 5:59 ` Michal Simek
2020-04-20 22:27 ` [PATCH v3 4/5] dt-bindings: remoteproc: Add documentation for ZynqMP R5 rproc bindings Ben Levinsky
2020-04-20 22:27 ` Ben Levinsky
2020-04-22 19:38 ` Rob Herring
2020-04-22 19:38 ` Rob Herring
2020-04-22 20:29 ` Ben Levinsky [this message]
2020-04-22 20:29 ` Ben Levinsky
2020-04-20 22:27 ` [PATCH v3 5/5] remoteproc: Add initial zynqmp R5 remoteproc driver Ben Levinsky
2020-04-20 22:27 ` Ben Levinsky
2020-04-21 5:57 ` [PATCH v3 0/5] remoteproc: Add zynqmp_r5 driver Michal Simek
2020-04-21 5:57 ` Michal Simek
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=BYAPR02MB4856EDC95308C0F91C4413C7B5D20@BYAPR02MB4856.namprd02.prod.outlook.com \
--to=blevinsk@xilinx.com \
--cc=JOLLYS@xilinx.com \
--cc=RAJANV@xilinx.com \
--cc=bjorn.andersson@linaro.org \
--cc=devicetree@vger.kernel.org \
--cc=emooring@xilinx.com \
--cc=jliang@xilinx.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-remoteproc@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=michals@xilinx.com \
--cc=ohad@wizery.com \
--cc=robh+dt@kernel.org \
--cc=robh@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).