* [PATCH] drivers: remoteproc: xlnx: fix uninitialize variable use
@ 2024-04-23 17:02 Tanmay Shah
2024-04-23 19:32 ` Mathieu Poirier
0 siblings, 1 reply; 2+ messages in thread
From: Tanmay Shah @ 2024-04-23 17:02 UTC (permalink / raw)
To: andersson, mathieu.poirier, nathan, ndesaulniers, morbo,
justinstitt, tanmay.shah
Cc: linux-remoteproc, linux-kernel, llvm, kernel test robot
Fix following warning for clang compiler with W=1 option:
initialize the variable 'ret' to silence this warning
907 | int ret, i;
| ^
| = 0
Fixes: a6b974b40f94 ("drivers: remoteproc: xlnx: Add Versal and Versal-NET support")
Reported-by: kernel test robot <lkp@intel.com>
Closes: https://lore.kernel.org/oe-kbuild-all/202404231839.oHiY9Lw8-lkp@intel.com/
Signed-off-by: Tanmay Shah <tanmay.shah@amd.com>
---
drivers/remoteproc/xlnx_r5_remoteproc.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/remoteproc/xlnx_r5_remoteproc.c b/drivers/remoteproc/xlnx_r5_remoteproc.c
index a6d8ac7394e7..d98940d7ef8f 100644
--- a/drivers/remoteproc/xlnx_r5_remoteproc.c
+++ b/drivers/remoteproc/xlnx_r5_remoteproc.c
@@ -904,7 +904,7 @@ static int zynqmp_r5_core_init(struct zynqmp_r5_cluster *cluster,
{
struct device *dev = cluster->dev;
struct zynqmp_r5_core *r5_core;
- int ret, i;
+ int ret = -EINVAL, i;
r5_core = cluster->r5_cores[0];
base-commit: e99fcac055b3325283d6c5c61a117651fb147686
--
2.25.1
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] drivers: remoteproc: xlnx: fix uninitialize variable use
2024-04-23 17:02 [PATCH] drivers: remoteproc: xlnx: fix uninitialize variable use Tanmay Shah
@ 2024-04-23 19:32 ` Mathieu Poirier
0 siblings, 0 replies; 2+ messages in thread
From: Mathieu Poirier @ 2024-04-23 19:32 UTC (permalink / raw)
To: Tanmay Shah
Cc: andersson, nathan, ndesaulniers, morbo, justinstitt,
linux-remoteproc, linux-kernel, llvm, kernel test robot
On Tue, Apr 23, 2024 at 10:02:11AM -0700, Tanmay Shah wrote:
> Fix following warning for clang compiler with W=1 option:
> initialize the variable 'ret' to silence this warning
> 907 | int ret, i;
> | ^
> | = 0
>
> Fixes: a6b974b40f94 ("drivers: remoteproc: xlnx: Add Versal and Versal-NET support")
> Reported-by: kernel test robot <lkp@intel.com>
> Closes: https://lore.kernel.org/oe-kbuild-all/202404231839.oHiY9Lw8-lkp@intel.com/
> Signed-off-by: Tanmay Shah <tanmay.shah@amd.com>
> ---
> drivers/remoteproc/xlnx_r5_remoteproc.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/remoteproc/xlnx_r5_remoteproc.c b/drivers/remoteproc/xlnx_r5_remoteproc.c
> index a6d8ac7394e7..d98940d7ef8f 100644
> --- a/drivers/remoteproc/xlnx_r5_remoteproc.c
> +++ b/drivers/remoteproc/xlnx_r5_remoteproc.c
> @@ -904,7 +904,7 @@ static int zynqmp_r5_core_init(struct zynqmp_r5_cluster *cluster,
> {
> struct device *dev = cluster->dev;
> struct zynqmp_r5_core *r5_core;
> - int ret, i;
> + int ret = -EINVAL, i;
>
Applied - thanks,
Mathieu
> r5_core = cluster->r5_cores[0];
>
>
> base-commit: e99fcac055b3325283d6c5c61a117651fb147686
> --
> 2.25.1
>
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2024-04-23 19:32 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2024-04-23 17:02 [PATCH] drivers: remoteproc: xlnx: fix uninitialize variable use Tanmay Shah
2024-04-23 19:32 ` Mathieu Poirier
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).