From: Marek Vasut <marek.vasut@gmail.com>
To: Geert Uytterhoeven <geert@linux-m68k.org>
Cc: linux-pci <linux-pci@vger.kernel.org>,
Marek Vasut <marek.vasut+renesas@gmail.com>,
Geert Uytterhoeven <geert+renesas@glider.be>,
Phil Edworthy <phil.edworthy@renesas.com>,
Simon Horman <horms+renesas@verge.net.au>,
Wolfram Sang <wsa@the-dreams.de>,
Linux-Renesas <linux-renesas-soc@vger.kernel.org>
Subject: Re: [PATCH 2/3] PCI: rcar: Allow 64bit MSI addresses
Date: Fri, 22 Mar 2019 03:30:13 +0100 [thread overview]
Message-ID: <0fdfb018-23d9-e557-d413-10d8d5d72663@gmail.com> (raw)
In-Reply-To: <CAMuHMdV0fUV8De4QGq9Jjaepic06nVVby8p3W6DYr9X9MqM+Jw@mail.gmail.com>
On 3/18/19 9:35 AM, Geert Uytterhoeven wrote:
> On Sun, Mar 17, 2019 at 1:06 AM <marek.vasut@gmail.com> wrote:
>> From: Marek Vasut <marek.vasut+renesas@gmail.com>
>>
>> The MSI address can be 64bit. Switch the data type used to hold the
>> result of virt_to_phys() to phys_addr_t to reflect it's properties
>
> Side note: probably this should use a proper DMA API instead of
> get_free_pages()/virt_to_phys().
In fact, I think it doesn't matter. The MSI message is never written
into this page as an actual memory write, it is interpreted by the
hardware as an interrupt when it arrives. So I believe this page is just
a safety net, which is never actually written.
>> correctly and program the top 32bits of PA into PCIEMSIAUR.
>>
>> Signed-off-by: Marek Vasut <marek.vasut+renesas@gmail.com>
[...]
--
Best regards,
Marek Vasut
next prev parent reply other threads:[~2019-03-22 2:31 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-03-17 0:06 [PATCH 1/3] PCI: rcar: Replace unsigned long with u32 for register values marek.vasut
2019-03-17 0:06 ` [PATCH 2/3] PCI: rcar: Allow 64bit MSI addresses marek.vasut
2019-03-17 8:03 ` Sergei Shtylyov
2019-03-17 22:59 ` Marek Vasut
2019-03-17 9:12 ` Wolfram Sang
2019-03-17 23:37 ` Marek Vasut
2019-03-18 8:39 ` Geert Uytterhoeven
2019-03-18 9:30 ` Geert Uytterhoeven
2019-03-19 1:16 ` Marek Vasut
2019-03-18 8:35 ` Geert Uytterhoeven
2019-03-22 2:30 ` Marek Vasut [this message]
2019-03-17 0:06 ` [PATCH 3/3] PCI: rcar: Clean up debug messages marek.vasut
2019-03-17 9:15 ` Wolfram Sang
2019-03-18 8:20 ` Geert Uytterhoeven
2019-03-17 9:09 ` [PATCH 1/3] PCI: rcar: Replace unsigned long with u32 for register values Wolfram Sang
2019-03-17 22:58 ` Marek Vasut
2019-03-18 7:33 ` Wolfram Sang
2019-03-18 8:47 ` Geert Uytterhoeven
2019-03-21 3:25 ` Marek Vasut
2019-03-21 7:31 ` Geert Uytterhoeven
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=0fdfb018-23d9-e557-d413-10d8d5d72663@gmail.com \
--to=marek.vasut@gmail.com \
--cc=geert+renesas@glider.be \
--cc=geert@linux-m68k.org \
--cc=horms+renesas@verge.net.au \
--cc=linux-pci@vger.kernel.org \
--cc=linux-renesas-soc@vger.kernel.org \
--cc=marek.vasut+renesas@gmail.com \
--cc=phil.edworthy@renesas.com \
--cc=wsa@the-dreams.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).