From: Marek Vasut <marek.vasut@gmail.com>
To: Wolfram Sang <wsa@the-dreams.de>
Cc: linux-pci@vger.kernel.org,
Marek Vasut <marek.vasut+renesas@gmail.com>,
Geert Uytterhoeven <geert+renesas@glider.be>,
Phil Edworthy <phil.edworthy@renesas.com>,
Simon Horman <horms+renesas@verge.net.au>,
linux-renesas-soc@vger.kernel.org
Subject: Re: [PATCH 2/3] PCI: rcar: Allow 64bit MSI addresses
Date: Mon, 18 Mar 2019 00:37:07 +0100 [thread overview]
Message-ID: <940fd646-0049-890a-ac00-8bc9361b2431@gmail.com> (raw)
In-Reply-To: <20190317091228.GB2268@kunai>
On 3/17/19 10:12 AM, Wolfram Sang wrote:
> On Sun, Mar 17, 2019 at 01:06:07AM +0100, marek.vasut@gmail.com wrote:
>> From: Marek Vasut <marek.vasut+renesas@gmail.com>
>>
>> The MSI address can be 64bit. Switch the data type used to hold the
>> result of virt_to_phys() to phys_addr_t to reflect it's properties
>> correctly and program the top 32bits of PA into PCIEMSIAUR.
>>
>> Signed-off-by: Marek Vasut <marek.vasut+renesas@gmail.com>
>
> Looks sane. Not being a PCI expert, I wonder: Were we just lucky to not
> hit a 64-bit MSI address before?
I wonder about that, virt_to_phys(__get_free_pages(GFP_KERNEL, 0)) would
happily return 64bit address, but with the cards I tested (a few intel
NICs [igb, e1000e], PCIe NVME SSDs and xHCI HCD), I am getting the MSIs
either way.
> Is this tied to our 32-bit limitation?
This might be a question for the HW team. I would be tempted to
cautiously say yes.
--
Best regards,
Marek Vasut
next prev parent reply other threads:[~2019-03-17 23:39 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-03-17 0:06 [PATCH 1/3] PCI: rcar: Replace unsigned long with u32 for register values marek.vasut
2019-03-17 0:06 ` [PATCH 2/3] PCI: rcar: Allow 64bit MSI addresses marek.vasut
2019-03-17 8:03 ` Sergei Shtylyov
2019-03-17 22:59 ` Marek Vasut
2019-03-17 9:12 ` Wolfram Sang
2019-03-17 23:37 ` Marek Vasut [this message]
2019-03-18 8:39 ` Geert Uytterhoeven
2019-03-18 9:30 ` Geert Uytterhoeven
2019-03-19 1:16 ` Marek Vasut
2019-03-18 8:35 ` Geert Uytterhoeven
2019-03-22 2:30 ` Marek Vasut
2019-03-17 0:06 ` [PATCH 3/3] PCI: rcar: Clean up debug messages marek.vasut
2019-03-17 9:15 ` Wolfram Sang
2019-03-18 8:20 ` Geert Uytterhoeven
2019-03-17 9:09 ` [PATCH 1/3] PCI: rcar: Replace unsigned long with u32 for register values Wolfram Sang
2019-03-17 22:58 ` Marek Vasut
2019-03-18 7:33 ` Wolfram Sang
2019-03-18 8:47 ` Geert Uytterhoeven
2019-03-21 3:25 ` Marek Vasut
2019-03-21 7:31 ` Geert Uytterhoeven
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=940fd646-0049-890a-ac00-8bc9361b2431@gmail.com \
--to=marek.vasut@gmail.com \
--cc=geert+renesas@glider.be \
--cc=horms+renesas@verge.net.au \
--cc=linux-pci@vger.kernel.org \
--cc=linux-renesas-soc@vger.kernel.org \
--cc=marek.vasut+renesas@gmail.com \
--cc=phil.edworthy@renesas.com \
--cc=wsa@the-dreams.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).