From: Marek Vasut <marek.vasut@gmail.com>
To: Bjorn Helgaas <helgaas@kernel.org>
Cc: linux-pci@vger.kernel.org, Bjorn Helgaas <bhelgaas@google.com>,
Geert Uytterhoeven <geert+renesas@glider.be>,
Lorenzo Pieralisi <lorenzo.pieralisi@arm.com>,
Wolfram Sang <wsa@the-dreams.de>,
Yoshihiro Shimoda <yoshihiro.shimoda.uh@renesas.com>,
linux-renesas-soc@vger.kernel.org
Subject: Re: [PATCH V6] PCI: rcar: Add L1 link state fix into data abort hook
Date: Sat, 17 Jul 2021 20:14:14 +0200 [thread overview]
Message-ID: <19265a67-20e0-f049-ee75-6ce3caa184ad@gmail.com> (raw)
In-Reply-To: <20210717173334.GA2232818@bjorn-Precision-5520>
On 7/17/21 7:33 PM, Bjorn Helgaas wrote:
[...]
>> Note that this fixup is applicable only to Aarch32 R-Car controllers,
>> the Aarch64 R-Car perform the same fixup in TFA, see TFA commit [1]
>> 0969397f2 ("rcar_gen3: plat: Prevent PCIe hang during L1X config access")
>> [1] https://github.com/ARM-software/arm-trusted-firmware/commit/0969397f295621aa26b3d14b76dd397d22be58bf
>
> This patch is horribly ugly but it's working around a horrible
> hardware problem, and I don't have any better suggestions, so I guess
> we don't really have much choice.
>
> I do think the commit log is a bit glib:
Should I reword the commit message one more time and send V7 ?
> - "The R-Car PCIe controller is capable of handling L0s/L1 link
> states." AFAICT every PCIe device is required to handle L0 and L1
> without software assistance. So saying R-Car is "capable" puts a
> better face on this than seems warranted.
>
> L0s doesn't seem relevant at all; at least it doesn't seem to play
> a role in the patch. There's no such thing as "returning to L0s"
> as mentioned in the comment below; L0s is only reachable from L0.
> Returns from L1 only go to L0 (PCIe r5.0, fig 5-1).
>
> - "The problem is, this transition is not atomic." I think the
> *problem* is the hardware is broken in the first place. This
> transition is supposed to be invisible to software.
>
> - "Just like other PCI controller drivers ..." suggests that this is
> an ordinary situation that we shouldn't be concerned about. This
> patch may be the best we can do to work around a bad hardware
> defect, but it's definitely not ordinary.
>
> I think the other hook_fault_code() uses are for reporting
> legitimate PCIe errors, which most controllers log and turn
> into ~0 data responses without generating an abort or machine
> check, not things caused by hardware defects, so they're not
> really comparable.
>
> Has Renesas documented this as an erratum?
They are aware of this.
> Will future devices
> require additions to rcar_pcie_abort_handler_of_match[]?
No, this change is for legacy arm32 SoCs only.
> It'd be nice if the commit log mentioned the user-visible effect of
> this problem. I guess it does mention external aborts -- I assume you
> see those when downstream devices go to D3hot or when ASPM puts the
> link in L1? And the abort results in a reboot?
It results in a hang.
> To be clear, I'm not objecting to the patch. It's a hardware problem
> and we should work around it as best we can.
[...]
next prev parent reply other threads:[~2021-07-17 18:16 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-05-14 20:05 [PATCH V6] PCI: rcar: Add L1 link state fix into data abort hook marek.vasut
2021-05-17 7:39 ` Geert Uytterhoeven
2021-07-17 17:33 ` Bjorn Helgaas
2021-07-17 18:14 ` Marek Vasut [this message]
2021-07-19 8:59 ` Lorenzo Pieralisi
2021-07-19 15:38 ` Marek Vasut
2021-07-19 17:23 ` Pali Rohár
2021-07-19 18:39 ` Marek Vasut
2021-07-22 20:31 ` Pali Rohár
2021-07-19 22:06 ` Bjorn Helgaas
2021-07-27 16:11 ` Lorenzo Pieralisi
2021-07-27 16:16 ` Geert Uytterhoeven
2021-07-26 14:47 ` Geert Uytterhoeven
2021-07-26 17:49 ` Bjorn Helgaas
2021-07-27 16:32 ` Lorenzo Pieralisi
2021-08-05 18:30 ` Pali Rohár
2021-07-27 17:08 ` Marek Vasut
2021-08-04 11:06 ` Lorenzo Pieralisi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=19265a67-20e0-f049-ee75-6ce3caa184ad@gmail.com \
--to=marek.vasut@gmail.com \
--cc=bhelgaas@google.com \
--cc=geert+renesas@glider.be \
--cc=helgaas@kernel.org \
--cc=linux-pci@vger.kernel.org \
--cc=linux-renesas-soc@vger.kernel.org \
--cc=lorenzo.pieralisi@arm.com \
--cc=wsa@the-dreams.de \
--cc=yoshihiro.shimoda.uh@renesas.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).