From: Mark Brown <broonie@kernel.org>
To: Nguyen An Hoan <na-hoan@jinso.co.jp>
Cc: linux-renesas-soc@vger.kernel.org, geert+renesas@glider.be,
magnus.damm@gmail.com, linux-spi@vger.kernel.org,
kuninori.morimoto.gx@renesas.com,
yoshihiro.shimoda.uh@renesas.com, h-inayoshi@jinso.co.jp,
nv-dung@jinso.co.jp, cv-dong@jinso.co.jp
Subject: Re: [PATCH 1/2] spi: sh-msiof: fix *info pointer in request_dma()
Date: Fri, 11 Jan 2019 13:26:08 +0000 [thread overview]
Message-ID: <20190111132608.GD2804@sirena.org.uk> (raw)
In-Reply-To: <1547197109-637-1-git-send-email-na-hoan@jinso.co.jp>
[-- Attachment #1: Type: text/plain, Size: 307 bytes --]
On Fri, Jan 11, 2019 at 05:58:28PM +0900, Nguyen An Hoan wrote:
> From: Hoan Nguyen An <na-hoan@jinso.co.jp>
>
> msiof_spi_infor struct pointer was initialized in the probe() function,
> no need to get back and keep consistency.
These look good to me with the changes Geert and Sergei pointed out.
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
prev parent reply other threads:[~2019-01-11 13:26 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-01-11 8:58 [PATCH 1/2] spi: sh-msiof: fix *info pointer in request_dma() Nguyen An Hoan
2019-01-11 8:58 ` [PATCH 2/2] spi: sh-msiof: Use DMA if possible Nguyen An Hoan
2019-01-11 9:09 ` Geert Uytterhoeven
2019-01-11 9:27 ` Hoan
2019-01-11 10:05 ` Geert Uytterhoeven
2019-01-18 8:19 ` Hoan
2019-01-11 9:01 ` [PATCH 1/2] spi: sh-msiof: fix *info pointer in request_dma() Geert Uytterhoeven
2019-01-11 10:15 ` Sergei Shtylyov
2019-01-11 13:26 ` Mark Brown [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190111132608.GD2804@sirena.org.uk \
--to=broonie@kernel.org \
--cc=cv-dong@jinso.co.jp \
--cc=geert+renesas@glider.be \
--cc=h-inayoshi@jinso.co.jp \
--cc=kuninori.morimoto.gx@renesas.com \
--cc=linux-renesas-soc@vger.kernel.org \
--cc=linux-spi@vger.kernel.org \
--cc=magnus.damm@gmail.com \
--cc=na-hoan@jinso.co.jp \
--cc=nv-dung@jinso.co.jp \
--cc=yoshihiro.shimoda.uh@renesas.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).