Re: [PATCH 1/2] spi: sh-msiof: fix *info pointer in request_dma()

[Geert Uytterhoeven <geert@linux-m68k.org>]

Hi Hoan-san,

On Fri, Jan 11, 2019 at 9:59 AM Nguyen An Hoan <na-hoan@jinso.co.jp> wrote:
> From: Hoan Nguyen An <na-hoan@jinso.co.jp>
>
> msiof_spi_infor struct pointer was initialized in the probe() function,
> no need to get back and keep consistency.
>
> Signed-off-by: Hoan Nguyen An <na-hoan@jinso.co.jp>

Thanks for your patch!

Reviewed-by: Geert Uytterhoeven <geert+renesas@glider.be>
One nit below.

> --- a/drivers/spi/spi-sh-msiof.c
> +++ b/drivers/spi/spi-sh-msiof.c
> @@ -1206,7 +1206,7 @@ static int sh_msiof_request_dma(struct sh_msiof_spi_priv *p)
>  {
>         struct platform_device *pdev = p->pdev;
>         struct device *dev = &pdev->dev;
> -       const struct sh_msiof_spi_info *info = dev_get_platdata(dev);
> +       const struct sh_msiof_spi_info *info = p->info;
>         unsigned int dma_tx_id, dma_rx_id;
>         const struct resource *res;
>         struct spi_master *master;
> @@ -1469,3 +1469,4 @@ MODULE_DESCRIPTION("SuperH MSIOF SPI Master Interface Driver");
>  MODULE_AUTHOR("Magnus Damm");
>  MODULE_LICENSE("GPL v2");
>  MODULE_ALIAS("platform:spi_sh_msiof");
> +

This change is unrelated, please drop it.

Gr{oetje,eeting}s,

                        Geert

-- 
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
                                -- Linus Torvalds