[PATCH] pinctrl: sh-pfc: r8a7778: Fix HSPI pin numbers and names

[PATCH] pinctrl: sh-pfc: r8a7778: Fix HSPI pin numbers and names

[Geert Uytterhoeven]

When declaring the HSPI RX1_B and TX1_B pins, two mistakes were made:
  - the rows and columns in the BGA pin matrix, from which the pin
    numbers are derived, were exchanged,
  - it was not taken into account that BGA pin row labelling skips
    characters I, O, Q, and S.

Fix the order, and the corresponding pin names.

Notes:
  - The actual values of the pin numbers don't really matter (they just
    have to be unique), so the wrong order didn't have any impact,
  - Changing the names of the pins is user-visible, but there are no
    users in (upstream) DTS files.

Fixes: 4f82e3ee724f1712 ("sh-pfc: Support pins not associated with a GPIO port")
Fixes: 09cc76a95802e87d ("sh-pfc: r8a7778: add HSPI pin groups")
Signed-off-by: Geert Uytterhoeven <geert+renesas@glider.be>
---
To be queued in sh-pfc-for-v5.1.

 drivers/pinctrl/sh-pfc/pfc-r8a7778.c | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

diff --git a/drivers/pinctrl/sh-pfc/pfc-r8a7778.c b/drivers/pinctrl/sh-pfc/pfc-r8a7778.c
index 6bcdb4b5e69e7ff1..068b5e6334d148d4 100644
--- a/drivers/pinctrl/sh-pfc/pfc-r8a7778.c
+++ b/drivers/pinctrl/sh-pfc/pfc-r8a7778.c
@@ -1264,8 +1264,8 @@ static const struct sh_pfc_pin pinmux_pins[] = {
 
 	/* Pins not associated with a GPIO port */
 	SH_PFC_PIN_NAMED(3, 20, C20),
-	SH_PFC_PIN_NAMED(20, 1, T1),
-	SH_PFC_PIN_NAMED(25, 2, Y2),
+	SH_PFC_PIN_NAMED(1, 20, A20),
+	SH_PFC_PIN_NAMED(2, 25, B25),
 };
 
 /* - macro */
@@ -1400,7 +1400,7 @@ HSPI_PFC_DAT(hspi1_a,	HSPI_CLK1_A,		HSPI_CS1_A,
 			HSPI_RX1_A,		HSPI_TX1_A);
 
 HSPI_PFC_PIN(hspi1_b,	RCAR_GP_PIN(0, 27),	RCAR_GP_PIN(0, 26),
-			PIN_NUMBER(20, 1),	PIN_NUMBER(25, 2));
+			PIN_NUMBER(1, 20),	PIN_NUMBER(2, 25));
 HSPI_PFC_DAT(hspi1_b,	HSPI_CLK1_B,		HSPI_CS1_B,
 			HSPI_RX1_B,		HSPI_TX1_B);
 
-- 
2.17.1

Re: [PATCH] pinctrl: sh-pfc: r8a7778: Fix HSPI pin numbers and names

[Simon Horman]

On Wed, Jan 16, 2019 at 02:19:23PM +0100, Geert Uytterhoeven wrote:
> When declaring the HSPI RX1_B and TX1_B pins, two mistakes were made:
>   - the rows and columns in the BGA pin matrix, from which the pin
>     numbers are derived, were exchanged,
>   - it was not taken into account that BGA pin row labelling skips
>     characters I, O, Q, and S.
> 
> Fix the order, and the corresponding pin names.
> 
> Notes:
>   - The actual values of the pin numbers don't really matter (they just
>     have to be unique), so the wrong order didn't have any impact,
>   - Changing the names of the pins is user-visible, but there are no
>     users in (upstream) DTS files.
> 
> Fixes: 4f82e3ee724f1712 ("sh-pfc: Support pins not associated with a GPIO port")
> Fixes: 09cc76a95802e87d ("sh-pfc: r8a7778: add HSPI pin groups")
> Signed-off-by: Geert Uytterhoeven <geert+renesas@glider.be>

Reviewed-by: Simon Horman <horms+renesas@verge.net.au>