From: veeraiyan chidambaram <external.veeraiyan.c@de.adit-jv.com>
To: Yoshihiro Shimoda <yoshihiro.shimoda.uh@renesas.com>
Cc: Felipe Balbi <balbi@kernel.org>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Geert Uytterhoeven <geert+renesas@glider.be>,
Linux-Renesas <linux-renesas-soc@vger.kernel.org>,
"linux-usb@vger.kernel.org" <linux-usb@vger.kernel.org>,
Andrew Gabbasov <andrew_gabbasov@mentor.com>,
"REE erosca@DE.ADIT-JV.COM" <erosca@DE.ADIT-JV.COM>,
Veeraiyan Chidambaram <veeraiyan.chidambaram@in.bosch.com>
Subject: Re: [PATCH v4 2/3] usb: renesas_usbhs: enable DVSE interrupt
Date: Tue, 10 Sep 2019 11:31:17 +0200 [thread overview]
Message-ID: <20190910093117.GB9960@vmlxhi-070.adit-jv.com> (raw)
In-Reply-To: <TYAPR01MB4544C419E30F3D3033086088D8B60@TYAPR01MB4544.jpnprd01.prod.outlook.com>
Hello shimoda-san,
Thanks for point out checkpatch warning. After resolving checkpatch warning,
below checkpatch warning is seen.
WARNING: Possible unwrapped commit description (prefer a maximum 75 chars per line)
#23:
[1] commit f1407d5c6624 ("usb: renesas_usbhs: Add Renesas USBHS common code")
is this warning fine for you? .
Regards,
veeraiyan chidambaram.
On Tue, Sep 10, 2019 at 04:45:29AM +0000, Yoshihiro Shimoda wrote:
> Hi Veeraiyan,
>
> Thank you for the patch!
>
> > From: Veeraiyan Chidambaram, Sent: Tuesday, September 10, 2019 12:46 AM
> <snip>
> > Commit [1] enabled the possibility of checking the DVST (Device State
> > Transition) bit of INTSTS0 (Interrupt Status Register 0) and calling
> > the irq_dev_state() handler if the DVST bit is set. But neither
> > commit [1] nor commit [2] actually enabled the DVSE (Device State
> > Transition Interrupt Enable) bit in the INTENB0 (Interrupt Enable
> > Register 0). As a consequence, irq_dev_state() handler is getting
> > called as a side effect of other (non-DVSE) interrupts being fired,
> > which definitely can't be relied upon, if DVST notifications are of
> > any value.
> >
> > Why this doesn't hurt is because usbhsg_irq_dev_state() currently
> > doesn't do much except of a dev_dbg(). Once more work is added to
> > the handler (e.g. detecting device "Suspended" state and notifying
> > other USB gadget components about it), enabling DVSE becomes a hard
> > requirement. Do it in a standalone commit for better visibility and
> > clear explanation.
> >
> > [1] f1407d5c6624 ("usb: renesas_usbhs: Add Renesas USBHS common code")
> > [2] 2f98382dcdfe ("usb: renesas_usbhs: Add Renesas USBHS Gadget")
>
> I'm afraid I should have realized but, according to checkpatch.pl,
> these formats cause ERROR like below. So, they should be fixed.
>
> ERROR: Please use git commit description style 'commit <12+ chars of sha1> ("<title line>")' - ie: 'commit f1407d5c6624 ("usb: renesas_usbhs: Add Renesas USBHS common code")'
> #90:
> [1] f1407d5c6624 ("usb: renesas_usbhs: Add Renesas USBHS common code")
>
> ERROR: Please use git commit description style 'commit <12+ chars of sha1> ("<title line>")' - ie: 'commit 2f98382dcdfe ("usb: renesas_usbhs: Add Renesas USBHS Gadget")'
> #91:
> [2] 2f98382dcdfe ("usb: renesas_usbhs: Add Renesas USBHS Gadget")
>
> Best regards,
> Yoshihiro Shimoda
>
next prev parent reply other threads:[~2019-09-10 9:31 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-09-09 15:46 [PATCH v4 1/3] usb: renesas_usbhs: simplify usbhs_status_get_device_state() Veeraiyan Chidambaram
2019-09-09 15:46 ` [PATCH v4 2/3] usb: renesas_usbhs: enable DVSE interrupt Veeraiyan Chidambaram
2019-09-10 4:45 ` Yoshihiro Shimoda
2019-09-10 9:31 ` veeraiyan chidambaram [this message]
2019-09-11 2:45 ` Yoshihiro Shimoda
2019-09-11 13:22 ` veeraiyan chidambaram
2019-09-09 15:46 ` [PATCH v4 3/3] usb: renesas_usbhs: add suspend event support in gadget mode Veeraiyan Chidambaram
2019-09-10 4:47 ` Yoshihiro Shimoda
2019-09-10 4:41 ` [PATCH v4 1/3] usb: renesas_usbhs: simplify usbhs_status_get_device_state() Yoshihiro Shimoda
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190910093117.GB9960@vmlxhi-070.adit-jv.com \
--to=external.veeraiyan.c@de.adit-jv.com \
--cc=andrew_gabbasov@mentor.com \
--cc=balbi@kernel.org \
--cc=erosca@DE.ADIT-JV.COM \
--cc=geert+renesas@glider.be \
--cc=gregkh@linuxfoundation.org \
--cc=linux-renesas-soc@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=veeraiyan.chidambaram@in.bosch.com \
--cc=yoshihiro.shimoda.uh@renesas.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).